From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933085AbbJHODc (ORCPT ); Thu, 8 Oct 2015 10:03:32 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:52149 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932369AbbJHODa (ORCPT ); Thu, 8 Oct 2015 10:03:30 -0400 From: Arnd Bergmann To: Yaniv Gardi Cc: James.Bottomley@hansenpartnership.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org, gbroner@codeaurora.org, draviv@codeaurora.org, Noa Rubens , Raviv Shvili , Vinayak Holikatti , "James E.J. Bottomley" , "open list:ABI/API" Subject: Re: [PATCH v3] scsi: ufs: add ioctl interface for query request Date: Thu, 08 Oct 2015 16:03:08 +0200 Message-ID: <5970981.84uI3QIcdF@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1444302569-30740-1-git-send-email-ygardi@codeaurora.org> References: <1444302569-30740-1-git-send-email-ygardi@codeaurora.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:HG7YhIUHaMU6427eTyl8i1GNJByaUNlAK7AcRBGFk2vEEdtsYeK iM4BEZh6TnLOj5ZDP+JacirIgqG7fYIpqB/pfaPkDzmJIP5OHqi9UfMFQHQaJYvxC41kXrh kr10rpb/e/oumTPP/fzzcsxkvJePZwqjMgiocv2ZIavlc/UeFmzGZyPlivsedlHpJCKuTBO dEoF7m3DUo05onhoq0+HQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:hWAtvITQCbU=:vKhxnKbK3uumKMzICpOZ3F qABSom1B+8rFWiwQUSGkO5FciDjaqo9kxTzceYwd+zhmW7t7L6uQ85hhHPe4pOz5ykMnb/vMG ypJA4OMEDJ1rHbUG72czDR9y43CIT66Ngb03FFpQs9S89PUN4oYrmsHuoE1NQ52MG+EGxgxfR AuEz6hsV8hTXsi7yPiqIlgmvQUujNTdjKiwGcpwR7lzwk4i5gPBpXLe6Wmq96H1gfxPsgk+d3 XsxwDKKLsNgqaVhSLCQ8/G0gzjgLHgCXLyTnxggAmjxLHiZ1ouLjEwXEB3mbYGS/DcR5VGTH8 8yW4qAT6Az+JRcKgyP/XJfInwwVS68NKbGvnblS6w9vClc/P0+sGdTFzXaJNk0QhPgOq4yf/s /p9SGkaVC82QZT8BWuCUOOlb4fk4yMpX9YNwC8WCGXARfALjfr64JdbV3vk5pf4jFzNJzpiHX h1KEIOhfmQ28CmEtiowGN7xK/xDTxFBUizVuWy1eWXu1FwSOkyM9AH2vaOuEp1PkXaEDToEwQ YeG+++E1nMshZg10xbNoxCgSHvuIkRuSv+FSd3sjr7tH3f36FDpGY0uBeVD0cqbakIF0HBbyS vqZ2wlDDv6AdwPQI1129UiGP8LLgYVljRBSNbKmIX9COuDKjxpKt8ot016YJ3GU1tqwt51J/o ztu+CbB6qFKmj5X1hpeigNDkZPpj+bbkdqLIXwJPhLdcFcIfLxoYMUn2hK9tVq/QjX32ebXtv f9E78amh+zsj/Ng+ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 08 October 2015 14:09:24 Yaniv Gardi wrote: > This patch exposes the ioctl interface for UFS driver via SCSI device > ioctl interface. As of now UFS driver would provide the ioctl for query > interface to connected UFS device. > > Signed-off-by: Dolev Raviv > Signed-off-by: Noa Rubens > Signed-off-by: Raviv Shvili > Signed-off-by: Gilad Broner > Signed-off-by: Yaniv Gardi Thanks for the changes, looks much better already > @@ -5106,6 +5308,10 @@ static struct scsi_host_template ufshcd_driver_template = { > .eh_device_reset_handler = ufshcd_eh_device_reset_handler, > .eh_host_reset_handler = ufshcd_eh_host_reset_handler, > .eh_timed_out = ufshcd_eh_timed_out, > + .ioctl = ufshcd_ioctl, > +#ifdef CONFIG_COMPAT > + .compat_ioctl = ufshcd_ioctl, > +#endif > .this_id = -1, > .sg_tablesize = SG_ALL, > .cmd_per_lun = UFSHCD_CMD_PER_LUN, no need for the #ifdef here. > diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h > index e0a3398..fada160 100644 > --- a/include/scsi/scsi.h > +++ b/include/scsi/scsi.h > @@ -284,6 +284,7 @@ static inline int scsi_is_wlun(u64 lun) > * Here are some scsi specific ioctl commands which are sometimes useful. > * > * Note that include/linux/cdrom.h also defines IOCTL 0x5300 - 0x5395 > + * include/uapi/scsi/ufs/ioctl.h defines 0x5388 > */ > The comment is now wrong. Hmm, the buffer now is not aligned to four bytes, which will make copying it a bit slower. If that can be a concern, adding a padding byte would help. Arnd