The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Luka Gejak <luka.gejak@linux.dev>
To: Ping-Ke Shih <pkshih@realtek.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Michael Straube <straube.linux@gmail.com>,
	Bitterblue Smith <rtl8821cerfe2@gmail.com>,
	Peter Robinson <pbrobinson@gmail.com>,
	Hans de Goede <johannes.goede@oss.qualcomm.com>,
	luka.gejak@linux.dev
Subject: RE: [PATCH v7 0/6] wifi: rtw88: preparations for RTL8723B/RTL8723BS
Date: Tue, 25 Aug 2026 09:27:26 +0200	[thread overview]
Message-ID: <5970B165-077E-4A49-96BF-5AD15B583B45@linux.dev> (raw)
In-Reply-To: <803413aa2b1f44bbaa96b440b0693a58@realtek.com>

On August 25, 2026 9:08:02 AM GMT+02:00, Ping-Ke Shih <pkshih@realtek.com> wrote:

> Is this distribution of polling times?
> Does it mean 4 instances over 4 times of polling?

My fault for not explaining it. pollN counts wakes that finished on the Nth
read of REG_TCR, so poll1 needed one 20 ms sleep. fails counts the ones
still set after all five. So poll4=0 with fails=4 means nothing ever
succeeded on the last poll, yet four gave up completely. A budget that was
merely too small should taper instead. The patch also keeps polling for
another 500 ms and the bit was still set in all four.

> One reason the firmware can't leave LPS properly is that some packets
> are still in hardware queue, so this might be highly related to
> environment.

That fits better than anything I had, since it explains why it is either
quick or never. I will dump the queue lengths, REG_SDIO_FREE_TXPG and
REG_SDIO_OQT_FREE_PG at the failure and report back.

> More, it is worth to try disable_lps_deep=y.

Already off here, twice over: rtw8723b_hw_spec has
.lps_deep_mode_supported = 0 like rtw8723d and rtw8703b, and this firmware
reports no feature bits, so rtw_update_lps_deep_mode() returns
LPS_DEEP_MODE_NONE either way.

Best regards,
Luka Gejak

      reply	other threads:[~2026-08-25  7:27 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20  9:04 [PATCH v7 0/6] wifi: rtw88: preparations for RTL8723B/RTL8723BS luka.gejak
2026-08-20  9:04 ` [PATCH v7 1/6] wifi: rtw88: add the RTL8723B chip type and SDIO helper luka.gejak
2026-08-20  9:04 ` [PATCH v7 2/6] wifi: rtw88: rx: mark zero length packets on RTL8723BS luka.gejak
2026-08-20  9:04 ` [PATCH v7 3/6] wifi: rtw88: tx: extend the TX report purge timeout to RTL8723BS luka.gejak
2026-08-20  9:04 ` [PATCH v7 4/6] wifi: rtw88: sdio: track free TX pages and OQT credits for RTL8723BS luka.gejak
2026-08-25  6:12   ` Ping-Ke Shih
2026-08-25  7:20     ` Luka Gejak
2026-08-25  7:25       ` Ping-Ke Shih
2026-08-25  7:33         ` Luka Gejak
2026-08-25  7:50           ` Ping-Ke Shih
2026-08-25  8:07             ` Luka Gejak
2026-08-25  8:22               ` Ping-Ke Shih
2026-08-25  8:32                 ` Luka Gejak
2026-08-25  8:38                   ` Ping-Ke Shih
2026-08-25  8:42                     ` Luka Gejak
2026-08-25  8:49                       ` Ping-Ke Shih
2026-08-20  9:04 ` [PATCH v7 5/6] wifi: rtw88: sdio: set up RX aggregation and interrupts " luka.gejak
2026-08-20  9:04 ` [PATCH v7 6/6] wifi: rtw88: sdio: add TX back-pressure and retry on page starvation luka.gejak
2026-08-25  6:36   ` Ping-Ke Shih
2026-08-25  7:22     ` Luka Gejak
2026-08-25  8:27       ` Ping-Ke Shih
2026-08-22 16:51 ` [PATCH v7 0/6] wifi: rtw88: preparations for RTL8723B/RTL8723BS Luka Gejak
2026-08-23  6:00   ` Luka Gejak
2026-08-25  7:08     ` Ping-Ke Shih
2026-08-25  7:27       ` Luka Gejak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5970B165-077E-4A49-96BF-5AD15B583B45@linux.dev \
    --to=luka.gejak@linux.dev \
    --cc=johannes.goede@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pbrobinson@gmail.com \
    --cc=pkshih@realtek.com \
    --cc=rtl8821cerfe2@gmail.com \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox