Re: [PATCH 3/5] phy: phy-bcm-ns2-usbdrd: Replace the deprecated extcon API

Kishon Vijay Abraham I
2017-08-02T05:13:20Z

On Monday 17 July 2017 06:50 AM, Chanwoo Choi wrote:
> This patch replaces the deprecated extcon API as following:
> - extcon_set_cable_state_() -> extcon_get_state()
>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Raviteja Garimella <raviteja.garimella@broadcom.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c b/drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c
> index 9ae59e223131..d099a0c8cee5 100644
> --- a/drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c
> +++ b/drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c
> @@ -253,16 +253,16 @@ static void extcon_work(struct work_struct *work)
> vbus = gpiod_get_value_cansleep(driver->vbus_gpiod);
>
> if (!id && vbus) { /* Host connected */
> - extcon_set_cable_state_(driver->edev, EXTCON_USB_HOST, true);
> + extcon_set_state_sync(driver->edev, EXTCON_USB_HOST, true);
> pr_debug("Host cable connected\n");
> driver->data->new_state = EVT_HOST;
> connect_change(driver);
> } else if (id && !vbus) { /* Disconnected */
> - extcon_set_cable_state_(driver->edev, EXTCON_USB_HOST, false);
> - extcon_set_cable_state_(driver->edev, EXTCON_USB, false);
> + extcon_set_state_sync(driver->edev, EXTCON_USB_HOST, false);
> + extcon_set_state_sync(driver->edev, EXTCON_USB, false);
> pr_debug("Cable disconnected\n");
> } else if (id && vbus) { /* Device connected */
> - extcon_set_cable_state_(driver->edev, EXTCON_USB, true);
> + extcon_set_state_sync(driver->edev, EXTCON_USB, true);
> pr_debug("Device cable connected\n");
> driver->data->new_state = EVT_DEVICE;
> connect_change(driver);
>