Re: [PATCH] acpi: apei: clear error status before acknowledging the error

Borislav Petkov
2017-07-29T06:54:25Z

On Fri, Jul 28, 2017 at 04:25:03PM -0600, Tyler Baicar wrote:
> Currently we acknowledge errors before clearing the error status.
> This could cause a new error to be populated by firmware in-between
> the error acknowledgment and the error status clearing which would
> cause the second error's status to be cleared without being handled.
> So, clear the error status before acknowledging the errors.
>
> Also, make sure to acknowledge the error if the error status read
> fails.
>
> Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org>
> ---
> drivers/acpi/apei/ghes.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index d661d45..6a6895a 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -743,17 +743,15 @@ static int ghes_proc(struct ghes *ghes)
> }
> ghes_do_proc(ghes, ghes->estatus);
>
> +out:

If the first ghes_read_estatus() fails and we jump straight to that
label...

> + ghes_clear_estatus(ghes);
> /*
> * GHESv2 type HEST entries introduce support for error acknowledgment,
> * so only acknowledge the error if this support is present.
> */
> if (is_hest_type_generic_v2(ghes)) {
> rc = ghes_ack_error(ghes->generic_v2);

... and ACK the error anyway, even the status read failed, wouldn't that
confuse the firmware?

> - if (rc)
> - return rc;
> }

No need for the curly brackets anymore.

--
Regards/Gruss,
Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--