public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiangjianjun <jiangjianjun3@huawei.com>
To: John Garry <john.g.garry@oracle.com>
Cc: "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	lixiaokeng <lixiaokeng@huawei.com>,
	"hewenliang (C)" <hewenliang4@huawei.com>,
	"Yangkunlin(Poincare)" <yangkunlin7@huawei.com>,
	yangxingui <yangxingui@huawei.com>,
	"liyihang (C)" <liyihang9@huawei.com>
Subject: reply: reply: [RFC PATCH v3 00/19] scsi: scsi_error: Introduce new error handle mechanism
Date: Tue, 1 Apr 2025 03:32:11 +0000	[thread overview]
Message-ID: <598173fee9844be9ba19bfed35be2f5c@huawei.com> (raw)


On 31/03/2025 04:10, Jiangjianjun wrote:
> Sorry for late message! I'm working on fixing and testing these issues before re-emailing.

What are you actually working on?

It seems that Hannes' "scsi: EH rework, main part" series and maybe this one can help resolve this following issue:

https://lore.kernel.org/linux-block/eef1e927-c9b2-c61d-7f48-92e65d8b0418@huawei.com/

with fix attempted in:

https://lore.kernel.org/linux-ide/20241031140731.224589-4-cassel@kernel.org/

so that we don't see "fixes" like:
https://lore.kernel.org/linux-scsi/20250329073236.2300582-1-liyihang9@huawei.com/T/#m80bcb3f57fd176b7ce41b1f26e8560de6ad52c9d

> 
> -----邮件原件-----
> 发件人: Christoph Hellwig <hch@infradead.org>
> 发送时间: 2025年3月20日 14:06
> 收件人: Hannes Reinecke <hare@suse.de>
> 抄送: Jiangjianjun <jiangjianjun3@huawei.com>; jejb@linux.ibm.com; 
> martin.petersen@oracle.com; linux-scsi@vger.kernel.org; 
> linux-kernel@vger.kernel.org; lixiaokeng <lixiaokeng@huawei.com>; 
> hewenliang (C) <hewenliang4@huawei.com>; Yangkunlin(Poincare) 
> <yangkunlin7@huawei.com>
> 主题: Re: [RFC PATCH v3 00/19] scsi: scsi_error: Introduce new error 
> handle mechanism
> 
> On Fri, Mar 14, 2025 at 10:01:40AM +0100, Hannes Reinecke wrote:
>> 3. The current EH framework is designed around 'struct scsi_cmnd'.
>> Which means that the command _initiating_ the error handling can only 
>> be returned once the _entire_ error handling (with all
>> escalations) is finished. And more often than not, the application is 
>> waiting on that command to be completed before the next I/O is sent.
>> And that really limits the effectiveness of any improved error 
>> handler; the application ultimatively has to wait for a host reset 
>> before it can contine.
> 
> And someone needs to get your old series to fix that merged before we even start talking about any major EH change.
> 

Sorry, the previous engineer Wen Chao's work has changed. Now I will continue to complete this work. In the future.
I will analyze the details of the solution, improve and refine the above suggestions, and carefully submit the email.


             reply	other threads:[~2025-04-01  3:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01  3:32 Jiangjianjun [this message]
2025-04-01  9:24 ` reply: reply: [RFC PATCH v3 00/19] scsi: scsi_error: Introduce new error handle mechanism John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=598173fee9844be9ba19bfed35be2f5c@huawei.com \
    --to=jiangjianjun3@huawei.com \
    --cc=hewenliang4@huawei.com \
    --cc=jejb@linux.ibm.com \
    --cc=john.g.garry@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lixiaokeng@huawei.com \
    --cc=liyihang9@huawei.com \
    --cc=martin.petersen@oracle.com \
    --cc=yangkunlin7@huawei.com \
    --cc=yangxingui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox