From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756958AbcCXNuz (ORCPT ); Thu, 24 Mar 2016 09:50:55 -0400 Received: from mx2.suse.de ([195.135.220.15]:37648 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751607AbcCXNuq convert rfc822-to-8bit (ORCPT ); Thu, 24 Mar 2016 09:50:46 -0400 From: Johannes Thumshirn To: linux-nvdimm@ml01.01.org Cc: Dan Williams , linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/13] libnvdimm, pmem, pfn: make pmem_rw_bytes generic and refactor pfn setup Date: Thu, 24 Mar 2016 14:50:44 +0100 Message-ID: <5983443.ftVyGZcjEZ@c203> User-Agent: KMail/5.1.2 (Linux/4.5.0-1-default; KDE/5.20.0; x86_64; ; ) In-Reply-To: <20160324012618.21436.3392.stgit@dwillia2-desk3.jf.intel.com> References: <20160324012520.21436.22505.stgit@dwillia2-desk3.jf.intel.com> <20160324012618.21436.3392.stgit@dwillia2-desk3.jf.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mittwoch, 23. März 2016 18:26:18 CET Dan Williams wrote: > In preparation for providing an alternative (to block device) access > mechanism to persistent memory, convert pmem_rw_bytes() to > nsio_rw_bytes(). This allows ->rw_bytes() functionality without > requiring a 'struct pmem_device' to be instantiated. > > In other words, when ->rw_bytes() is in use i/o is driven through > 'struct nd_namespace_io', otherwise it is driven through 'struct > pmem_device' and the block layer. This consolidates the disjoint calls > to devm_exit_badblocks() and devm_memunmap() into a common > devm_nsio_disable() and cleans up the init path to use a unified > pmem_attach_disk() implementation. > > Signed-off-by: Dan Williams Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850