From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751870AbdHGCHZ (ORCPT ); Sun, 6 Aug 2017 22:07:25 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:31623 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751409AbdHGCHX (ORCPT ); Sun, 6 Aug 2017 22:07:23 -0400 X-AuditID: b6c32a46-f790d6d000003bf5-6d-5987cb582ac9 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <5987CB59.9070008@samsung.com> Date: Mon, 07 Aug 2017 11:07:21 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: balbi@kernel.org Cc: kishon@ti.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, chanwoo@kernel.org, myungjoo.ham@samsung.com, Raviteja Garimella Subject: Re: [PATCH v2 4/5] usb: gadget: udc: Replace the deprecated extcon API In-reply-to: <1501748448-26821-5-git-send-email-cw00.choi@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA01SWUwTURT1ddqZQa2OBfGFBB0n8QMMlRYKg4obhExcElA/RFQYYaCNdEmn ENG4VJYiqJFoojYiS1UUMGgRZFFBUCoVFRWQaMQQUNAfYlDEGBOnHYz8nXvvOXc5uTiiqEID cJ3BwpkNbCaFzpU2dgbRIYnPbImhvyYkdFfBKEaXDPZJ6VxHHUr3fjqF0s6RARn9puUySlde z0fo99YbKG11Fsk2+DD2j89Rxll9EmXaSmsxpv7qMebM3WrAuAbvSZhJ59J4bDe3VsuxaZyZ 5AypxjSdISOa2rIjOSZZExGqClFF0ZEUaWD1XDQVuzU+JE6XKWxGkdlsZpaQimd5nlq1bq3Z mGXhSK2Rt0RTSSqVWqkKjVSq1WpleNje1WqNQEnhtN1Wjcm24GDf8AQ4DprnFQEfHBLh8Jur GYjYH/YO1aFFYC6uIJoAPPH9IiYGkwDWTnRJ/ilc0y1ALNwCsH5qROopyIlFcPrckIBxHCGW wcevD3jSCBEEG1rrZhoNAdh6ehwV+cHwTkmtVyslVsAn3TVejAr5tvFBL2chsRz2T49411tM 7ILNZVOYB/sRfrBg7KLE0xQhpgB82t7lJfkSCXDc5fZiHyIOjl2q8JIgMYDB3oeeNXAhCITO dkS8JhYOu/NlIvaFX113MREHwOJCOyZqbcKVlz2XeYJCAD/etM4owqC7yCoR71wACzv/zAyQ w8IChUhhYE9ez8ywjfBk+zWZaEU/gJNVY8hZQNpnuWf/7559lnvlAKkG/pyJ12dwvNqkVvKs ns8yZChTjXon8D5pcFwTuPpiawcgcEDNl7fbbYkKGZvN5+g7AMQRyk+u1wkpeRqbc4gzG5PN WZkc3wE0gvklSMDiVKPw8gZLsio8KjQ8IkIdGUELn7dEfrRxYJeCyGAt3AGOM3HmfzoJ7hNw HGgezbHlNFiZRjdqTw8sdb3N7Wsorskd/t1cg8UeKXsTo807TC68rxt19Jx5WWasTipdj+e5 hp5/+BFnOr/JlH34Fdn7efsFR8pNt/n2T8An7CnbubSk8lb58qT0pvx9yP53mtKaRWStY6Di yspTuSNfEh3b6m88+I62bCen1rCbKSmvZVXBiJln/wIkabiyugMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrAIsWRmVeSWpSXmKPExsVy+t9jQd2I0+2RBn1LlSyOtT1ht5h44wqL RfPi9WwWF572sFlsenyN1eLyrjlsFouWtTJb3G5cwWbRuKmL1YHTY9b9s2wem1Z1snnsn7uG 3WPzknqPvi2rGD2O39jO5PF5k1wAe5SbTUZqYkpqkUJqXnJ+SmZeuq1SaIibroWSQl5ibqqt UoSub0iQkkJZYk4pkGdkgAYcnAPcg5X07RLcMk42mha081VcefiesYFxJ3cXIyeHhICJxPEf uxghbDGJC/fWs3UxcnEICaxmlJj3YhcrSIJXQFDix+R7LF2MHBzMAvISRy5lg4SZBdQlJs1b xAxR/4BR4vXG5WwQ9VoSGyeuYQGxWQRUJY6eXA1mswHF97+4AVbDL6AocfXHY0aQmaICERLd JypBwiICIhJtz2cwgcxkFvjGKNH75jIzSEJYwF9i0u977BDLrjJKHH90Gew4TgE3ieczFzJN YBScheTWWQi3zkJy6wJG5lWMYqkFxbnpucVGBUZ6xYm5xaV56XrJ+bmbGIGxue2wVsAOxqZz 0YcYBTgYlXh4D8xqjxRiTSwrrsw9xCjBwawkwpubCRTiTUmsrEotyo8vKs1JLT7EaAr06kRm KdHkfGDayCuJNzSxNDIxMDMzNDIwNlMS550Q+CVCSCA9sSQ1OzW1ILUIpo+Jg1OqgbHa0rvB /HnNAQPrintVm5TX8T2dfPXg6t0VD+KeaU1ZsHfR1bW+cjd3T+wwebQ35fva3IkPpq1edObi hzWtphdZ2uUD5S16S9mfB3JWBs1Ov1x/puPfvhitv9IuwWdTTr6NXxO6P/eO1Odp/wUXbFiz 8UjB8sCHkVnGqrdEzG2q1CwUrk6/dKJZiaU4I9FQi7moOBEAeI12J+MCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170807020720epcas2p41e79ebeefe58e59d4d753f9f23968d7e X-Msg-Generator: CA X-Sender-IP: 182.195.42.80 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170803082050epcas1p2491eedf2f26510f55cd15ce777356fce X-RootMTR: 20170803082050epcas1p2491eedf2f26510f55cd15ce777356fce References: <1501748448-26821-1-git-send-email-cw00.choi@samsung.com> <1501748448-26821-5-git-send-email-cw00.choi@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Felipe, Could you please review this patch? I hope to remove the deprecated extcon API. Regards, Chanwoo Choi On 2017년 08월 03일 17:20, Chanwoo Choi wrote: > This patch replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Cc: Raviteja Garimella > Signed-off-by: Chanwoo Choi > --- > drivers/usb/gadget/udc/snps_udc_plat.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/gadget/udc/snps_udc_plat.c b/drivers/usb/gadget/udc/snps_udc_plat.c > index 2e11f19e07ae..0ce7b3ba60ff 100644 > --- a/drivers/usb/gadget/udc/snps_udc_plat.c > +++ b/drivers/usb/gadget/udc/snps_udc_plat.c > @@ -184,7 +184,7 @@ static int udc_plat_probe(struct platform_device *pdev) > goto exit_phy; > } > > - ret = extcon_get_cable_state_(udc->edev, EXTCON_USB); > + ret = extcon_get_state(udc->edev, EXTCON_USB); > if (ret < 0) { > dev_err(dev, "Can't get cable state\n"); > goto exit_extcon; > @@ -273,7 +273,7 @@ static int udc_plat_suspend(struct device *dev) > udc = dev_get_drvdata(dev); > stop_udc(udc); > > - if (extcon_get_cable_state_(udc->edev, EXTCON_USB) > 0) { > + if (extcon_get_state(udc->edev, EXTCON_USB) > 0) { > dev_dbg(udc->dev, "device -> idle\n"); > stop_udc(udc); > } > @@ -303,7 +303,7 @@ static int udc_plat_resume(struct device *dev) > return ret; > } > > - if (extcon_get_cable_state_(udc->edev, EXTCON_USB) > 0) { > + if (extcon_get_state(udc->edev, EXTCON_USB) > 0) { > dev_dbg(udc->dev, "idle -> device\n"); > start_udc(udc); > } >