From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752024AbdHGGlH (ORCPT ); Mon, 7 Aug 2017 02:41:07 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:44518 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751508AbdHGGlF (ORCPT ); Mon, 7 Aug 2017 02:41:05 -0400 X-AuditID: b6c32a36-f79196d0000051db-62-59880b7e175b MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <59880B7F.2020300@samsung.com> Date: Mon, 07 Aug 2017 15:41:03 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Christophe JAILLET , myungjoo.ham@samsung.com Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] extcon: cros-ec: Fix a potential NULL pointer dereference In-reply-to: <20170807063033.8063-1-christophe.jaillet@wanadoo.fr> X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUgTcRzH+e/2cGqza2r9sLJ1FKHi2s2pMzQyxQYGzfKFGmLXPKa03cbd lDIkJTLTniwqthSlF2lDHNk0M0NbkWZR0XNGhvamhMoya/QiutsV9e7z//L9Pfy//HBMs6CI x6tYN8OxtJ1URsoHbiWmpByIairRt3Cm/pvtClP/5HLTk6E2pel1Q7dyk9x8POBD5vm+BPP8 G7/CgpUyWZUMXcFwWoa1OiuqWFs2WbCjPLc8LV1PpVCZpgxSy9IOJpvM22pJya+yC7NIbQ1t rxYkC83z5PqNWZyz2s1oK528O5vcSVEGHaXP0BkMBp0xtWyDIU2w7GIqn3eOY6451d4rM5eV 9WhE2YwicCCMcP5z1x9eCo+m/AJH4hpiEMHA+F2Z9JhH8LTlrPxvRcv0WJjDrgv3ikVWE0sg dHpK0HEcI1bB7cd7RBkjEqH/ul8l9ZlC8O3UT5nkT4L7bQcxkeXEWhg+9DDcUynoI+9fhjda TKyGZ6F3SOQ4ohiudXxXiRxLbIf+wCySBuTAt/FgmGMIC7z4cQ4Td4ggNsP0zBpxLhAtKgi9 6VWJOhAroW8UkzAPvM210q9iYHYsoJI4Hho+TMuk0sMIrrSJ3xIfTQjeXmpQSK5UmGhukEk7 RMOnhaMKqakamho1ksUM9V/OyiU5B3qOmKQYziDweCbQSaT1/pec919y3v+S60SYDy1lXLzD xvCUy6DjaQdfzdp0VqejD4VPLil9EF14sDWICByRi9Sj3sMlGgVdw+9zBBHgGBmrLoxsKtGo K+h9tQznLOeq7QwfRGlC8K1YfJzVKRww6y6njJl6Y7pBuLlMiiKXqeP8z4s1hI12M3sYxsVw f+tkeER8PQr48vWy0JOJY/cbvf7JhPZtslzZfu+cXX+s7lX+xQpf0bAOkrs+t3rO3Wgtm95f FfTsLmLNjdBR0Ls3z5zm+GrltvhmEuLIrO2//FctPdqhgnUoWj+cXNja7LKxcx+79ZMB7nFp VNQkN2/tDtUZfaN+T503un7VnRUPjpwg5XwlTSVhHE//BsKiwoeIAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEIsWRmVeSWpSXmKPExsVy+t9jAd067o5Ig9WL9S22HpzLarH1lrTF 5V1z2CxuN65gc2Dx6NuyitHj8yY5j89317MGMEe52WSkJqakFimk5iXnp2TmpdsqhYa46Voo KeQl5qbaKkXo+oYEKSmUJeaUAnlGBmjAwTnAPVhJ3y7BLePaghPMBR/YKzY/2sjWwLifrYuR k0NCwESi++FxFghbTOLCvfVAcS4OIYFtjBInHzQwgiR4BQQlfky+B1TEwcEsIC9x5FI2SJhZ QF1i0rxFzBD1Dxglri9ezQJRryVxZk4zM4jNIqAqsaf1PFicDSi+/8UNsMX8AooSV388ZgSZ KSoQIdF9ohIkLCIQILF07l4miPmOEl9OHAI7QVjAT6Lx1EwWiF3TGSUaXjeyg/RyCjhJPHyk MoFRcBaSS2chXDoLyaULGJlXMYqlFhTnpucWGxUY6hUn5haX5qXrJefnbmIExs+2w1r+Oxh/ nI0+xCjAwajEw3tgVnukEGtiWXFl7iFGCQ5mJRHeQK6OSCHelMTKqtSi/Pii0pzU4kOMpkCP TmSWEk3OB8Z2Xkm8oYmlkYmBmZmhkYGxmZI474TALxFCAumJJanZqakFqUUwfUwcnFINjLMq IzasDUywFXWa3W5+4oTtoabwZ3u3VIac21D1lFdUwHr1HvmNR3Yp3PokE1dhNjn6LEOkjUzs fxmphLkHO7IVzvQtWpn7g/v+55nnfNM123IKN65RLDlveSI36okXR/a6hS9j+LeGPLmR5LXb 3vFO0996laKsK3GO8Rx+r/zazjbcr6n6qcRSnJFoqMVcVJwIABQ7whW1AgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170807064102epcas1p264017c4d2fd9ac77536bd10d13cd38bf X-Msg-Generator: CA X-Sender-IP: 182.195.42.79 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170807063041epcas1p24acf2ca9a0dc16bbf1a800ad0dbb3e01 X-RootMTR: 20170807063041epcas1p24acf2ca9a0dc16bbf1a800ad0dbb3e01 References: <20170807063033.8063-1-christophe.jaillet@wanadoo.fr> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2017년 08월 07일 15:30, Christophe JAILLET wrote: > Return -ENOMEM in case of memory allocation failure. This avoids a NULL > pointer dereference. > > Fixes: c69831666109 ("extcon: cros-ec: Add extcon-cros-ec driver to support display out") > Signed-off-by: Christophe JAILLET > --- > drivers/extcon/extcon-usbc-cros-ec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/extcon/extcon-usbc-cros-ec.c b/drivers/extcon/extcon-usbc-cros-ec.c > index e759ed477735..598956f1dcae 100644 > --- a/drivers/extcon/extcon-usbc-cros-ec.c > +++ b/drivers/extcon/extcon-usbc-cros-ec.c > @@ -68,6 +68,8 @@ static int cros_ec_pd_command(struct cros_ec_extcon_info *info, > int ret; > > msg = kzalloc(sizeof(*msg) + max(outsize, insize), GFP_KERNEL); > + if (!msg) > + return -ENOMEM; > > msg->version = version; > msg->command = command; > Applied it. Thanks. -- Best Regards, Chanwoo Choi Samsung Electronics