From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752617AbdHIChs (ORCPT ); Tue, 8 Aug 2017 22:37:48 -0400 Received: from mga14.intel.com ([192.55.52.115]:17459 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752466AbdHIChr (ORCPT ); Tue, 8 Aug 2017 22:37:47 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,346,1498546800"; d="scan'208";a="1203569106" Subject: Re: [PATCH v2 2/4] usb: common: Move u_serial from gadget/function to usb/common To: Felipe Balbi , Mathias Nyman , Greg Kroah-Hartman References: <1502093269-15978-1-git-send-email-baolu.lu@linux.intel.com> <1502093269-15978-3-git-send-email-baolu.lu@linux.intel.com> <87inhzaj8t.fsf@linux.intel.com> <59891304.6050803@linux.intel.com> <8737927fi8.fsf@linux.intel.com> Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Lu Baolu Message-ID: <598A7577.2030008@linux.intel.com> Date: Wed, 9 Aug 2017 10:37:43 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <8737927fi8.fsf@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 08/08/2017 02:14 PM, Felipe Balbi wrote: > Hi, > > Lu Baolu writes: >>> Lu Baolu writes: >>>> The component u_serial provides a glue layer between TTY layer >>>> and a USB gadget device needed to provide a basic serial port >>>> functionality. Currently, u_serial sits under gadget/function >>>> and depends on CONFIG_USB_GADGET to be compiled and used. >>>> >>>> Most of the serial gadget devices are based on a UDC (USB device >>>> controller) and implemented by making use of the Linux gadget >>>> frameworks. But we are facing other implementions as well. One >>>> example can be found with xHCI debug capability. The xHCI debug >>>> capability implements a serial gadget with hardware and firmware, >>>> and provides an interface similar with xHCI host for submitting >>>> and reaping the transfer requests. >>>> >>>> In order to make better use of u_serial when implementing xHCI >>>> debug capability in xHCI driver, this patch moves u_serial.c >>>> from gadget/function to usb/common, and moves u_serial.h from >>>> gadget/function to include/linux/usb. >>>> >>>> Signed-off-by: Lu Baolu >>> NAK, u_serial uses the gadget API. It's definitely not COMMON. >>> >> Okay. It seems that I can't use u_serial anyway. I will implement >> a new tty glue for my case. > have you looked at drivers/usb/serial/? > Yes, I've checked that. I think usb-serial framework is too complex for this case. XHCI debug capability is a simple gadget attached to xHCI host. Best regards, Lu Baolu