From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752477AbdHJAJX (ORCPT ); Wed, 9 Aug 2017 20:09:23 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:27719 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752171AbdHJAJV (ORCPT ); Wed, 9 Aug 2017 20:09:21 -0400 X-AuditID: b6c32a46-f790d6d000003bf5-83-598ba42ebf90 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="utf-8" Message-id: <598BA42F.8060808@samsung.com> Date: Thu, 10 Aug 2017 09:09:19 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: balbi@kernel.org Cc: kishon@ti.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, chanwoo@kernel.org, myungjoo.ham@samsung.com, Raviteja Garimella Subject: Re: [PATCH v2 4/5] usb: gadget: udc: Replace the deprecated extcon API In-reply-to: <5987CB59.9070008@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBJsWRmVeSWpSXmKPExsWy7bCmua7eku5IgzNHJCyOtT1ht5h44wqL RfPi9WwWF572sFlsenyN1eLyrjlsFouWtTJb3G5cwWbRuKmL1YHTY9b9s2wem1Z1snnsn7uG 3WPzknqPvi2rGD2O39jO5PF5k1wAe1SqTUZqYkpqkUJqXnJ+SmZeuq2Sd3C8c7ypmYGhrqGl hbmSQl5ibqqtkotPgK5bZg7QZUoKZYk5pUChgMTiYiV9O5ui/NKSVIWM/OISW6VoQ0MjPUMD cz0jIyM9E+NYKyNToJKE1IwL57exFiwQrtjyaxV7A+MR/i5GTg4JAROJy89/MEPYYhIX7q1n 62Lk4hAS2MEo8XL1MkYI5zOjxK25L1hhOlZvXMEOkVjLKNG4ZTsjSIJXQFDix+R7LF2MHBzM AvISRy5lg4SZBTQlXnyZxAJRf49RYsfkPjaIei2JeZvmMYHYLAKqEqvmr2IHsdmA4vtf3ACr 4RdQlLj64zHYfFGBCImd87+B1YgIiEi0PZ/BBDKUWeAbo8SJA8fAioQFAiVeHD8FZnMKaEu8 efMebLOEwCV2iXdfj7CCXCchICux6QDUzy4SM/6+g7KFJV4d38IOYUtJdHfMYofobWeU2Dzn HtSgDkaJ+ysboWFhLHGqq5EJ4k8+iY7Df9khFvBKdLQJQZR4SJxpOQO1wFGi88BSVkhQAF09 /fkpxgmMCrOQQm8WIvRmIYXeAkbmVYxiqQXFuempxUYFRnrFibnFpXnpesn5uZsYwalUy20H 45JzPocYBTgYlXh4E0S7I4VYE8uKK3MPMUpwMCuJ8GZMBwrxpiRWVqUW5ccXleakFh9iNAUG /kRmKdHkfGCazyuJNzSxNDAxMzMyN7MAJj1x3rpt1yKEBNITS1KzU1MLUotg+pg4OKUaGC/4 BxlN36OyK+QJd7HtHub/uYyaO0MzVomW2X05aVW6bot9qVchX3ONoM6i2bs+nDrWt4nV4Yjt ociZzbN5K5LOqp5fxfDePPNRoDubw65LGRuWRO9uDnbPO7jG0CnJ/rLAtWNcO+5m73zAxvDo LhfP42XNa6ZcTYhIvuOjLWdQadD3XZVhoxJLcUaioRZzUXEiADfj4fq7AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrPIsWRmVeSWpSXmKPExsVy+t9jQV3dJd2RBm9fiVoca3vCbjHxxhUW i+bF69ksLjztYbPY9Pgaq8XlXXPYLBYta2W2uN24gs2icVMXqwOnx6z7Z9k8Nq3qZPPYP3cN u8fmJfUefVtWMXocv7GdyePzJrkA9ig3m4zUxJTUIoXUvOT8lMy8dFul0BA3XQslhbzE3FRb pQhd35AgJYWyxJxSIM/IAA04OAe4Byvp2yW4ZVw4v421YIFwxZZfq9gbGI/wdzFyckgImEis 3riCHcIWk7hwbz1bFyMXh5DAakaJP7uPMoEkeAUEJX5MvsfSxcjBwSwgL3HkUjaEqS4xZUou RPkDRontX86yQZRrSczbNA+slUVAVWLV/FVg89mA4vtf3ACr4RdQlLj64zEjyBxRgQiJ7hOV IGERARGJtuczmEBmMgt8Y5TofXOZGSQhLOAvMen3PXaIZUCJF83PGUESnALaEm/evGeZwCg4 C8mpsxBOnYVw6gJG5lWMYqkFxbnpucVGBUZ6xYm5xaV56XrJ+bmbGIGRue2wVsAOxqZz0YcY BTgYlXh4OYS7I4VYE8uKK3MPMUpwMCuJ8GZMBwrxpiRWVqUW5ccXleakFh9iNAX6dCKzlGhy PjBp5JXEG5pYGpkYmJkZGhkYmymJ804I/BIhJJCeWJKanZpakFoE08fEwSnVwGifLLLF/lho z8SvrAqz05be/CI4NVJoiU6kTajO25Xc+iy3g2aKPOlLOnUuYEfctiX7J05XiLPMmxW5+GaD tcqnb+sjr3K9273l5j+JyAqhjkXcByrL8rhd58hLXrn/0fOSWvReQ5EH7FYXvWa9bD+z38bC cOap1gNnZl/qd+186l65wXxpbbESS3FGoqEWc1FxIgD8cOxU4gIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170810000917epcas2p1f05438edf7edde9896f931f9015633e8 X-Msg-Generator: CA X-Sender-IP: 182.195.42.80 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170803082050epcas1p2491eedf2f26510f55cd15ce777356fce X-RootMTR: 20170803082050epcas1p2491eedf2f26510f55cd15ce777356fce References: <1501748448-26821-1-git-send-email-cw00.choi@samsung.com> <1501748448-26821-5-git-send-email-cw00.choi@samsung.com> <5987CB59.9070008@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping. Hi Felipe, I sent the first patch[1] more than three weeks ago. But I didn't receive the any review. [1] https://lkml.org/lkml/2017/7/16/523 This patch is very simple. After finishing the review I'll remove the deprecated extcon API and then send the immutable branch to both phy and usb maintainer. Usually, I send the extcon's pull request to the GregKH for the next merge after releasing 4.x-rc6. (4.x-rc4 was released) Please review this patch. On 2017년 08월 07일 11:07, Chanwoo Choi wrote: > Dear Felipe, > > Could you please review this patch? > I hope to remove the deprecated extcon API. > > Regards, > Chanwoo Choi > > On 2017년 08월 03일 17:20, Chanwoo Choi wrote: >> This patch replaces the deprecated extcon API as following: >> - extcon_get_cable_state_() -> extcon_get_state() >> >> Cc: Felipe Balbi >> Cc: Greg Kroah-Hartman >> Cc: Raviteja Garimella >> Signed-off-by: Chanwoo Choi >> --- >> drivers/usb/gadget/udc/snps_udc_plat.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/usb/gadget/udc/snps_udc_plat.c b/drivers/usb/gadget/udc/snps_udc_plat.c >> index 2e11f19e07ae..0ce7b3ba60ff 100644 >> --- a/drivers/usb/gadget/udc/snps_udc_plat.c >> +++ b/drivers/usb/gadget/udc/snps_udc_plat.c >> @@ -184,7 +184,7 @@ static int udc_plat_probe(struct platform_device *pdev) >> goto exit_phy; >> } >> >> - ret = extcon_get_cable_state_(udc->edev, EXTCON_USB); >> + ret = extcon_get_state(udc->edev, EXTCON_USB); >> if (ret < 0) { >> dev_err(dev, "Can't get cable state\n"); >> goto exit_extcon; >> @@ -273,7 +273,7 @@ static int udc_plat_suspend(struct device *dev) >> udc = dev_get_drvdata(dev); >> stop_udc(udc); >> >> - if (extcon_get_cable_state_(udc->edev, EXTCON_USB) > 0) { >> + if (extcon_get_state(udc->edev, EXTCON_USB) > 0) { >> dev_dbg(udc->dev, "device -> idle\n"); >> stop_udc(udc); >> } >> @@ -303,7 +303,7 @@ static int udc_plat_resume(struct device *dev) >> return ret; >> } >> >> - if (extcon_get_cable_state_(udc->edev, EXTCON_USB) > 0) { >> + if (extcon_get_state(udc->edev, EXTCON_USB) > 0) { >> dev_dbg(udc->dev, "idle -> device\n"); >> start_udc(udc); >> } >> > > > > -- Best Regards, Chanwoo Choi Samsung Electronics