From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752168AbdHKBai (ORCPT ); Thu, 10 Aug 2017 21:30:38 -0400 Received: from regular1.263xmail.com ([211.150.99.136]:44174 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751463AbdHKBaf (ORCPT ); Thu, 10 Aug 2017 21:30:35 -0400 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: broonie@kernel.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <4dfda3b0adad952b1536deba9274798b> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <598D08AD.8090609@rock-chips.com> Date: Fri, 11 Aug 2017 09:30:21 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Mark Brown CC: linux-kernel@vger.kernel.org, dgreid@chromium.org, heiko@sntech.de, briannorris@chromium.org, dianders@chromium.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Liam Girdwood , linux-rockchip@lists.infradead.org, Rob Herring , Mark Rutland , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/3] dt-bindings: ASoC: rockchip: Add rockchip,codec-names property References: <1502340898-28403-1-git-send-email-jeffy.chen@rock-chips.com> <1502340898-28403-4-git-send-email-jeffy.chen@rock-chips.com> <20170810145607.g663oq7cfxjmaxtf@sirena.org.uk> In-Reply-To: <20170810145607.g663oq7cfxjmaxtf@sirena.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On 08/10/2017 10:56 PM, Mark Brown wrote: > On Thu, Aug 10, 2017 at 12:54:58PM +0800, Jeffy Chen wrote: >> Add a new rockchip,codec-names property, so that the driver can parse >> the codecs by name. > > Why? You're already referencing the CODECs by phandle and these names > are not part of any ABI... > currently we are binding the phandles to a fixed codec list in the driver. but we want to make it dynamic, since some exist codecs could be optional, and some new codecs could be add for new board too. and the support of this new property in the driver is added in https://patchwork.kernel.org/patch/9892737