From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752274AbdHPJSr (ORCPT ); Wed, 16 Aug 2017 05:18:47 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3556 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751569AbdHPJSp (ORCPT ); Wed, 16 Aug 2017 05:18:45 -0400 Subject: Re: [PATCH] ARM: hisi: Fix typo in comment To: Yunzhi Li , References: <20170807093322.26050-1-yunzhi.li@deephi.tech> CC: , Russell King , , Linuxarm From: Wei Xu Message-ID: <59940DDE.1000906@hisilicon.com> Date: Wed, 16 Aug 2017 10:18:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20170807093322.26050-1-yunzhi.li@deephi.tech> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.181.154] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090202.59940DEE.0005,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 33734979f14e800f924c435a7df81b46 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yunzhi, On 2017/8/7 10:33, Yunzhi Li wrote: > Fix the rc vs. pc typo. There is no a register named rc, I felt > confused when I read this assembler command in comment. > Thanks! Yes, it is a typo. And 0xe51ff004 is the machine code to do the jump. I will change the commit msg as below and pick up it: The machine code "0xe51ff004" means "ldr pc, [pc, #-4]". This patch fixed the comment typo to avoid any confusion. Best Regards, Wei > Signed-off-by: Yunzhi Li > --- > > arch/arm/mach-hisi/platsmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-hisi/platsmp.c b/arch/arm/mach-hisi/platsmp.c > index 91bb02dec20f..da5689ababf7 100644 > --- a/arch/arm/mach-hisi/platsmp.c > +++ b/arch/arm/mach-hisi/platsmp.c > @@ -109,7 +109,7 @@ static void hix5hd2_set_scu_boot_addr(phys_addr_t start_addr, phys_addr_t jump_a > > virt = ioremap(start_addr, PAGE_SIZE); > > - writel_relaxed(0xe51ff004, virt); /* ldr pc, [rc, #-4] */ > + writel_relaxed(0xe51ff004, virt); /* ldr pc, [pc, #-4] */ > writel_relaxed(jump_addr, virt + 4); /* pc jump phy address */ > iounmap(virt); > } >