From: jeffy <jeffy.chen@rock-chips.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, dgreid@chromium.org,
heiko@sntech.de, briannorris@chromium.org, mka@chromium.org,
dianders@chromium.org, Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, Oder Chiou <oder_chiou@realtek.com>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Bard Liao <bardliao@realtek.com>
Subject: Re: [PATCH v3 1/9] ASoC: rt5514: Switch to snd_soc_register_codec
Date: Fri, 18 Aug 2017 10:48:39 +0800 [thread overview]
Message-ID: <59965587.7040409@rock-chips.com> (raw)
In-Reply-To: <20170817171120.xvvsmx2fleeqj2s5@sirena.org.uk>
Hi Mark,
On 08/18/2017 01:11 AM, Mark Brown wrote:
> On Thu, Aug 17, 2017 at 12:44:09PM +0800, Jeffy Chen wrote:
>> Currently we are using devm_snd_soc_register_component, which would
>> use legacy dai name.
>
>> Switch to snd_soc_register_codec to use dai driver name.
>
> This is the wrong direction to be going in, we are trying to move all
> drivers to use component. Whatever you want to do make components use
> it.
>
i was trying to make dai name use dai driver name:
/*
* Back in the old days when we still had component-less DAIs,
* instead of having a static name, component-less DAIs would
* inherit the name of the parent device so it is possible to
* register multiple instances of the DAI. We still need to keep
* the same naming style even though those DAIs are not
* component-less anymore.
*/
if (legacy_dai_naming &&
(dai_drv->id == 0 || dai_drv->name == NULL)) {
dai->name = fmt_single_name(dev, &dai->id);
} else {
dai->name = fmt_multiple_name(dev, dai_drv);
specify an non-zero id for dai driver works too, i'll do it in new
patches :)
next prev parent reply other threads:[~2017-08-18 2:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 4:44 [PATCH v3 0/9] ASoC: rockchip: Parse dai links from dts Jeffy Chen
2017-08-17 4:44 ` [PATCH v3 1/9] ASoC: rt5514: Switch to snd_soc_register_codec Jeffy Chen
2017-08-17 17:11 ` Mark Brown
2017-08-18 2:48 ` jeffy [this message]
2017-08-17 4:44 ` [PATCH v3 2/9] ASoC: rockchip: Remove obsolete dmic-delay Jeffy Chen
2017-08-17 17:11 ` Mark Brown
2017-08-18 1:41 ` jeffy
2017-08-18 11:52 ` Mark Brown
2017-08-18 14:41 ` jeffy
2017-08-17 4:44 ` [PATCH v3 3/9] ASoC: rockchip: Use codec of_node and dai_name for rt5514 dsp Jeffy Chen
2017-08-17 4:44 ` [PATCH v3 4/9] arm64: dts: rockchip: Add rt5514 dsp for Gru Jeffy Chen
2017-08-17 4:44 ` [PATCH v3 5/9] arm64: dts: rockchip: Update rt5514 devices' compatible " Jeffy Chen
2017-08-17 4:44 ` [PATCH v3 6/9] ASoC: rockchip: Parse dai links from dts Jeffy Chen
2017-08-17 4:44 ` [PATCH v3 7/9] ASoC: rockchip: Add support for DP codec Jeffy Chen
2017-08-29 19:26 ` Applied "ASoC: rockchip: Add support for DP codec" to the asoc tree Mark Brown
2017-08-17 4:44 ` [PATCH v3 8/9] ASoC: rockchip: Add support for DMIC codec Jeffy Chen
2017-08-17 4:44 ` [PATCH v3 9/9] dt-bindings: ASoC: rockchip: Update description of rockchip,codec Jeffy Chen
2017-08-17 22:20 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59965587.7040409@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=briannorris@chromium.org \
--cc=broonie@kernel.org \
--cc=dgreid@chromium.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox