From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753953AbdHRCtF (ORCPT ); Thu, 17 Aug 2017 22:49:05 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:33579 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753856AbdHRCtE (ORCPT ); Thu, 17 Aug 2017 22:49:04 -0400 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: broonie@kernel.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <2ae1be75468fa2113a1d08c2283ea92b> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <59965587.7040409@rock-chips.com> Date: Fri, 18 Aug 2017 10:48:39 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Mark Brown CC: linux-kernel@vger.kernel.org, dgreid@chromium.org, heiko@sntech.de, briannorris@chromium.org, mka@chromium.org, dianders@chromium.org, Jaroslav Kysela , alsa-devel@alsa-project.org, Oder Chiou , Takashi Iwai , Liam Girdwood , Bard Liao Subject: Re: [PATCH v3 1/9] ASoC: rt5514: Switch to snd_soc_register_codec References: <20170817044417.22069-1-jeffy.chen@rock-chips.com> <20170817044417.22069-2-jeffy.chen@rock-chips.com> <20170817171120.xvvsmx2fleeqj2s5@sirena.org.uk> In-Reply-To: <20170817171120.xvvsmx2fleeqj2s5@sirena.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On 08/18/2017 01:11 AM, Mark Brown wrote: > On Thu, Aug 17, 2017 at 12:44:09PM +0800, Jeffy Chen wrote: >> Currently we are using devm_snd_soc_register_component, which would >> use legacy dai name. > >> Switch to snd_soc_register_codec to use dai driver name. > > This is the wrong direction to be going in, we are trying to move all > drivers to use component. Whatever you want to do make components use > it. > i was trying to make dai name use dai driver name: /* * Back in the old days when we still had component-less DAIs, * instead of having a static name, component-less DAIs would * inherit the name of the parent device so it is possible to * register multiple instances of the DAI. We still need to keep * the same naming style even though those DAIs are not * component-less anymore. */ if (legacy_dai_naming && (dai_drv->id == 0 || dai_drv->name == NULL)) { dai->name = fmt_single_name(dev, &dai->id); } else { dai->name = fmt_multiple_name(dev, dai_drv); specify an non-zero id for dai driver works too, i'll do it in new patches :)