* Re: [PATCH] mfd: max77693: Add muic of_compatible in mfd_cell
2017-08-21 10:53 ` [PATCH] mfd: max77693: Add muic of_compatible in mfd_cell Maciej Purski
@ 2017-08-21 10:55 ` Chanwoo Choi
2017-08-21 17:58 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Chanwoo Choi @ 2017-08-21 10:55 UTC (permalink / raw)
To: Maciej Purski, linux-kernel; +Cc: krzk, lee.jones, b.zolnierkie
Hi,
On 2017년 08월 21일 19:53, Maciej Purski wrote:
> This patch adds muic of_compatible in order to use the muic device
> driver in device tree.
>
> Signed-off-by: Maciej Purski <m.purski@samsung.com>
> ---
> drivers/mfd/max77693.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index 662ae0d..1c05ea0 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -48,7 +48,10 @@ static const struct mfd_cell max77693_devs[] = {
> .name = "max77693-charger",
> .of_compatible = "maxim,max77693-charger",
> },
> - { .name = "max77693-muic", },
> + {
> + .name = "max77693-muic",
> + .of_compatible = "maxim,max77693-muic",
> + },
> {
> .name = "max77693-haptic",
> .of_compatible = "maxim,max77693-haptic",
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mfd: max77693: Add muic of_compatible in mfd_cell
2017-08-21 10:53 ` [PATCH] mfd: max77693: Add muic of_compatible in mfd_cell Maciej Purski
2017-08-21 10:55 ` Chanwoo Choi
@ 2017-08-21 17:58 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2017-08-21 17:58 UTC (permalink / raw)
To: Maciej Purski; +Cc: linux-kernel, cw00.choi, lee.jones, b.zolnierkie
On Mon, Aug 21, 2017 at 12:53:43PM +0200, Maciej Purski wrote:
> This patch adds muic of_compatible in order to use the muic device
> driver in device tree.
Please document it in similar way as in for example
Documentation/devicetree/bindings/mfd/max14577.txt
or in other way.
Best regards,
Krzysztof
>
> Signed-off-by: Maciej Purski <m.purski@samsung.com>
> ---
> drivers/mfd/max77693.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index 662ae0d..1c05ea0 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -48,7 +48,10 @@ static const struct mfd_cell max77693_devs[] = {
> .name = "max77693-charger",
> .of_compatible = "maxim,max77693-charger",
> },
> - { .name = "max77693-muic", },
> + {
> + .name = "max77693-muic",
> + .of_compatible = "maxim,max77693-muic",
> + },
> {
> .name = "max77693-haptic",
> .of_compatible = "maxim,max77693-haptic",
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread