* [PATCH v2] mfd: max77693: Add muic of_compatible in mfd_cell
[not found] <CGME20170822070923eucas1p2fb95310a7376a7a2869a970756d75631@eucas1p2.samsung.com>
@ 2017-08-22 7:09 ` Maciej Purski
2017-08-22 7:14 ` Chanwoo Choi
0 siblings, 1 reply; 3+ messages in thread
From: Maciej Purski @ 2017-08-22 7:09 UTC (permalink / raw)
To: linux-kernel; +Cc: cw00.choi, krzk, lee.jones, b.zolnierkie, Maciej Purski
This patch adds muic of_compatible in order to use the muic device
driver in device tree.
v2:
- added muic to documentation
Signed-off-by: Maciej Purski <m.purski@samsung.com>
---
Documentation/devicetree/bindings/mfd/max77693.txt | 6 ++++++
drivers/mfd/max77693.c | 5 ++++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt
index 6a1ae3a..6ca2478 100644
--- a/Documentation/devicetree/bindings/mfd/max77693.txt
+++ b/Documentation/devicetree/bindings/mfd/max77693.txt
@@ -127,6 +127,12 @@ Required properties for the LED child node:
Optional properties for the LED child node:
- label : see Documentation/devicetree/bindings/leds/common.txt
+Optional nodes:
+- max77693-muic/max77693-muic :
+ Node used only by extcon consumers.
+ Required properties:
+ - compatible : "maxim,max77693-muic" or "maxim,max77693-muic"
+
Example:
#include <dt-bindings/leds/common.h>
diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
index 662ae0d..1c05ea0 100644
--- a/drivers/mfd/max77693.c
+++ b/drivers/mfd/max77693.c
@@ -48,7 +48,10 @@ static const struct mfd_cell max77693_devs[] = {
.name = "max77693-charger",
.of_compatible = "maxim,max77693-charger",
},
- { .name = "max77693-muic", },
+ {
+ .name = "max77693-muic",
+ .of_compatible = "maxim,max77693-muic",
+ },
{
.name = "max77693-haptic",
.of_compatible = "maxim,max77693-haptic",
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mfd: max77693: Add muic of_compatible in mfd_cell
2017-08-22 7:09 ` [PATCH v2] mfd: max77693: Add muic of_compatible in mfd_cell Maciej Purski
@ 2017-08-22 7:14 ` Chanwoo Choi
2017-08-22 7:16 ` Chanwoo Choi
0 siblings, 1 reply; 3+ messages in thread
From: Chanwoo Choi @ 2017-08-22 7:14 UTC (permalink / raw)
To: Maciej Purski, linux-kernel; +Cc: krzk, lee.jones, b.zolnierkie
Hi,
On 2017년 08월 22일 16:09, Maciej Purski wrote:
> This patch adds muic of_compatible in order to use the muic device
> driver in device tree.
>
> v2:
> - added muic to documentation
>
> Signed-off-by: Maciej Purski <m.purski@samsung.com>
> ---
> Documentation/devicetree/bindings/mfd/max77693.txt | 6 ++++++
> drivers/mfd/max77693.c | 5 ++++-
> 2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt
> index 6a1ae3a..6ca2478 100644
> --- a/Documentation/devicetree/bindings/mfd/max77693.txt
> +++ b/Documentation/devicetree/bindings/mfd/max77693.txt
> @@ -127,6 +127,12 @@ Required properties for the LED child node:
> Optional properties for the LED child node:
> - label : see Documentation/devicetree/bindings/leds/common.txt
>
> +Optional nodes:
> +- max77693-muic/max77693-muic :
> + Node used only by extcon consumers.
> + Required properties:
> + - compatible : "maxim,max77693-muic" or "maxim,max77693-muic"
"maxim,max77693-muic" is duplicate. Please add just one compatible.
> +
> Example:
> #include <dt-bindings/leds/common.h>
>
> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index 662ae0d..1c05ea0 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -48,7 +48,10 @@ static const struct mfd_cell max77693_devs[] = {
> .name = "max77693-charger",
> .of_compatible = "maxim,max77693-charger",
> },
> - { .name = "max77693-muic", },
> + {
> + .name = "max77693-muic",
> + .of_compatible = "maxim,max77693-muic",
> + },
> {
> .name = "max77693-haptic",
> .of_compatible = "maxim,max77693-haptic",
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mfd: max77693: Add muic of_compatible in mfd_cell
2017-08-22 7:14 ` Chanwoo Choi
@ 2017-08-22 7:16 ` Chanwoo Choi
0 siblings, 0 replies; 3+ messages in thread
From: Chanwoo Choi @ 2017-08-22 7:16 UTC (permalink / raw)
To: Maciej Purski, linux-kernel; +Cc: krzk, lee.jones, b.zolnierkie
On 2017년 08월 22일 16:14, Chanwoo Choi wrote:
> Hi,
>
> On 2017년 08월 22일 16:09, Maciej Purski wrote:
>> This patch adds muic of_compatible in order to use the muic device
>> driver in device tree.
>>
>> v2:
>> - added muic to documentation
>>
>> Signed-off-by: Maciej Purski <m.purski@samsung.com>
>> ---
>> Documentation/devicetree/bindings/mfd/max77693.txt | 6 ++++++
>> drivers/mfd/max77693.c | 5 ++++-
>> 2 files changed, 10 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt
>> index 6a1ae3a..6ca2478 100644
>> --- a/Documentation/devicetree/bindings/mfd/max77693.txt
>> +++ b/Documentation/devicetree/bindings/mfd/max77693.txt
>> @@ -127,6 +127,12 @@ Required properties for the LED child node:
>> Optional properties for the LED child node:
>> - label : see Documentation/devicetree/bindings/leds/common.txt
>>
>> +Optional nodes:
>> +- max77693-muic/max77693-muic :
Also, max77693-muic is duplicate.
>> + Node used only by extcon consumers.
>> + Required properties:
>> + - compatible : "maxim,max77693-muic" or "maxim,max77693-muic"
>
> "maxim,max77693-muic" is duplicate. Please add just one compatible.
>
>> +
>> Example:
>> #include <dt-bindings/leds/common.h>
>>
>> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
>> index 662ae0d..1c05ea0 100644
>> --- a/drivers/mfd/max77693.c
>> +++ b/drivers/mfd/max77693.c
>> @@ -48,7 +48,10 @@ static const struct mfd_cell max77693_devs[] = {
>> .name = "max77693-charger",
>> .of_compatible = "maxim,max77693-charger",
>> },
>> - { .name = "max77693-muic", },
>> + {
>> + .name = "max77693-muic",
>> + .of_compatible = "maxim,max77693-muic",
>> + },
>> {
>> .name = "max77693-haptic",
>> .of_compatible = "maxim,max77693-haptic",
>>
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-22 7:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20170822070923eucas1p2fb95310a7376a7a2869a970756d75631@eucas1p2.samsung.com>
2017-08-22 7:09 ` [PATCH v2] mfd: max77693: Add muic of_compatible in mfd_cell Maciej Purski
2017-08-22 7:14 ` Chanwoo Choi
2017-08-22 7:16 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox