* Re: [PATCH v3] mfd: max77693: Add muic of_compatible in mfd_cell
2017-08-22 7:38 ` [PATCH v3] mfd: max77693: Add muic of_compatible in mfd_cell Maciej Purski
@ 2017-08-22 7:50 ` Chanwoo Choi
2017-08-22 12:01 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Chanwoo Choi @ 2017-08-22 7:50 UTC (permalink / raw)
To: Maciej Purski, linux-kernel; +Cc: krzk, lee.jones, b.zolnierkie
On 2017년 08월 22일 16:38, Maciej Purski wrote:
> This patch adds muic of_compatible in order to use the muic device
> driver in device tree.
>
> v2:
> - added muic to documentation
>
> v3:
> - removed duplication
>
> Signed-off-by: Maciej Purski <m.purski@samsung.com>
> ---
> Documentation/devicetree/bindings/mfd/max77693.txt | 6 ++++++
> drivers/mfd/max77693.c | 5 ++++-
> 2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt
> index 6a1ae3a..e675497 100644
> --- a/Documentation/devicetree/bindings/mfd/max77693.txt
> +++ b/Documentation/devicetree/bindings/mfd/max77693.txt
> @@ -127,6 +127,12 @@ Required properties for the LED child node:
> Optional properties for the LED child node:
> - label : see Documentation/devicetree/bindings/leds/common.txt
>
> +Optional nodes:
> +- max77693-muic :
> + Node used only by extcon consumers.
> + Required properties:
> + - compatible : "maxim,max77693-muic"
> +
> Example:
> #include <dt-bindings/leds/common.h>
>
> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index 662ae0d..1c05ea0 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -48,7 +48,10 @@ static const struct mfd_cell max77693_devs[] = {
> .name = "max77693-charger",
> .of_compatible = "maxim,max77693-charger",
> },
> - { .name = "max77693-muic", },
> + {
> + .name = "max77693-muic",
> + .of_compatible = "maxim,max77693-muic",
> + },
> {
> .name = "max77693-haptic",
> .of_compatible = "maxim,max77693-haptic",
>
Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v3] mfd: max77693: Add muic of_compatible in mfd_cell
2017-08-22 7:38 ` [PATCH v3] mfd: max77693: Add muic of_compatible in mfd_cell Maciej Purski
2017-08-22 7:50 ` Chanwoo Choi
@ 2017-08-22 12:01 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2017-08-22 12:01 UTC (permalink / raw)
To: Maciej Purski
Cc: linux-kernel, Chanwoo Choi, lee.jones,
Bartłomiej Żołnierkiewicz, devicetree
On Tue, Aug 22, 2017 at 9:38 AM, Maciej Purski <m.purski@samsung.com> wrote:
> This patch adds muic of_compatible in order to use the muic device
> driver in device tree.
>
> v2:
> - added muic to documentation
Change log should not go to commit message. Put it after separator ---.
+cc devicetree - scripts/get_maintainer.pl should point you that list.
With the change in commit msg:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
>
> v3:
> - removed duplication
>
> Signed-off-by: Maciej Purski <m.purski@samsung.com>
> ---
> Documentation/devicetree/bindings/mfd/max77693.txt | 6 ++++++
> drivers/mfd/max77693.c | 5 ++++-
> 2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt
> index 6a1ae3a..e675497 100644
> --- a/Documentation/devicetree/bindings/mfd/max77693.txt
> +++ b/Documentation/devicetree/bindings/mfd/max77693.txt
> @@ -127,6 +127,12 @@ Required properties for the LED child node:
> Optional properties for the LED child node:
> - label : see Documentation/devicetree/bindings/leds/common.txt
>
> +Optional nodes:
> +- max77693-muic :
> + Node used only by extcon consumers.
> + Required properties:
> + - compatible : "maxim,max77693-muic"
> +
> Example:
> #include <dt-bindings/leds/common.h>
>
> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index 662ae0d..1c05ea0 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -48,7 +48,10 @@ static const struct mfd_cell max77693_devs[] = {
> .name = "max77693-charger",
> .of_compatible = "maxim,max77693-charger",
> },
> - { .name = "max77693-muic", },
> + {
> + .name = "max77693-muic",
> + .of_compatible = "maxim,max77693-muic",
> + },
> {
> .name = "max77693-haptic",
> .of_compatible = "maxim,max77693-haptic",
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread