From: jeffy <jeffy.chen@rock-chips.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, tiwai@suse.de,
dolinux.peng@gmail.com, Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: Add a sanity check before using dai driver name
Date: Thu, 24 Aug 2017 18:44:40 +0800 [thread overview]
Message-ID: <599EAE18.2030401@rock-chips.com> (raw)
In-Reply-To: <20170824101826.htrevrhhgez2pgoe@sirena.org.uk>
hi Mark,
On 08/24/2017 06:18 PM, Mark Brown wrote:
> On Thu, Aug 24, 2017 at 11:29:42AM +0800, jeffy wrote:
>
>> and i was trying to do something like:
>> if (dlc->dai_name && strcmp(dai->name, dlc->dai_name)
>> && (!dai->driver->name || strcmp(dai->driver->name, dlc->dai_name)))
>> continue;
>
>> which is add an accept case for: dai driver name is valid and matches the
>> dai name we are looking for...
>
> Writing it as one if statement would at least be clearer. I can't
> remember the patch you proposed at this point but the above looks
> plausible.
right, i've already post a v3 for that ;)
>
prev parent reply other threads:[~2017-08-24 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 14:45 [PATCH] ASoC: Add a sanity check before using dai driver name Jeffy Chen
2017-08-22 16:17 ` Mark Brown
2017-08-22 23:42 ` jeffy
2017-08-23 11:06 ` Mark Brown
2017-08-24 3:29 ` jeffy
2017-08-24 10:18 ` Mark Brown
2017-08-24 10:44 ` jeffy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=599EAE18.2030401@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dolinux.peng@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox