From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754615AbdIFCmx (ORCPT ); Tue, 5 Sep 2017 22:42:53 -0400 Received: from regular1.263xmail.com ([211.150.99.133]:36529 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753867AbdIFCmt (ORCPT ); Tue, 5 Sep 2017 22:42:49 -0400 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: briannorris@chromium.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <44b40a4a53009004b1f0665aec60a4e2> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <59AF6091.5000204@rock-chips.com> Date: Wed, 06 Sep 2017 10:42:25 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Brian Norris CC: linux-kernel@vger.kernel.org, dgreid@chromium.org, heiko@sntech.de, mka@chromium.org, dianders@chromium.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Liam Girdwood , Mark Brown , Rob Herring , Mark Rutland Subject: Re: [PATCH v8 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi References: <20170905042500.25656-1-jeffy.chen@rock-chips.com> <20170905175532.GA9393@google.com> In-Reply-To: <20170905175532.GA9393@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Brian, On 09/06/2017 01:55 AM, Brian Norris wrote: >> +This device supports SPI only. >> >+ >> >+Required properties: >> >+ >> >+- compatible : "realtek,rt5514". > You list one string here, but there's 2 in the example. The point of > this exercise was to document (not just in an Example) the strings > you're using. Ok, will do. > >> >+ >> >+- reg : The SPI address of the device. >> >+ >> >+Optional properties: >> >+ >> >+- interrupt-parent: Should be the phandle for the interrupt controller >> >+- interrupts: The interrupt number to the cpu. The interrupt specifier format >> >+ depends on the interrupt controller. >> >+ >> >+Example: >> >+ >> >+codec: rt5514-spi@0 { >> >+ compatible = "realtek,rt5514", "realtek,rt5514-spi"; >> >+ reg = <0>; >> >+ >> >+ /* May run faster once verified. */ > Really? That was barely useful in the rk3399-gru DTSI, but it's > definitely not worth sticking in an example. > > Also, you switch between tabs and spaces for indentation. Please be > consistent. (And as with C code, I think the right answer is tabs?) Oops, thanks for noticing. > >> >+ spi-max-frequency = <10000000>; >> >+ >> >+ pinctrl-names = "default"; >> >+ pinctrl-0 = <&mic_int>; >> >+ >> >+ interrupt-parent = <&gpio1>; >> >+ interrupts = <13 IRQ_TYPE_LEVEL_HIGH>; >> >+ wakeup-source; >> >+}; >> >diff --git a/Documentation/devicetree/bindings/sound/rt5514.txt b/Documentation/devicetree/bindings/sound/rt5514.txt >> >index 929ca6756b02..12a8c93a67cc 100644 >> >--- a/Documentation/devicetree/bindings/sound/rt5514.txt >> >+++ b/Documentation/devicetree/bindings/sound/rt5514.txt >> >@@ -28,6 +28,6 @@ Pins on the device (for linking into audio routes) for RT5514: >> > Example: >> > >> > codec: rt5514@57 { >> >- compatible = "realtek,rt5514"; >> >+ compatible = "realtek,rt5514", "realtek,rt5514-i2c"; > Example != Documentation. Please document the string properly. Ok, will do. > > Brian >