From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751985AbdIKAnK (ORCPT ); Sun, 10 Sep 2017 20:43:10 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:40546 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751827AbdIKAnI (ORCPT ); Sun, 10 Sep 2017 20:43:08 -0400 X-AuditID: b6c32a48-f79a16d00000362a-94-59b5dc19f02f MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="utf-8" Message-id: <59B5DC19.4020805@samsung.com> Date: Mon, 11 Sep 2017 09:43:05 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Colin King , MyungJoo Ham Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] extcon: make extcon_info static const, fixes warning In-reply-to: <20170909165100.30701-1-colin.king@canonical.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLKsWRmVeSWpSXmKPExsWy7bCmma7kna2RBlPey1n8Xt3LZrH1lrTF 5V1z2CxuN65gc2DxmNXQy+bRt2UVo8fnTXIBzFGpNhmpiSmpRQqpecn5KZl56bZK3sHxzvGm ZgaGuoaWFuZKCnmJuam2Si4+AbpumTlAy5QUyhJzSoFCAYnFxUr6djZF+aUlqQoZ+cUltkrR hoZGeoYG5npGRkZ6JsaxVkamQCUJqRn7rx9iK9jPXrHg7RfGBsZfrF2MnBwSAiYSz57fYoOw xSQu3FsPZHNxCAnsYJRY/nY+I4TznVFi8YfL7F2MHGAdi/5bQsR3M0r0HJ/GAtLNKyAo8WPy PRaQGmYBeYkjl7JBwswCmhIvvkxigai/xyix8PIHVoh6LYl9k38zg9gsAqoST5smgMXZgOL7 X9wAu4hfQFHi6o/HjCC2qECExM7539hBbBGBEInTFyayQyxwlFg3/w7YDcICnhIH+v+A9XIK 2EnM3NwOtlhCYAmbxNoVm1ghHnCROHLRDuJjYYlXx7ewQ9jSEs9WbWSEqG9nlNg85x5Ucwej xP2VjdDwMpY41dXIBLGZT6Lj8F9oqPBKdLQJQZR4SBw/e5UZwnaU2HR+ItT3ExklFnUeYpvA KD8LKcBmIQJsFlKALWBkXsUollpQnJueWmxUYKJXnJhbXJqXrpecn7uJEZzUtDx2MB4453OI UYCDUYmHd8ekrZFCrIllxZW5hxglOJiVRHhfnAAK8aYkVlalFuXHF5XmpBYfYjQFhvdEZinR 5Hxgws0riTc0sTQwMTMzMjezACY2cd66bdcihATSE0tSs1NTC1KLYPqYODilGhg7vr4LCRF+ FTFb/UriAdf16z4ZhbZn3+01tjd7aiX8/fXEXeK2IUsnR11302Pv81qUxfE2d2dbrdlt9ZLU gG+rX1T+nBPjK/nIZU6N6/qLpwKKrJf+Of7k8aoTUdN2/ZOpPVmcEs3k/VJwWqbyHI11S59E aVuvmzJTOfxMYHSVYZV9zEkRXlklluKMREMt5qLiRAC3Crp3gAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrILMWRmVeSWpSXmKPExsVy+t9jAV3JO1sjDR7tEbD4vbqXzWLrLWmL y7vmsFncblzB5sDiMauhl82jb8sqRo/Pm+QCmKO4bFJSczLLUov07RK4MvZfP8RWsJ+9YsHb L4wNjL9Yuxg5OCQETCQW/bfsYuTiEBLYySjx9/4toDgnB6+AoMSPyfdYQGqYBeQljlzKhjDV JaZMyYUof8AosejHAmaIci2JfZN/g9ksAqoST5smgI1hA4rvf3GDDcTmF1CUuPrjMSPIHFGB CInuE5UgYRGBEIlZ0zcxgtjMAo4S6+bfYQGxhQU8JQ70/2GD2DWZUeLwoR6w+ZwCdhIzN7ez TGAUmIXk0lkIl85CuHQBI/MqRsnUguLc9NxiowKjvNRyveLE3OLSvHS95PzcTYzAgN12WKt/ B+PjJfGHGAU4GJV4eHdM2hopxJpYVlyZe4hRgoNZSYT3xQmgEG9KYmVValF+fFFpTmrxIUZp DhYlcd7MvhmRQgLpiSWp2ampBalFMFkmDk6pBkb1/v3GE6x+BN5sNYy6XdEw7x9j0NWyX1qx TU+5J/ydKBv+4INXlOX5HQq2vKeP7Jvx5ufVBdrn4phnHE0Imbl1af6q8wskH02d++6E9ZYw LxV35tXlnC+4Z/X93/0659gil77cPZIsmkKf7aI/bYxY3yqYqJukX7w79/j1QO6mJ4E+5+uE jeOUWIozEg21mIuKEwFqASdUVAIAAA== X-CMS-MailID: 20170911004305epcas2p2a53f9e3811df9982e031c565b592ddfd X-Msg-Generator: CA X-Sender-IP: 182.195.42.143 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170909165107epcas3p169935c5e37c5b21a9ffecf4cf01d5256 X-RootMTR: 20170909165107epcas3p169935c5e37c5b21a9ffecf4cf01d5256 References: <20170909165100.30701-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017년 09월 10일 01:51, Colin King wrote: > From: Colin Ian King > > The array extcon_info is read only, local to the source and does not > need to be in global scope, so make it static const. > > Cleans up sparse warning: > symbol 'extcon_info' was not declared. Should it be static? > > Signed-off-by: Colin Ian King > --- > drivers/extcon/extcon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c > index 35e9fb885486..cb38c2747684 100644 > --- a/drivers/extcon/extcon.c > +++ b/drivers/extcon/extcon.c > @@ -36,7 +36,7 @@ > > #define SUPPORTED_CABLE_MAX 32 > > -struct __extcon_info { > +static const struct __extcon_info { > unsigned int type; > unsigned int id; > const char *name; > Applied it for v4.15. Thanks. -- Best Regards, Chanwoo Choi Samsung Electronics