From: jeffy <jeffy.chen@rock-chips.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-kernel@vger.kernel.org, dgreid@chromium.org,
heiko@sntech.de, briannorris@chromium.org, mka@chromium.org,
dianders@chromium.org, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi
Date: Mon, 18 Sep 2017 09:22:21 +0800 [thread overview]
Message-ID: <59BF1FCD.3060501@rock-chips.com> (raw)
In-Reply-To: <20170913172452.rqy2umufkuh26fzj@rob-hp-laptop>
Hi Rob,
Thanks for your reply.
On 09/14/2017 01:24 AM, Rob Herring wrote:
> On Wed, Sep 06, 2017 at 10:50:09AM +0800, Jeffy Chen wrote:
>> diff --git a/Documentation/devicetree/bindings/sound/rt5514.txt b/Documentation/devicetree/bindings/sound/rt5514.txt
>> index 929ca6756b02..841a1159e234 100644
>> --- a/Documentation/devicetree/bindings/sound/rt5514.txt
>> +++ b/Documentation/devicetree/bindings/sound/rt5514.txt
>> @@ -4,7 +4,7 @@ This device supports I2C only.
>
> SPI support should be added to this document.
ok, will do.
>
>>
>> Required properties:
>>
>> -- compatible : "realtek,rt5514".
>> +- compatible : "realtek,rt5514" or "realtek,rt5514", "realtek,rt5514-i2c".
>
> There's no need for the -spi or -i2c compatibles. This is implied by
> being a child of those controllers.
heiko mentioned i should add it in the binding in:
https://patchwork.kernel.org/patch/9918987/
next prev parent reply other threads:[~2017-09-18 1:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 2:50 [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi Jeffy Chen
2017-09-06 2:50 ` [RESENT PATCH v9 2/2] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru Jeffy Chen
2017-09-13 17:24 ` [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi Rob Herring
2017-09-18 1:22 ` jeffy [this message]
2017-09-18 9:30 ` Heiko Stuebner
2017-09-18 11:20 ` jeffy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59BF1FCD.3060501@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=alsa-devel@alsa-project.org \
--cc=briannorris@chromium.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dgreid@chromium.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox