From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751616AbdIRBWg (ORCPT ); Sun, 17 Sep 2017 21:22:36 -0400 Received: from regular1.263xmail.com ([211.150.99.136]:56147 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751271AbdIRBWe (ORCPT ); Sun, 17 Sep 2017 21:22:34 -0400 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: robh@kernel.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <59BF1FCD.3060501@rock-chips.com> Date: Mon, 18 Sep 2017 09:22:21 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Rob Herring CC: linux-kernel@vger.kernel.org, dgreid@chromium.org, heiko@sntech.de, briannorris@chromium.org, mka@chromium.org, dianders@chromium.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Liam Girdwood , Mark Brown , Mark Rutland Subject: Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi References: <20170906025010.10750-1-jeffy.chen@rock-chips.com> <20170913172452.rqy2umufkuh26fzj@rob-hp-laptop> In-Reply-To: <20170913172452.rqy2umufkuh26fzj@rob-hp-laptop> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Thanks for your reply. On 09/14/2017 01:24 AM, Rob Herring wrote: > On Wed, Sep 06, 2017 at 10:50:09AM +0800, Jeffy Chen wrote: >> diff --git a/Documentation/devicetree/bindings/sound/rt5514.txt b/Documentation/devicetree/bindings/sound/rt5514.txt >> index 929ca6756b02..841a1159e234 100644 >> --- a/Documentation/devicetree/bindings/sound/rt5514.txt >> +++ b/Documentation/devicetree/bindings/sound/rt5514.txt >> @@ -4,7 +4,7 @@ This device supports I2C only. > > SPI support should be added to this document. ok, will do. > >> >> Required properties: >> >> -- compatible : "realtek,rt5514". >> +- compatible : "realtek,rt5514" or "realtek,rt5514", "realtek,rt5514-i2c". > > There's no need for the -spi or -i2c compatibles. This is implied by > being a child of those controllers. heiko mentioned i should add it in the binding in: https://patchwork.kernel.org/patch/9918987/