From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754662AbdIRLUV (ORCPT ); Mon, 18 Sep 2017 07:20:21 -0400 Received: from regular1.263xmail.com ([211.150.99.130]:46559 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753139AbdIRLUT (ORCPT ); Mon, 18 Sep 2017 07:20:19 -0400 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: heiko@sntech.de X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <59BFABE7.5050904@rock-chips.com> Date: Mon, 18 Sep 2017 19:20:07 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Heiko Stuebner CC: Rob Herring , linux-kernel@vger.kernel.org, dgreid@chromium.org, briannorris@chromium.org, mka@chromium.org, dianders@chromium.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Liam Girdwood , Mark Brown , Mark Rutland Subject: Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi References: <20170906025010.10750-1-jeffy.chen@rock-chips.com> <20170913172452.rqy2umufkuh26fzj@rob-hp-laptop> <59BF1FCD.3060501@rock-chips.com> <1972340.u0BEiYTrvM@phil> In-Reply-To: <1972340.u0BEiYTrvM@phil> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, Thanks for your reply. On 09/18/2017 05:30 PM, Heiko Stuebner wrote: >>>> > >> >>>> > >>-- compatible : "realtek,rt5514". >>>> > >>+- compatible : "realtek,rt5514" or "realtek,rt5514", "realtek,rt5514-i2c". >>> > > >>> > >There's no need for the -spi or -i2c compatibles. This is implied by >>> > >being a child of those controllers. >> >heiko mentioned i should add it in the binding in: >> >https://patchwork.kernel.org/patch/9918987/ > If you add a new compatible you need to add it to the binding. I think what > Rob means is, that both the i2c and spi side can have the_same_ > compatible without the -i2c or -spi, as you can check wether they are > children of either a spi or i2c controller in the code itself. > ok, got it. i sent a new patch to check the bus_type instead :)