From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751336AbdISDQq (ORCPT ); Mon, 18 Sep 2017 23:16:46 -0400 Received: from regular1.263xmail.com ([211.150.99.135]:53785 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbdISDQp (ORCPT ); Mon, 18 Sep 2017 23:16:45 -0400 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: mka@chromium.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <27325f5c0f0d4ee2e6a44a3c9b649284> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <59C08C10.7030806@rock-chips.com> Date: Tue, 19 Sep 2017 11:16:32 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Matthias Kaehlcke CC: linux-kernel@vger.kernel.org, dgreid@chromium.org, heiko@sntech.de, briannorris@chromium.org, broonie@kernel.org, dianders@chromium.org, Jaroslav Kysela , alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org, Takashi Iwai , Liam Girdwood , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v11 2/2] ASoC: rockchip: Use bus_type to distinguish rt5514 dsp from rt5514 codec References: <20170918111435.11411-1-jeffy.chen@rock-chips.com> <20170918111435.11411-2-jeffy.chen@rock-chips.com> <20170918191524.GI173745@google.com> In-Reply-To: <20170918191524.GI173745@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthias, On 09/19/2017 03:15 AM, Matthias Kaehlcke wrote: >> >+static int of_dev_node_match(struct device *dev, void *data) >> >+{ >> >+ return dev->of_node == data; >> >+} > The same is done in different places, even with the same function name > (drivers/i2c/i2c-core-of.c, drivers/mux/mux-core.c, ...), which > suggests that we might want to have this function in > right, we are dupping this for bus_find_device in: ./arch/powerpc/platforms/pseries/ibmebus.c ./drivers/gpu/drm/drm_mipi_dsi.c ./drivers/hwtracing/coresight/of_coresight.c ./drivers/of/of_mdio.c ./drivers/of/platform.c ./drivers/i2c/i2c-core-of.c ./drivers/nvmem/core.c and for class_find_device in: ./drivers/spi/spi.c ./drivers/fpga/fpga-mgr.c ./drivers/fpga/fpga-region.c ./drivers/fpga/fpga-bridge.c ./drivers/regulator/core.c ./drivers/mux/core.c ./drivers/net/phy/mdio_bus.c and for component_match_add in: ./drivers/iommu/mtk_iommu.c (and a lot of drm drivers)