From: Chanwoo Choi <cw00.choi@samsung.com>
To: Linus Walleij <linus.walleij@linaro.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
John Stultz <john.stultz@linaro.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 2/8] extcon: gpio: Localize platform data
Date: Tue, 26 Sep 2017 11:04:02 +0900 [thread overview]
Message-ID: <59C9B592.5030209@samsung.com> (raw)
In-Reply-To: <20170924145622.4031-3-linus.walleij@linaro.org>
Hi Linus,
On 2017년 09월 24일 23:56, Linus Walleij wrote:
> Nothing in the entire kernel #includes <linux/extcon/extcon-gpio.h>
> so move the platform data declaration inside of the driver.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/extcon/extcon-gpio.c | 22 +++++++++++++++++-
> include/linux/extcon/extcon-gpio.h | 47 --------------------------------------
> 2 files changed, 21 insertions(+), 48 deletions(-)
> delete mode 100644 include/linux/extcon/extcon-gpio.h
>
> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c
> index ebed22f22d75..6abf5f70fdbf 100644
> --- a/drivers/extcon/extcon-gpio.c
> +++ b/drivers/extcon/extcon-gpio.c
> @@ -18,7 +18,6 @@
Actually, extcon-gpio.h defines the 'struct gpio_extcon_pdata'
in order to get the gpio and interrupt data from platform_data
before device-tree binding method. But, as you mentioned,
it is not used on kernel with platform_data method.
Looks good to me.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
[snip]
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2017-09-26 2:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 14:56 [PATCH 0/8] GPIO extcon modernization Linus Walleij
2017-09-24 14:56 ` [PATCH 1/8] extcon: gpio: Add DT bindings Linus Walleij
2017-09-24 19:56 ` Rob Herring
2017-09-26 0:39 ` Linus Walleij
2017-09-26 2:02 ` Chanwoo Choi
2017-10-19 10:47 ` Chanwoo Choi
2017-09-24 14:56 ` [PATCH 2/8] extcon: gpio: Localize platform data Linus Walleij
2017-09-26 2:04 ` Chanwoo Choi [this message]
2017-09-24 14:56 ` [PATCH 3/8] extcon: gpio: Move platform data into state container Linus Walleij
2017-09-26 2:04 ` Chanwoo Choi
2017-09-24 14:56 ` [PATCH 4/8] extcon: gpio: Convert to fully use GPIO descriptor Linus Walleij
2017-09-26 2:18 ` Chanwoo Choi
2017-09-24 14:56 ` [PATCH 5/8] extcon: gpio: Request reasonable interrupts Linus Walleij
2017-09-26 2:19 ` Chanwoo Choi
2017-09-24 14:56 ` [PATCH 6/8] extcon: gpio: Get debounce setting from device property Linus Walleij
2017-09-26 2:23 ` Chanwoo Choi
2017-09-24 14:56 ` [PATCH 7/8] extcon: gpio: Get connector type " Linus Walleij
2017-09-24 14:56 ` [PATCH 8/8] extcon: gpio: Always check state on resume Linus Walleij
2017-09-26 2:25 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59C9B592.5030209@samsung.com \
--to=cw00.choi@samsung.com \
--cc=john.stultz@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox