From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967117AbdIZCEI (ORCPT ); Mon, 25 Sep 2017 22:04:08 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:52345 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967106AbdIZCED (ORCPT ); Mon, 25 Sep 2017 22:04:03 -0400 X-AuditID: b6c32a39-a6fff7000000109f-4c-59c9b5917309 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <59C9B592.5030209@samsung.com> Date: Tue, 26 Sep 2017 11:04:02 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Linus Walleij , MyungJoo Ham Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, John Stultz , Guenter Roeck Subject: Re: [PATCH 2/8] extcon: gpio: Localize platform data In-reply-to: <20170924145622.4031-3-linus.walleij@linaro.org> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrIKsWRmVeSWpSXmKPExsWy7bCmvu7ErScjDdbvkLU481vXYsqf5UwW m+f/YbS4vGsOm8WThWeYLG43rmBzYPO4c20Pm8fO7w3sHn1bVjF6fN4kF8ASlWqTkZqYklqk kJqXnJ+SmZduq+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA7RbSaEsMacUKBSQWFys pG9nU5RfWpKqkJFfXGKrFG1oaKRnaGCuZ2RkpGdiHGtlZApUkpCa0XZsAWvBM46K5v03WRoY N7B3MXJySAiYSGy4cIixi5GLQ0hgB6PE6vkzWSGc74wSPfPmwVWtvtHLApHYwCgxZ/5isASv gKDEj8n3gBIcHMwC8hJHLmWDhJkFNCW27l7PDlF/j1Fi29nPTBD1WhJHp8xgAbFZBFQlPt74 BxZnA4rvf3GDDcTmF1CUuPrjMSOILSoQIbFz/jewXSIC4RL7jh1gBhnKLNDBKPFmB0RCWMBW 4t2O+0wgR3AC2S3/rUBqJAT2sEk8v3uEFeIDF4kvS45DfSMs8er4FnaQegkBaYlLR20h6tsZ JTbPuccC4QAtuL+yEarZWOJUVyMTxGt8Eu++9rBCNPNKdLQJQZR4SLw49wFqvqPEl52T2SC+ P8wo8aX3A9MERrlZSAE2CxFgs5ACbAEj8ypGsdSC4tz01GLDAlO94sTc4tK8dL3k/NxNjODk pmW5g/HYOZ9DjAIcjEo8vA1MJyOFWBPLiitzDzFKcDArifDKbwYK8aYkVlalFuXHF5XmpBYf YjQFhvdEZinR5Hxg4s0riTc0sTQwMTMCpi9LQ0MlcV7R9dcihATSE0tSs1NTC1KLYPqYODil GhhtH7VM3yCierX2d4G+4/prs/YmKip170nTT9N/eyqfKX6lFNfl45e+zHqwP4xxqVPSZ+6T 9amnsqe+ypi+3a8uy2zr/Ueb1nZMrlvXVCisnrtlvalHueeDpQqBpXvSpk5vLp8pKf289L38 5Ha/sjm1K/6vabhbIl4fvqPtr87myTLH1//5XeqmxFKckWioxVxUnAgArkM644QDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrELMWRmVeSWpSXmKPExsVy+t9jQd2JW09GGtybyWxx5reuxZQ/y5ks Ns//w2hxedccNosnC88wWdxuXMHmwOZx59oeNo+d3xvYPfq2rGL0+LxJLoAlissmJTUnsyy1 SN8ugSuj7dgC1oJnHBXN+2+yNDBuYO9i5OSQEDCRWH2jl6WLkYtDSGAdo8SaBZvAErwCghI/ Jt8DSnBwMAvISxy5lA0SZhZQl5g0bxEzRP0DRomtM24xQ9RrSRydMoMFxGYRUJX4eOMfE4jN BhTf/+IGG4jNL6AocfXHY0aQmaICERLdJypBwiIC4RKzF7xnhpjfwSgxebMmiC0sYCvxbsd9 Johdhxklnky6xg7SywmUaPlvNYFRYBaSS2chXDoLyaULGJlXMUqmFhTnpucWGxUY5qWW6xUn 5haX5qXrJefnbmIEhvS2w1p9OxjvL4k/xCjAwajEw9vAdDJSiDWxrLgy9xCjBAezkgiv/Gag EG9KYmVValF+fFFpTmrxIUZpDhYlcd7beccihQTSE0tSs1NTC1KLYLJMHJxSDYx8rw7K/hFe 4rr63bVdPlFz3M5O2awRdi5KwfRTr9FR595/1mF6Vqlvrlw6oBe75X1ay/xXnDLHZ4mpCLyO bFfed3cZj82OgyafghnuV6wzts7OXPeukn+2u66B5NQHMjmN0yW/uq/b+mqvddLNIw/6Io3m XZXhLChOOO3p7vP7H9+KzI0Sz1cqsRRnJBpqMRcVJwIAq6A3zWUCAAA= X-CMS-MailID: 20170926020401epcas1p44cfc91a3a699ed34bc4480bb8be29371 X-Msg-Generator: CA X-Sender-IP: 182.195.42.142 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170924145853epcas4p38c33944036eb5a07285eae475fb204a6 X-RootMTR: 20170924145853epcas4p38c33944036eb5a07285eae475fb204a6 References: <20170924145622.4031-1-linus.walleij@linaro.org> <20170924145622.4031-3-linus.walleij@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, On 2017년 09월 24일 23:56, Linus Walleij wrote: > Nothing in the entire kernel #includes > so move the platform data declaration inside of the driver. > > Signed-off-by: Linus Walleij > --- > drivers/extcon/extcon-gpio.c | 22 +++++++++++++++++- > include/linux/extcon/extcon-gpio.h | 47 -------------------------------------- > 2 files changed, 21 insertions(+), 48 deletions(-) > delete mode 100644 include/linux/extcon/extcon-gpio.h > > diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c > index ebed22f22d75..6abf5f70fdbf 100644 > --- a/drivers/extcon/extcon-gpio.c > +++ b/drivers/extcon/extcon-gpio.c > @@ -18,7 +18,6 @@ Actually, extcon-gpio.h defines the 'struct gpio_extcon_pdata' in order to get the gpio and interrupt data from platform_data before device-tree binding method. But, as you mentioned, it is not used on kernel with platform_data method. Looks good to me. Acked-by: Chanwoo Choi [snip] -- Best Regards, Chanwoo Choi Samsung Electronics