From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967169AbdIZCFC (ORCPT ); Mon, 25 Sep 2017 22:05:02 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:62671 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965981AbdIZCE6 (ORCPT ); Mon, 25 Sep 2017 22:04:58 -0400 X-AuditID: b6c32a35-8adff70000001157-23-59c9b5c7db95 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <59C9B5C9.6060701@samsung.com> Date: Tue, 26 Sep 2017 11:04:57 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Linus Walleij , MyungJoo Ham Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, John Stultz , Guenter Roeck Subject: Re: [PATCH 3/8] extcon: gpio: Move platform data into state container In-reply-to: <20170924145622.4031-4-linus.walleij@linaro.org> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrIKsWRmVeSWpSXmKPExsWy7bCmge7xrScjDd69tLA481vXYsqf5UwW m+f/YbS4vGsOm8WThWeYLG43rmBzYPO4c20Pm8fO7w3sHn1bVjF6fN4kF8ASlWqTkZqYklqk kJqXnJ+SmZduq+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA7RbSaEsMacUKBSQWFys pG9nU5RfWpKqkJFfXGKrFG1oaKRnaGCuZ2RkpGdiHGtlZApUkpCasez7XcaCi9oVz16uYWlg fK7UxcjJISFgInHl7Se2LkYuDiGBHYwSB4/sYIZwvjNKzL3ymAmm6tG9s1BVuxklfm3/xA6S 4BUQlPgx+R5LFyMHB7OAvMSRS9kgYWYBTYmtu9ezQ9TfY5To27qMDaJeS+L1vO/sIPUsAqoS PW2VIGE2oPD+FzfASvgFFCWu/njMCGKLCkRI7Jz/DWyViEC4xL5jB8COYxboYJR4swMiISwQ ILH25ntmEJtTwFbi4f8JYIdKCOxhk9g7eQkrxAcuEv/OTGeGsIUlXh3fAnaEhIC0xKWjthD1 7YwSm+eAPAPiAG24v7IRqtlY4lRXIxPEa3wS7772sEI080p0tAlBlHhIzFuyE6rcUeJe/2kW iO8PM0pMnjSZfQKj3CykAJuFCLBZSAG2gJF5FaNYakFxbnpqsWGBoV5xYm5xaV66XnJ+7iZG cHLTMt3BOOWczyFGAQ5GJR7eBqaTkUKsiWXFlbmHGCU4mJVEeOU3A4V4UxIrq1KL8uOLSnNS iw8xmgLDeyKzlGhyPjDx5pXEG5pYGpiYGQHTl6WhoZI4r+j6axFCAumJJanZqakFqUUwfUwc nFINjDOn//J8mTZ98nET/8/Kyyz2Z52vk/la2fb40Q3Gp0HK009d83e7w2iUf0JbKd14/sHw 1bu6v+xw1a6PvWT2XiD+wqGcxIefb/Iarv61NLfH7e3Oh2fSi9Kei2txnlp52W+h1NSa+Xt2 f1xruO7d6Vz/KTcS14S/C91i+vaFsuPVI09uWCn/5n6jxFKckWioxVxUnAgAs9stv4QDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrILMWRmVeSWpSXmKPExsVy+t9jAd3jW09GGkxtULc481vXYsqf5UwW m+f/YbS4vGsOm8WThWeYLG43rmBzYPO4c20Pm8fO7w3sHn1bVjF6fN4kF8ASxWWTkpqTWZZa pG+XwJWx7PtdxoKL2hXPXq5haWB8rtTFyMkhIWAi8ejeWbYuRi4OIYGdjBKfV3xjB0nwCghK /Jh8j6WLkYODWUBe4silbJAws4C6xKR5i5hBbCGBB4wSKy7oQZRrSbye950dpJxFQFWip60S JMwGFN7/4gYbiM0voChx9cdjRpASUYEIie4TYCUiAuESsxe8Z4aY3sEoMXmzJogtLOAnsWLm ISaIyw4zSvS0fGYESXAK2Eo8/D+BbQKjwCwkh85COHQWkkMXMDKvYpRMLSjOTc8tNiowzEst 1ytOzC0uzUvXS87P3cQIDOhth7X6djDeXxJ/iFGAg1GJh7eB6WSkEGtiWXFl7iFGCQ5mJRFe +c1AId6UxMqq1KL8+KLSnNTiQ4zSHCxK4ry3845FCgmkJ5akZqemFqQWwWSZODilGhglfROu G9ywnlNaXJyyb92GdANfibkOU7pUa3n8y7c5hXky13s13nw+dcGBEK1l5zv1/fM/vTBawLm/ TdaPP+b0u8se8dtrUw1DfY5ttszQeXOOI9Ylaw+vt64fL9vR4xN2O+9r9dQOf2F0RLYloXT5 o+U7hQ+mSP7JK+4r723yWRU30f1HohJLcUaioRZzUXEiAA4ol7dkAgAA X-CMS-MailID: 20170926020455epcas1p18146a661a66b3c06dc6b80f412124dde X-Msg-Generator: CA X-Sender-IP: 182.195.42.142 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170924145924epcas5p40b56107b697683bef6e1b8099301f2cc X-RootMTR: 20170924145924epcas5p40b56107b697683bef6e1b8099301f2cc References: <20170924145622.4031-1-linus.walleij@linaro.org> <20170924145622.4031-4-linus.walleij@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, On 2017년 09월 24일 23:56, Linus Walleij wrote: > This moves the platform data settings from the platform data > struct and into the state container, saving some unnecessary > references and simplifying things a bit. > > Signed-off-by: Linus Walleij > --- > drivers/extcon/extcon-gpio.c | 56 ++++++++++++++++++++------------------------ > 1 file changed, 26 insertions(+), 30 deletions(-) Looks good to me. Acked-by: Chanwoo Choi > > diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c > index 6abf5f70fdbf..9c4094edd123 100644 > --- a/drivers/extcon/extcon-gpio.c > +++ b/drivers/extcon/extcon-gpio.c > @@ -29,7 +29,13 @@ > #include > > /** > - * struct gpio_extcon_pdata - A simple GPIO-controlled extcon device. > + * struct gpio_extcon_data - A simple GPIO-controlled extcon device state container. > + * @edev: Extcon device. > + * @irq: Interrupt line for the external connector. > + * @work: Work fired by the interrupt. > + * @debounce_jiffies: Number of jiffies to wait for the GPIO to stabilize, from the debounce > + * value. > + * @id_gpiod: GPIO descriptor for this external connector. > * @extcon_id: The unique id of specific external connector. > * @gpio: Corresponding GPIO. > * @gpio_active_low: Boolean describing whether gpio active state is 1 or 0 > @@ -40,23 +46,18 @@ > * @check_on_resume: Boolean describing whether to check the state of gpio > * while resuming from sleep. > */ > -struct gpio_extcon_pdata { > - unsigned int extcon_id; > - unsigned gpio; > - bool gpio_active_low; > - unsigned long debounce; > - unsigned long irq_flags; > - bool check_on_resume; > -}; > - > struct gpio_extcon_data { > struct extcon_dev *edev; > int irq; > struct delayed_work work; > unsigned long debounce_jiffies; > - > struct gpio_desc *id_gpiod; > - struct gpio_extcon_pdata *pdata; > + unsigned int extcon_id; > + unsigned gpio; > + bool gpio_active_low; > + unsigned long debounce; > + unsigned long irq_flags; > + bool check_on_resume; > }; > > static void gpio_extcon_work(struct work_struct *work) > @@ -67,10 +68,10 @@ static void gpio_extcon_work(struct work_struct *work) > work); > > state = gpiod_get_value_cansleep(data->id_gpiod); > - if (data->pdata->gpio_active_low) > + if (data->gpio_active_low) > state = !state; > > - extcon_set_state_sync(data->edev, data->pdata->extcon_id, state); > + extcon_set_state_sync(data->edev, data->extcon_id, state); > } > > static irqreturn_t gpio_irq_handler(int irq, void *dev_id) > @@ -84,24 +85,23 @@ static irqreturn_t gpio_irq_handler(int irq, void *dev_id) > > static int gpio_extcon_init(struct device *dev, struct gpio_extcon_data *data) > { > - struct gpio_extcon_pdata *pdata = data->pdata; > int ret; > > - ret = devm_gpio_request_one(dev, pdata->gpio, GPIOF_DIR_IN, > + ret = devm_gpio_request_one(dev, data->gpio, GPIOF_DIR_IN, > dev_name(dev)); > if (ret < 0) > return ret; > > - data->id_gpiod = gpio_to_desc(pdata->gpio); > + data->id_gpiod = gpio_to_desc(data->gpio); > if (!data->id_gpiod) > return -EINVAL; > > - if (pdata->debounce) { > + if (data->debounce) { > ret = gpiod_set_debounce(data->id_gpiod, > - pdata->debounce * 1000); > + data->debounce * 1000); > if (ret < 0) > data->debounce_jiffies = > - msecs_to_jiffies(pdata->debounce); > + msecs_to_jiffies(data->debounce); > } > > data->irq = gpiod_to_irq(data->id_gpiod); > @@ -113,20 +113,16 @@ static int gpio_extcon_init(struct device *dev, struct gpio_extcon_data *data) > > static int gpio_extcon_probe(struct platform_device *pdev) > { > - struct gpio_extcon_pdata *pdata = dev_get_platdata(&pdev->dev); > struct gpio_extcon_data *data; > int ret; > > - if (!pdata) > - return -EBUSY; > - if (!pdata->irq_flags || pdata->extcon_id > EXTCON_NONE) > - return -EINVAL; > - > data = devm_kzalloc(&pdev->dev, sizeof(struct gpio_extcon_data), > GFP_KERNEL); > if (!data) > return -ENOMEM; > - data->pdata = pdata; > + > + if (!data->irq_flags || data->extcon_id > EXTCON_NONE) > + return -EINVAL; > > /* Initialize the gpio */ > ret = gpio_extcon_init(&pdev->dev, data); > @@ -134,7 +130,7 @@ static int gpio_extcon_probe(struct platform_device *pdev) > return ret; > > /* Allocate the memory of extcon devie and register extcon device */ > - data->edev = devm_extcon_dev_allocate(&pdev->dev, &pdata->extcon_id); > + data->edev = devm_extcon_dev_allocate(&pdev->dev, &data->extcon_id); > if (IS_ERR(data->edev)) { > dev_err(&pdev->dev, "failed to allocate extcon device\n"); > return -ENOMEM; > @@ -151,7 +147,7 @@ static int gpio_extcon_probe(struct platform_device *pdev) > * is attached or detached. > */ > ret = devm_request_any_context_irq(&pdev->dev, data->irq, > - gpio_irq_handler, pdata->irq_flags, > + gpio_irq_handler, data->irq_flags, > pdev->name, data); > if (ret < 0) > return ret; > @@ -178,7 +174,7 @@ static int gpio_extcon_resume(struct device *dev) > struct gpio_extcon_data *data; > > data = dev_get_drvdata(dev); > - if (data->pdata->check_on_resume) > + if (data->check_on_resume) > queue_delayed_work(system_power_efficient_wq, > &data->work, data->debounce_jiffies); > > -- Best Regards, Chanwoo Choi Samsung Electronics