From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967189AbdIZCZt (ORCPT ); Mon, 25 Sep 2017 22:25:49 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:64684 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965067AbdIZCZq (ORCPT ); Mon, 25 Sep 2017 22:25:46 -0400 X-AuditID: b6c32a48-c0fff70000001005-9a-59c9baa85ca8 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <59C9BAA8.5040906@samsung.com> Date: Tue, 26 Sep 2017 11:25:44 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Linus Walleij , MyungJoo Ham Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, John Stultz , Guenter Roeck Subject: Re: [PATCH 8/8] extcon: gpio: Always check state on resume In-reply-to: <20170924145622.4031-9-linus.walleij@linaro.org> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrEKsWRmVeSWpSXmKPExsWy7bCmqe6KXScjDZauY7E481vXYsqf5UwW m+f/YbS4vGsOm8WThWeYLG43rmBzYPO4c20Pm8fO7w3sHn1bVjF6fN4kF8ASlWqTkZqYklqk kJqXnJ+SmZduq+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA7RbSaEsMacUKBSQWFys pG9nU5RfWpKqkJFfXGKrFG1oaKRnaGCuZ2RkpGdiHGtlZApUkpCasePdZpaC/5wVb5tusjUw /mLvYuTkkBAwkbiz9zJTFyMXh5DADkaJPfdXsEE43xklDi2bzQZTdeDKUSYQW0hgA6PEjf3h IDavgKDEj8n3WLoYOTiYBeQljlzKBgkzC2hKbN29nh1izj1GiSfrPzJC1GtJvHz+EWwOi4Cq xOYnJ8BsNqD4/hc3wHbxCyhKXP3xGKxeVCBCYuf8b2CXigiES+w7doAZZCizQAejxJsdEAlh AWeJ7vsbwZo5BWwlrqz4zApSJCFwgE3i3/SDUH+6SDw7do4RwhaWeHV8C1RcWuLZqo2MEA3t jBKb54C8A+IArbi/spEVospY4lRXIxPEc3wSHYf/soP8LCHAK9HRJgRR4iFx9yzEaxICjhKz p+1jhvj/MKPEv6P/WScwys1CCrJZiCCbhRRkCxiZVzGKpRYU56anFhsVmOgVJ+YWl+al6yXn 525iBKc3LY8djAfO+RxiFOBgVOLhbWA6GSnEmlhWXJl7iFGCg1lJhPf6dqAQb0piZVVqUX58 UWlOavEhRlNgiE9klhJNzgem3rySeEMTSwMTMzMjczMLYBIT563bdi1CSCA9sSQ1OzW1ILUI po+Jg1OqgfGk3eF3Mft/BDVfybfnU1I4EW39gt1tp7lJ/f7dAU8F/ZbumltZtCH89/nqq4rv zvDOVOjRDAn1EmreI//y46mfiof2vK1I0HwbqC/OECjmvmd1C1Ph+YS/2x5sPmLByTfP44XQ hszPW+drP17bEfZZ5R1/Em/9axtp9uvFK7JXGMSt/f3/pKISS3FGoqEWc1FxIgD9nqkXhQMA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrELMWRmVeSWpSXmKPExsVy+t9jQd3lu05GGsw/zW1x5reuxZQ/y5ks Ns//w2hxedccNosnC88wWdxuXMHmwOZx59oeNo+d3xvYPfq2rGL0+LxJLoAlissmJTUnsyy1 SN8ugStjx7vNLAX/OSveNt1ka2D8xd7FyMkhIWAiceDKUaYuRi4OIYF1jBLreh6zgiR4BQQl fky+x9LFyMHBLCAvceRSNkiYWUBdYtK8RcwQ9Q8YJba8vc8OUa8l8fL5RyYQm0VAVWLzkxNg NhtQfP+LG2wgNr+AosTVH48ZQWaKCkRIdJ+oBAmLCIRLzF7wnhlifgejxOTNmiC2sICzRPf9 jWCtQgKHGSW6zqiB2JwCthJXVnxmncAoMAvJpbMQLp2F5NIFjMyrGCVTC4pz03OLjQqM8lLL 9YoTc4tL89L1kvNzNzECQ3rbYa3+HYyPl8QfYhTgYFTi4b3BcjJSiDWxrLgy9xCjBAezkgjv 9e1AId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rz8+ccihQTSE0tSs1NTC1KLYLJMHJxSDYzGorki Fr+vv359ccWzOserhzor1toE/Wo7wMWVsXDrmqoMDRHvyRr/dCK5n9vLfpqiOk3uXIBr9ty1 X0VYW6e3X/35zyXmtnfh7fhGUb7D0Z6R0wJ817ZJH7M9+XXuvRs2gqXie55Pd/YVr8pmupOX LKR6mGNqV4Fi7DGxM89VBcvS96RdvafEUpyRaKjFXFScCABNTXwfZQIAAA== X-CMS-MailID: 20170926022543epcas2p1615a41fe2b4ceb37bb15b6d8716cbc1f X-Msg-Generator: CA X-Sender-IP: 182.195.42.143 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170924150247epcas2p337f9a12744c23967dbdc0c79042553b5 X-RootMTR: 20170924150247epcas2p337f9a12744c23967dbdc0c79042553b5 References: <20170924145622.4031-1-linus.walleij@linaro.org> <20170924145622.4031-9-linus.walleij@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, On 2017년 09월 24일 23:56, Linus Walleij wrote: > It makes most sense to always check the state of the GPIO external > connector at system resume so just do this by default. Add a TODO > if people turn out to desire to parameterize this. > > Signed-off-by: Linus Walleij > --- > drivers/extcon/extcon-gpio.c | 9 +++++++++ > 1 file changed, 9 insertions(+) Looks good to me. Acked-by: Chanwoo Choi > > diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c > index b7353f5018b5..4f0ad5ad2722 100644 > --- a/drivers/extcon/extcon-gpio.c > +++ b/drivers/extcon/extcon-gpio.c > @@ -83,6 +83,15 @@ static int gpio_extcon_probe(struct platform_device *pdev) > if (!data) > return -ENOMEM; > > + /* > + * Always checking connector state on resume makes most sense so do this > + * by default. > + * > + * TODO: if parameterization is needed, augment this to use proper device > + * properties or set it up from PM core. > + */ > + data->check_on_resume = true; > + > data->gpiod = devm_gpiod_get(dev, "extcon", GPIOD_IN); > if (IS_ERR(data->gpiod)) > return PTR_ERR(data->gpiod); > -- Best Regards, Chanwoo Choi Samsung Electronics