From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752874AbdI1L4x (ORCPT ); Thu, 28 Sep 2017 07:56:53 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:7464 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752814AbdI1L4w (ORCPT ); Thu, 28 Sep 2017 07:56:52 -0400 Subject: Re: [PATCH for-next 8/9] RDMA/hns: Remove unused struct members in hns-abi.h To: Leon Romanovsky References: <1506574654-56699-1-git-send-email-xavier.huwei@huawei.com> <1506574654-56699-9-git-send-email-xavier.huwei@huawei.com> <20170928090203.GS2297@mtr-leonro.local> CC: , , , , , , , , , , , From: "Wei Hu (Xavier)" Message-ID: <59CCE378.6070209@huawei.com> Date: Thu, 28 Sep 2017 19:56:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20170928090203.GS2297@mtr-leonro.local> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.57.115.182] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A010206.59CCE381.0071,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 0c6007f43158a937428e0a94b734ce3a Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/9/28 17:02, Leon Romanovsky wrote: > On Thu, Sep 28, 2017 at 12:57:33PM +0800, Wei Hu (Xavier) wrote: >> From: Lijun Ou >> >> This patch mainly deletes some unused struct members for >> hns_roce_ib_create_qp in order to match libhns, because >> the num of struct members of hns_roce_ib_create_qp must >> be the same with hns_roce_create_qp in libhns. >> >> Signed-off-by: Lijun Ou >> Signed-off-by: Wei Hu (Xavier) >> Signed-off-by: Shaobo Xu >> --- >> include/uapi/rdma/hns-abi.h | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/include/uapi/rdma/hns-abi.h b/include/uapi/rdma/hns-abi.h >> index 5d74019..79251b6 100644 >> --- a/include/uapi/rdma/hns-abi.h >> +++ b/include/uapi/rdma/hns-abi.h >> @@ -41,10 +41,8 @@ struct hns_roce_ib_create_cq { >> >> struct hns_roce_ib_create_qp { >> __u64 buf_addr; >> - __u64 db_addr; >> __u8 log_sq_bb_count; >> __u8 log_sq_stride; >> - __u8 sq_no_prefetch; >> __u8 reserved[5]; >> }; > It is classical UAPI breakage which kernel tries to avoid. > > In RDMA, we do allow rename of fields from reserved to something, but > don't allow binary layout change. > > NAK to this change. > > Thanks Hi, Leon Now there is an inconsistency between hns_roce_ib_create_qp in kernel driver and hns_roce_create_qp in libhns as below: struct hns_roce_create_qp { struct ibv_create_qp ibv_cmd; __u64 buf_addr; __u8 log_sq_bb_count; __u8 log_sq_stride; __u8 reserved[5]; }; It is better to modify hns_roce_create_qp in libhns, right? Thanks Regards Wei Hu >> -- >> 1.9.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html