From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751990AbdI2CFU (ORCPT ); Thu, 28 Sep 2017 22:05:20 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:7066 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751339AbdI2CFS (ORCPT ); Thu, 28 Sep 2017 22:05:18 -0400 Subject: Re: [PATCH for-next 2/9] RDMA/hns: Factor out the code for checking sdb status into a new function To: Leon Romanovsky References: <1506574654-56699-1-git-send-email-xavier.huwei@huawei.com> <1506574654-56699-3-git-send-email-xavier.huwei@huawei.com> <20170928135014.GY2297@mtr-leonro.local> CC: , , , , , , , , , , , From: "Wei Hu (Xavier)" Message-ID: <59CDAA50.60809@huawei.com> Date: Fri, 29 Sep 2017 10:05:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20170928135014.GY2297@mtr-leonro.local> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.57.115.182] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.59CDAA5C.004F,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 5c7e3dd2b19be8b2f2b9183bf14d8655 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/9/28 21:50, Leon Romanovsky wrote: > On Thu, Sep 28, 2017 at 12:57:27PM +0800, Wei Hu (Xavier) wrote: >> From: Lijun Ou >> >> It mainly places the lines for checking send doorbell status >> into a special functions. As a result, we can directly call it in >> check_qp_db_process_status function and keep consistent indenting >> style. >> >> It fixes: 5f110ac4bed8 ("IB/hns: Fix for checkpatch.pl comment style) > You forgot " at the end of the line, and there is need to put fixes > (should be Fixes) in the line before Signed-off-by. Thanks, Leon We will modify the statement(Fixes: xx) and put it before signed-off-by in patch v2. >> The warning from static checker: >> drivers/infiniband/hw/hns/hns_roce_hw_v1.c:3562 check_qp_db_process_status() >> warn: inconsistent indenting >> >> Signed-off-by: Lijun Ou >> Signed-off-by: Wei Hu (Xavier) >> Signed-off-by: Shaobo Xu >> --- >> drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 95 ++++++++++++++++-------------- >> 1 file changed, 51 insertions(+), 44 deletions(-) >>