From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756402AbdJJJeh (ORCPT <rfc822;w@1wt.eu>);
        Tue, 10 Oct 2017 05:34:37 -0400
Received: from szxga04-in.huawei.com ([45.249.212.190]:7959 "EHLO
        szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755643AbdJJJed (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 10 Oct 2017 05:34:33 -0400
Subject: Re: [PATCH v2] acpi/arm64: pr_err() strings should end with newlines
To: Arvind Yadav <arvind.yadav.cs@gmail.com>, <lorenzo.pieralisi@arm.com>,
        <hanjun.guo@linaro.org>, <sudeep.holla@arm.com>, <rjw@rjwysocki.net>,
        <lenb@kernel.org>
References: <d81bee42b06beefa9a7149b5b35bf884836c2595.1506321825.git.arvind.yadav.cs@gmail.com>
CC: <linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From: Hanjun Guo <guohanjun@huawei.com>
Message-ID: <59DC93FE.2060004@huawei.com>
Date: Tue, 10 Oct 2017 17:33:50 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <d81bee42b06beefa9a7149b5b35bf884836c2595.1506321825.git.arvind.yadav.cs@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.17.188]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
        refid=str=0001.0A020205.59DC940E.0009,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
        ip=0.0.0.0,
        so=2014-11-16 11:51:01,
        dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: a79a1811fb15541334dddac1e3f2a23f
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2017/9/25 15:24, Arvind Yadav wrote:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> changes in v2:
>              Add changelog.
>
>  drivers/acpi/arm64/gtdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
> index 597a737..92f9edf 100644
> --- a/drivers/acpi/arm64/gtdt.c
> +++ b/drivers/acpi/arm64/gtdt.c
> @@ -199,7 +199,7 @@ static int __init gtdt_parse_timer_block(struct acpi_gtdt_timer_block *block,
>  	struct acpi_gtdt_timer_entry *gtdt_frame;
>  
>  	if (!block->timer_count) {
> -		pr_err(FW_BUG "GT block present, but frame count is zero.");
> +		pr_err(FW_BUG "GT block present, but frame count is zero.\n");
>  		return -ENODEV;
>  	}
>  

Make sense to me,

Acked-by: Hanjun Guo <hanjun.guo@linaro.org>

Lorenzo, could you pick this up for 4.15?

Thanks
Hanjun