* [PATCH] acpi/arm64: pr_err() strings should end with newlines
@ 2017-09-25 6:45 Arvind Yadav
2017-10-10 9:33 ` [PATCH v2] " Hanjun Guo
0 siblings, 1 reply; 3+ messages in thread
From: Arvind Yadav @ 2017-09-25 6:45 UTC (permalink / raw)
To: lorenzo.pieralisi, hanjun.guo, sudeep.holla, rjw, lenb
Cc: linux-acpi, linux-kernel
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/acpi/arm64/gtdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
index 597a737..92f9edf 100644
--- a/drivers/acpi/arm64/gtdt.c
+++ b/drivers/acpi/arm64/gtdt.c
@@ -199,7 +199,7 @@ static int __init gtdt_parse_timer_block(struct acpi_gtdt_timer_block *block,
struct acpi_gtdt_timer_entry *gtdt_frame;
if (!block->timer_count) {
- pr_err(FW_BUG "GT block present, but frame count is zero.");
+ pr_err(FW_BUG "GT block present, but frame count is zero.\n");
return -ENODEV;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] acpi/arm64: pr_err() strings should end with newlines
2017-09-25 6:45 [PATCH] acpi/arm64: pr_err() strings should end with newlines Arvind Yadav
@ 2017-10-10 9:33 ` Hanjun Guo
2017-10-10 10:24 ` Lorenzo Pieralisi
0 siblings, 1 reply; 3+ messages in thread
From: Hanjun Guo @ 2017-10-10 9:33 UTC (permalink / raw)
To: Arvind Yadav, lorenzo.pieralisi, hanjun.guo, sudeep.holla, rjw,
lenb
Cc: linux-acpi, linux-kernel
On 2017/9/25 15:24, Arvind Yadav wrote:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> changes in v2:
> Add changelog.
>
> drivers/acpi/arm64/gtdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
> index 597a737..92f9edf 100644
> --- a/drivers/acpi/arm64/gtdt.c
> +++ b/drivers/acpi/arm64/gtdt.c
> @@ -199,7 +199,7 @@ static int __init gtdt_parse_timer_block(struct acpi_gtdt_timer_block *block,
> struct acpi_gtdt_timer_entry *gtdt_frame;
>
> if (!block->timer_count) {
> - pr_err(FW_BUG "GT block present, but frame count is zero.");
> + pr_err(FW_BUG "GT block present, but frame count is zero.\n");
> return -ENODEV;
> }
>
Make sense to me,
Acked-by: Hanjun Guo <hanjun.guo@linaro.org>
Lorenzo, could you pick this up for 4.15?
Thanks
Hanjun
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] acpi/arm64: pr_err() strings should end with newlines
2017-10-10 9:33 ` [PATCH v2] " Hanjun Guo
@ 2017-10-10 10:24 ` Lorenzo Pieralisi
0 siblings, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2017-10-10 10:24 UTC (permalink / raw)
To: Hanjun Guo
Cc: Arvind Yadav, hanjun.guo, sudeep.holla, rjw, lenb, linux-acpi,
linux-kernel
On Tue, Oct 10, 2017 at 05:33:50PM +0800, Hanjun Guo wrote:
> On 2017/9/25 15:24, Arvind Yadav wrote:
> > pr_err() messages should terminated with a new-line to avoid
> > other messages being concatenated onto the end.
> >
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> > ---
> > changes in v2:
> > Add changelog.
> >
> > drivers/acpi/arm64/gtdt.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
> > index 597a737..92f9edf 100644
> > --- a/drivers/acpi/arm64/gtdt.c
> > +++ b/drivers/acpi/arm64/gtdt.c
> > @@ -199,7 +199,7 @@ static int __init gtdt_parse_timer_block(struct acpi_gtdt_timer_block *block,
> > struct acpi_gtdt_timer_entry *gtdt_frame;
> >
> > if (!block->timer_count) {
> > - pr_err(FW_BUG "GT block present, but frame count is zero.");
> > + pr_err(FW_BUG "GT block present, but frame count is zero.\n");
> > return -ENODEV;
> > }
> >
>
> Make sense to me,
>
> Acked-by: Hanjun Guo <hanjun.guo@linaro.org>
>
> Lorenzo, could you pick this up for 4.15?
Sure, thanks for reminding.
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-10 10:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-25 6:45 [PATCH] acpi/arm64: pr_err() strings should end with newlines Arvind Yadav
2017-10-10 9:33 ` [PATCH v2] " Hanjun Guo
2017-10-10 10:24 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox