From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756420AbdJJJfH (ORCPT ); Tue, 10 Oct 2017 05:35:07 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:21339 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756168AbdJJJef (ORCPT ); Tue, 10 Oct 2017 05:34:35 -0400 X-AuditID: b6c32a39-a6fff7000000109f-25-59dc94296ce8 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <59DC9428.4090203@samsung.com> Date: Tue, 10 Oct 2017 18:34:32 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Arnd Bergmann , Sylwester Nawrocki , Tomasz Figa , Michael Turquette , Stephen Boyd , Kukjin Kim , Krzysztof Kozlowski Cc: Marek Szyprowski , Ulf Hansson , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: samsung: exynos5433: mark PM functions as __maybe_unused In-reply-to: <20171010091522.2286344-1-arnd@arndb.de> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLJsWRmVeSWpSXmKPExsWy7bCmvq7mlDuRBqcPKlj8nXSM3aL/8Wtm i/PnN7BbbHp8jdXiY889VovLu+awWcw4v4/JYu2Ru+wWF0+5Whx+085q8eNMN4vFql1/GC2O rw134PX4/WsSo8f7G63sHpf7epk8ds66y+6xaVUnm8eda3vYPDYvqffo27KK0ePzJrkAzqhU m4zUxJTUIoXUvOT8lMy8dFsl7+B453hTMwNDXUNLC3MlhbzE3FRbJRefAF23zBygq5UUyhJz SoFCAYnFxUr6djZF+aUlqQoZ+cUltkrRhoZGeoYG5npGRkZ6JsaxVkamQCUJqRnzJrYwFuzg rTiw5gtLA+My7i5GTg4JAROJT5svMncxcnEICexglLhy7ho7hPOdUWLO4o2MMFXnv81ghUjs ZpS41HGXHSTBKyAo8WPyPZYuRg4OZgF5iSOXskHCzAKaElt3r4cadI9RovvNayaIei2JLW+e g9ksAqoSt2++ZgOx2YDi+1/cALP5BRQlrv54DLZYVCBCYuf8b2CDRAQmMkl8nrCBCcRhFrjL KHHk8hZWkCphgRCJaQcfgF3EKWAq8fjmdBaQIgmB6ewSFyb9ZIb4wUXi2NY+JghbWOLV8S3s IGdLCEhLXDpqC1Hfziixec49qOYORon7KxtZIRqMJU51NTJBPMcn8e5rDytEM69ER5sQRImH xLSNx6Dh5Six/eV8Roj/geYsWtvJPIFRbhZSkM1CBNkspCBbwMi8ilEstaA4Nz212LDAVK84 Mbe4NC9dLzk/dxMjOKlqWe5gPHbO5xCjAAejEg+vx8TbkUKsiWXFlbmHGCU4mJVEeEOU70QK 8aYkVlalFuXHF5XmpBYfYjQFhvhEZinR5Hxgws8riTc0sTQwMTMCpjBLQ0MlcV7R9dcihATS E0tSs1NTC1KLYPqYODilGhgnzhTYtNg26K1Y/TzHk9/9z3HwZnM8C7ISbD8dpikq8TST3elL c75Sf+Kqp44mNy333si/VhMdyrDUaV7cjqj/Lzw0bT44qXXvMzV4HiFdcFWmP6tP9V1K5afG F2YX/ONesT6+c10/bZKCXEirRqWRLFfXh/x3W+9uyF4o+uR7wMbNu0+usVdiKc5INNRiLipO BACJsJvZwAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjkeLIzCtJLcpLzFFi42I5/e+xgK7mlDuRBlf3clv8nXSM3aL/8Wtm i/PnN7BbbHp8jdXiY889VovLu+awWcw4v4/JYu2Ru+wWF0+5Whx+085q8eNMN4vFql1/GC2O rw134PX4/WsSo8f7G63sHpf7epk8ds66y+6xaVUnm8eda3vYPDYvqffo27KK0ePzJrkAzigu m5TUnMyy1CJ9uwSujHkTWxgLdvBWHFjzhaWBcRl3FyMnh4SAicT5bzNYuxi5OIQEdjJKtL88 xAyS4BUQlPgx+R5LFyMHB7OAvMSRS9kgYWYBdYlJ8xYxQ9Q/YJRYveErG0S9lsSWN8+ZQGwW AVWJ2zdfg8XZgOL7X9wAs/kFFCWu/njMCDJTVCBCovtEJcgcEYHJTBJ7Zh9ih1hwl1Hi/B9X EFtYIERi2sEH7BDLuhglTh88BjaIU8BU4vHN6SwTGAVmIbl1FsKts5DcuoCReRWjZGpBcW56 brFRgWFearlecWJucWleul5yfu4mRmAsbTus1beD8f6S+EOMAhyMSjy8CybfjhRiTSwrrsw9 xCjBwawkwhuifCdSiDclsbIqtSg/vqg0J7X4EKM0B4uSOO/tvGORQgLpiSWp2ampBalFMFkm Dk6pBsbN9yzExc+vZyvyPXGs9IZS7daN35UPc+21YD/xU+3bFasgo0si/wVYnCRv/ssK36D+ /vjf7ffOKhgvPL0iSO395Jh/PeeOTjrRYWq0UbUn59xHxknPHu5K/aTAeO3hNw7JU/Gcy06t nmrm2r1swkaB3f1B538fSM23UNKt3Dv7Xevf2L+rw26lK7EUZyQaajEXFScCAPkCyyGhAgAA X-CMS-MailID: 20171010093433epcas1p428950f032a6b5c9f53c5eed4bf4559c8 X-Msg-Generator: CA X-Sender-IP: 182.195.42.142 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171010091531epcas3p352520667820f068219330b307df69df2 X-RootMTR: 20171010091531epcas3p352520667820f068219330b307df69df2 References: <20171010091522.2286344-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On 2017년 10월 10일 18:15, Arnd Bergmann wrote: > The suspend/resume functions are referenced conditionally, causing > a harmless warning when CONFIG_PM is disabled: > > drivers/clk/samsung/clk-exynos5433.c:5476:12: error: 'exynos5433_cmu_resume' defined but not used [-Werror=unused-function] > drivers/clk/samsung/clk-exynos5433.c:5453:12: error: 'exynos5433_cmu_suspend' defined but not used [-Werror=unused-function] > > This marks both as __maybe_unused to shut up the warning. > > Fixes: 523d3de41f02 ("clk: samsung: exynos5433: Add support for runtime PM") > Signed-off-by: Arnd Bergmann > --- > drivers/clk/samsung/clk-exynos5433.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c > index cd9337613dd8..db270908037a 100644 > --- a/drivers/clk/samsung/clk-exynos5433.c > +++ b/drivers/clk/samsung/clk-exynos5433.c > @@ -5450,7 +5450,7 @@ struct exynos5433_cmu_data { > struct samsung_clk_provider ctx; > }; > > -static int exynos5433_cmu_suspend(struct device *dev) > +static int __maybe_unused exynos5433_cmu_suspend(struct device *dev) > { > struct exynos5433_cmu_data *data = dev_get_drvdata(dev); > int i; > @@ -5473,7 +5473,7 @@ static int exynos5433_cmu_suspend(struct device *dev) > return 0; > } > > -static int exynos5433_cmu_resume(struct device *dev) > +static int __maybe_unused exynos5433_cmu_resume(struct device *dev) > { > struct exynos5433_cmu_data *data = dev_get_drvdata(dev); > int i; > Acked-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics