From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752813AbdJMWdY (ORCPT ); Fri, 13 Oct 2017 18:33:24 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:49312 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751510AbdJMWdW (ORCPT ); Fri, 13 Oct 2017 18:33:22 -0400 X-Google-Smtp-Source: AOwi7QAJ87K+wvKe79oqo7BBnORlxTlerh8By3TJIXk8p2QQ7YO2J/P1i4t16P8gB/iLJsmoimI7bw== Subject: Re: [PATCH 2/2] of/resolver: Replace kmalloc + memcpy with kmemdup() To: Stephen Boyd , Rob Herring References: <20171013073558.11518-1-stephen.boyd@linaro.org> <20171013073558.11518-3-stephen.boyd@linaro.org> Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org From: Frank Rowand Message-ID: <59E13F23.4030201@gmail.com> Date: Fri, 13 Oct 2017 15:33:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20171013073558.11518-3-stephen.boyd@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/17 00:35, Stephen Boyd wrote: > Save one line. > > Signed-off-by: Stephen Boyd > --- > drivers/of/resolver.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c > index 2d58253bf2f7..bd21a66f6930 100644 > --- a/drivers/of/resolver.c > +++ b/drivers/of/resolver.c > @@ -84,10 +84,9 @@ static int update_usages_of_a_phandle_reference(struct device_node *overlay, > int offset, len; > int err = 0; > > - value = kmalloc(prop_fixup->length, GFP_KERNEL); > + value = kmemdup(prop_fixup->value, prop_fixup->length, GFP_KERNEL); > if (!value) > return -ENOMEM; > - memcpy(value, prop_fixup->value, prop_fixup->length); > > /* prop_fixup contains a list of tuples of path:property_name:offset */ > end = value + prop_fixup->length; > Reviewed-by: Frank Rowand