From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753923AbdJNPHg (ORCPT ); Sat, 14 Oct 2017 11:07:36 -0400 Received: from mx02-sz.bfs.de ([194.94.69.103]:17844 "EHLO mx02-sz.bfs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753759AbdJNPHe (ORCPT ); Sat, 14 Oct 2017 11:07:34 -0400 Message-ID: <59E22831.6030608@bfs.de> Date: Sat, 14 Oct 2017 17:07:29 +0200 From: walter harms Reply-To: wharms@bfs.de User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11 MIME-Version: 1.0 To: Colin King CC: Paul Moore , Stephen Smalley , Eric Paris , James Morris , "Serge E . Hallyn" , Markus Elfring , selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selinux: remove extraneous initialization of slots_used and max_chain_len References: <20171014145224.840-1-colin.king@canonical.com> In-Reply-To: <20171014145224.840-1-colin.king@canonical.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 14.10.2017 16:52, schrieb Colin King: > From: Colin Ian King > > Variables slots_used and max_chain_len are being initialized to zero > twice. Remove the first set of initializations. Cleans up the > clang warnings: > > Value stored to 'slots_used' is never read > Value stored to 'max_chain_len' is never read > > Signed-off-by: Colin Ian King > --- > security/selinux/ss/hashtab.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/security/selinux/ss/hashtab.c b/security/selinux/ss/hashtab.c > index bef7577d1270..622fd50c8b9c 100644 > --- a/security/selinux/ss/hashtab.c > +++ b/security/selinux/ss/hashtab.c > @@ -148,8 +148,6 @@ void hashtab_stat(struct hashtab *h, struct hashtab_info *info) > u32 i, chain_len, slots_used, max_chain_len; > struct hashtab_node *cur; > > - slots_used = 0; > - max_chain_len = 0; > for (slots_used = max_chain_len = i = 0; i < h->size; i++) { > cur = h->htable[i]; > if (cur) { personally i would remove it from the for() loop. for(i=0;) is a common pattern but setting variables this way is at least uncommon and does not improve the readability of the code. not a good example for security related code. just my 2 cents, re, wh