From: Daniel Borkmann <daniel@iogearbox.net>
To: Richard Weinberger <richard@nod.at>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, ast@kernel.org
Subject: Re: [PATCH 2/3] bpf: Remove dead variable
Date: Mon, 16 Oct 2017 20:54:36 +0200 [thread overview]
Message-ID: <59E5006C.4090303@iogearbox.net> (raw)
In-Reply-To: <20171016181856.12497-2-richard@nod.at>
On 10/16/2017 08:18 PM, Richard Weinberger wrote:
> task is never used in bpf_get_current_uid_gid(), kill it.
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> kernel/bpf/helpers.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c
> index e8845adcd15e..511c9d522cfc 100644
> --- a/kernel/bpf/helpers.c
> +++ b/kernel/bpf/helpers.c
> @@ -131,7 +131,6 @@ const struct bpf_func_proto bpf_get_current_pid_tgid_proto = {
>
> BPF_CALL_0(bpf_get_current_uid_gid)
> {
> - struct task_struct *task = current;
> kuid_t uid;
> kgid_t gid;
>
>
Needs to be squashed into patch 1/3?
next prev parent reply other threads:[~2017-10-16 18:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 18:18 [PATCH 1/3] bpf: Don't check for current being NULL Richard Weinberger
2017-10-16 18:18 ` [PATCH 2/3] bpf: Remove dead variable Richard Weinberger
2017-10-16 18:54 ` Daniel Borkmann [this message]
2017-10-16 18:59 ` Richard Weinberger
2017-10-16 19:11 ` Daniel Borkmann
2017-10-16 19:22 ` Richard Weinberger
2017-10-16 20:48 ` Daniel Borkmann
2017-10-16 18:18 ` [PATCH 3/3] bpf: Make sure that ->comm does not change under us Richard Weinberger
2017-10-16 20:50 ` Daniel Borkmann
2017-10-16 20:55 ` Richard Weinberger
2017-10-16 21:02 ` Daniel Borkmann
2017-10-16 21:10 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59E5006C.4090303@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox