From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756817AbdJPSyj (ORCPT ); Mon, 16 Oct 2017 14:54:39 -0400 Received: from www62.your-server.de ([213.133.104.62]:47275 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756752AbdJPSyi (ORCPT ); Mon, 16 Oct 2017 14:54:38 -0400 Message-ID: <59E5006C.4090303@iogearbox.net> Date: Mon, 16 Oct 2017 20:54:36 +0200 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Richard Weinberger , netdev@vger.kernel.org CC: linux-kernel@vger.kernel.org, ast@kernel.org Subject: Re: [PATCH 2/3] bpf: Remove dead variable References: <20171016181856.12497-1-richard@nod.at> <20171016181856.12497-2-richard@nod.at> In-Reply-To: <20171016181856.12497-2-richard@nod.at> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/2017 08:18 PM, Richard Weinberger wrote: > task is never used in bpf_get_current_uid_gid(), kill it. > > Signed-off-by: Richard Weinberger > --- > kernel/bpf/helpers.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c > index e8845adcd15e..511c9d522cfc 100644 > --- a/kernel/bpf/helpers.c > +++ b/kernel/bpf/helpers.c > @@ -131,7 +131,6 @@ const struct bpf_func_proto bpf_get_current_pid_tgid_proto = { > > BPF_CALL_0(bpf_get_current_uid_gid) > { > - struct task_struct *task = current; > kuid_t uid; > kgid_t gid; > > Needs to be squashed into patch 1/3?