From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757214AbdJPXUI (ORCPT ); Mon, 16 Oct 2017 19:20:08 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:31561 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752519AbdJPXUG (ORCPT ); Mon, 16 Oct 2017 19:20:06 -0400 X-AuditID: b6c32a47-4b1ff70000001114-a1-59e53ea40513 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <59E53EA4.5020302@samsung.com> Date: Tue, 17 Oct 2017 08:20:04 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Raveendra Padasalagi , MyungJoo Ham , Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH 2/2] extcon: add optional debounce-timeout-ms attribute In-reply-to: <1508139288-11114-2-git-send-email-raveendra.padasalagi@broadcom.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLKsWRmVeSWpSXmKPExsWy7bCmme4Su6eRBtMfC1is7T3KYjH/yDlW i8u75rBZLL1+kcniduMKNotv7Y9YLVr3HmF3YPdYM28No8es+2fZPDat6mTz6NuyitHj8ya5 ANaoVJuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wcoDOU FMoSc0qBQgGJxcVK+nY2RfmlJakKGfnFJbZK0YaGRnqGBuZ6RkZGeibGsVZGpkAlCakZL3cc Zyk4KFLRMOsRSwPjR4EuRk4OCQETiV3/zrF2MXJxCAnsYJSYvn4flPOdUWJWx0p2mKr7k+Yw QiQ2MEq8nLOFCSTBKyAo8WPyPZYuRg4OZgF5iSOXskHCzAKaElt3r2eHqL/HKHH7RSMLRL2W xJX9z9lAbBYBVYnpvT/AbDag+P4XN8BsfgFFias/HjOC2KICERI7538DGyQi8AZo8Yt2VpgN v+e1gl0nLOAtcXHvXLAFnAIhEvO/ngFrkBC4zCax5edMZogXXCQm71/NCGELS7w6vgXqNWmJ Z6s2MkI0tDNKbJ4D8g6I08EocX9lIytElbHEqa5GJojVfBIdh/+yg/wsIcAr0dEmBFHiIbFw 6hRGiLCjRM8BO4j33zJK3Ll+jGkCo9wspBCbhQixWUghtoCReRWjWGpBcW56arFRgbFecWJu cWleul5yfu4mRnDS03LfwbjtnM8hRgEORiUe3oxDTyKFWBPLiitzDzFKcDArifB+0XoaKcSb klhZlVqUH19UmpNafIjRFBjgE5mlRJPzgQk5ryTe0MTSwMTMzMjczAKYxMR567ZdixASSE8s Sc1OTS1ILYLpY+LglGpgZDNhdm3lDpLZt+7W3ZTlaf7HfxVFpNz5sSPI80uZk/1aB4dL0/5/ 9p377Ij1VbmgKdPOKcw/siWheMoKZyehlOLg0zuTGNUFPmgs536WK/n5rW6Y4e0Dk/dvXBmh bOl7dEvzrHOpWQ/n/wty21nR2Wx7nc+s/ejGtD1nrglH9O6cOT3r6o5UfSWW4oxEQy3mouJE ANemnYWQAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHLMWRmVeSWpSXmKPExsVy+t9jQd3Fdk8jDdZdNbVY23uUxWL+kXOs Fpd3zWGzWHr9IpPF7cYVbBbf2h+xWrTuPcLuwO6xZt4aRo9Z98+yeWxa1cnm0bdlFaPH501y AaxRXDYpqTmZZalF+nYJXBkvdxxnKTgoUtEw6xFLA+NHgS5GTg4JAROJ+5PmMILYQgLrGCVW LeYBsXkFBCV+TL7H0sXIwcEsIC9x5FI2SJhZQF1i0rxFzF2MXEDlDxglbmxvY4Ko15K4sv85 G4jNIqAqMb33B5jNBhTf/+IGmM0voChx9cdjRpCZogIREt0nKkHmiAi8YZQ4tG4FG8QCTYnf 81rZQWxhAW+Ji3vnskAse88o0fFiAwtIglMgRGLGppVsExgFZiG5dRbCrbOQ3LqAkXkVo2Rq QXFuem6xUYFRXmq5XnFibnFpXrpecn7uJkZgqG87rNW/g/HxkvhDjAIcjEo8vBmHnkQKsSaW FVfmHmKU4GBWEuH9ovU0Uog3JbGyKrUoP76oNCe1+BCjNAeLkjgvf/6xSCGB9MSS1OzU1ILU IpgsEwenVAPjTL4V3xYomysILlvtLaMqxnz+w+SiWO6Nr7cocEU/XNne7sbv8DCt4utizvat /zsCRfi2rD6X8GjCrCo/yy1VC+Yeu/bVpvPJp2dM5n+M/d1n1rC2/he//HOi69I3f0X9t0Sw 7GHyK9K+nj3tnkhf3LP362P1rfvKn09uXLTO6XHH/Xd61rsNlFiKMxINtZiLihMBYdCvLXEC AAA= X-CMS-MailID: 20171016232003epcas2p4b8ac94afeb6a05f7bfc91945e45a26e9 X-Msg-Generator: CA X-Sender-IP: 182.195.42.143 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171016073514epcas2p1dbcba68d0491b76af827d2d52da3b371 X-RootMTR: 20171016073514epcas2p1dbcba68d0491b76af827d2d52da3b371 References: <1508139288-11114-1-git-send-email-raveendra.padasalagi@broadcom.com> <1508139288-11114-2-git-send-email-raveendra.padasalagi@broadcom.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2017년 10월 16일 16:34, Raveendra Padasalagi wrote: > Add changes to capture optional dt attribute "debounce-timeout-ms" > provided in extcon node and used the same value if provided otherwise > default value of 20ms is used for id and vbus gpios debounce time. > > Signed-off-by: Raveendra Padasalagi > Reviewed-by: Ray Jui > Reviewed-by: Srinath Mannam > --- > drivers/extcon/extcon-usb-gpio.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c > index 9c925b0..090f65f 100644 > --- a/drivers/extcon/extcon-usb-gpio.c > +++ b/drivers/extcon/extcon-usb-gpio.c > @@ -41,6 +41,7 @@ struct usb_extcon_info { > > unsigned long debounce_jiffies; > struct delayed_work wq_detcable; > + unsigned int gpio_debounce_timeout_ms; You better to use the "debounce_usecs" name because the unit of debounce time is usec. > }; > > static const unsigned int usb_extcon_cable[] = { > @@ -133,6 +134,11 @@ static int usb_extcon_probe(struct platform_device *pdev) > if (IS_ERR(info->vbus_gpiod)) > return PTR_ERR(info->vbus_gpiod); > > + ret = of_property_read_u32(np, "debounce-timeout-ms", > + &info->gpio_debounce_timeout_ms); I prefer to use the 'input-debounce' property name Because the pinctrl-bindings.txt[1] gives the guide for the generic name of debounce. [1] Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt - "debounce-timeout-ms" -> "input-debounce" > + if (ret) > + info->gpio_debounce_timeout_ms = USB_GPIO_DEBOUNCE_MS; > + > info->edev = devm_extcon_dev_allocate(dev, usb_extcon_cable); > if (IS_ERR(info->edev)) { > dev_err(dev, "failed to allocate extcon device\n"); > @@ -147,13 +153,14 @@ static int usb_extcon_probe(struct platform_device *pdev) > > if (info->id_gpiod) > ret = gpiod_set_debounce(info->id_gpiod, > - USB_GPIO_DEBOUNCE_MS * 1000); > + info->gpio_debounce_timeout_ms * 1000); > if (!ret && info->vbus_gpiod) > ret = gpiod_set_debounce(info->vbus_gpiod, > - USB_GPIO_DEBOUNCE_MS * 1000); > + info->gpio_debounce_timeout_ms * 1000); > > if (ret < 0) > - info->debounce_jiffies = msecs_to_jiffies(USB_GPIO_DEBOUNCE_MS); > + info->debounce_jiffies = msecs_to_jiffies( > + info->gpio_debounce_timeout_ms); > > INIT_DELAYED_WORK(&info->wq_detcable, usb_extcon_detect_cable); > > -- Best Regards, Chanwoo Choi Samsung Electronics