* [PATCH 1/2] Documentation: dt: extcon: add optional debounce-timeout-ms attribute @ 2017-10-16 7:34 ` Raveendra Padasalagi 2017-10-16 7:34 ` [PATCH 2/2] " Raveendra Padasalagi 2017-10-16 23:07 ` [PATCH 1/2] Documentation: dt: " Chanwoo Choi 0 siblings, 2 replies; 4+ messages in thread From: Raveendra Padasalagi @ 2017-10-16 7:34 UTC (permalink / raw) To: MyungJoo Ham, Chanwoo Choi, Rob Herring, Mark Rutland, linux-kernel, devicetree Cc: bcm-kernel-feedback-list, Raveendra Padasalagi Add documentation on optional dt attribute "debounce-timeout-ms" in extcon node to capture user specified timeout value for id and vbus gpio detection. Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com> Reviewed-by: Ray Jui <ray.jui@broadcom.com> Reviewed-by: Srinath Mannam <srinath.mannam@broadcom.com> --- Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt index dfc14f7..6df6d69 100644 --- a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt +++ b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt @@ -10,6 +10,10 @@ Either one of id-gpio or vbus-gpio must be present. Both can be present as well. - id-gpio: gpio for USB ID pin. See gpio binding. - vbus-gpio: gpio for USB VBUS pin. +Optional properties: +- debounce-timeout-ms: debounce timeout value for id and vbus gpio in + milliseconds. + Example: Examples of extcon-usb-gpio node in dra7-evm.dts as listed below: extcon_usb1 { compatible = "linux,extcon-usb-gpio"; -- 1.9.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] extcon: add optional debounce-timeout-ms attribute 2017-10-16 7:34 ` [PATCH 1/2] Documentation: dt: extcon: add optional debounce-timeout-ms attribute Raveendra Padasalagi @ 2017-10-16 7:34 ` Raveendra Padasalagi 2017-10-16 23:20 ` Chanwoo Choi 2017-10-16 23:07 ` [PATCH 1/2] Documentation: dt: " Chanwoo Choi 1 sibling, 1 reply; 4+ messages in thread From: Raveendra Padasalagi @ 2017-10-16 7:34 UTC (permalink / raw) To: MyungJoo Ham, Chanwoo Choi, Rob Herring, Mark Rutland, linux-kernel, devicetree Cc: bcm-kernel-feedback-list, Raveendra Padasalagi Add changes to capture optional dt attribute "debounce-timeout-ms" provided in extcon node and used the same value if provided otherwise default value of 20ms is used for id and vbus gpios debounce time. Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com> Reviewed-by: Ray Jui <ray.jui@broadcom.com> Reviewed-by: Srinath Mannam <srinath.mannam@broadcom.com> --- drivers/extcon/extcon-usb-gpio.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c index 9c925b0..090f65f 100644 --- a/drivers/extcon/extcon-usb-gpio.c +++ b/drivers/extcon/extcon-usb-gpio.c @@ -41,6 +41,7 @@ struct usb_extcon_info { unsigned long debounce_jiffies; struct delayed_work wq_detcable; + unsigned int gpio_debounce_timeout_ms; }; static const unsigned int usb_extcon_cable[] = { @@ -133,6 +134,11 @@ static int usb_extcon_probe(struct platform_device *pdev) if (IS_ERR(info->vbus_gpiod)) return PTR_ERR(info->vbus_gpiod); + ret = of_property_read_u32(np, "debounce-timeout-ms", + &info->gpio_debounce_timeout_ms); + if (ret) + info->gpio_debounce_timeout_ms = USB_GPIO_DEBOUNCE_MS; + info->edev = devm_extcon_dev_allocate(dev, usb_extcon_cable); if (IS_ERR(info->edev)) { dev_err(dev, "failed to allocate extcon device\n"); @@ -147,13 +153,14 @@ static int usb_extcon_probe(struct platform_device *pdev) if (info->id_gpiod) ret = gpiod_set_debounce(info->id_gpiod, - USB_GPIO_DEBOUNCE_MS * 1000); + info->gpio_debounce_timeout_ms * 1000); if (!ret && info->vbus_gpiod) ret = gpiod_set_debounce(info->vbus_gpiod, - USB_GPIO_DEBOUNCE_MS * 1000); + info->gpio_debounce_timeout_ms * 1000); if (ret < 0) - info->debounce_jiffies = msecs_to_jiffies(USB_GPIO_DEBOUNCE_MS); + info->debounce_jiffies = msecs_to_jiffies( + info->gpio_debounce_timeout_ms); INIT_DELAYED_WORK(&info->wq_detcable, usb_extcon_detect_cable); -- 1.9.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] extcon: add optional debounce-timeout-ms attribute 2017-10-16 7:34 ` [PATCH 2/2] " Raveendra Padasalagi @ 2017-10-16 23:20 ` Chanwoo Choi 0 siblings, 0 replies; 4+ messages in thread From: Chanwoo Choi @ 2017-10-16 23:20 UTC (permalink / raw) To: Raveendra Padasalagi, MyungJoo Ham, Rob Herring, Mark Rutland, linux-kernel, devicetree Cc: bcm-kernel-feedback-list Hi, On 2017년 10월 16일 16:34, Raveendra Padasalagi wrote: > Add changes to capture optional dt attribute "debounce-timeout-ms" > provided in extcon node and used the same value if provided otherwise > default value of 20ms is used for id and vbus gpios debounce time. > > Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com> > Reviewed-by: Ray Jui <ray.jui@broadcom.com> > Reviewed-by: Srinath Mannam <srinath.mannam@broadcom.com> > --- > drivers/extcon/extcon-usb-gpio.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c > index 9c925b0..090f65f 100644 > --- a/drivers/extcon/extcon-usb-gpio.c > +++ b/drivers/extcon/extcon-usb-gpio.c > @@ -41,6 +41,7 @@ struct usb_extcon_info { > > unsigned long debounce_jiffies; > struct delayed_work wq_detcable; > + unsigned int gpio_debounce_timeout_ms; You better to use the "debounce_usecs" name because the unit of debounce time is usec. > }; > > static const unsigned int usb_extcon_cable[] = { > @@ -133,6 +134,11 @@ static int usb_extcon_probe(struct platform_device *pdev) > if (IS_ERR(info->vbus_gpiod)) > return PTR_ERR(info->vbus_gpiod); > > + ret = of_property_read_u32(np, "debounce-timeout-ms", > + &info->gpio_debounce_timeout_ms); I prefer to use the 'input-debounce' property name Because the pinctrl-bindings.txt[1] gives the guide for the generic name of debounce. [1] Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt - "debounce-timeout-ms" -> "input-debounce" > + if (ret) > + info->gpio_debounce_timeout_ms = USB_GPIO_DEBOUNCE_MS; > + > info->edev = devm_extcon_dev_allocate(dev, usb_extcon_cable); > if (IS_ERR(info->edev)) { > dev_err(dev, "failed to allocate extcon device\n"); > @@ -147,13 +153,14 @@ static int usb_extcon_probe(struct platform_device *pdev) > > if (info->id_gpiod) > ret = gpiod_set_debounce(info->id_gpiod, > - USB_GPIO_DEBOUNCE_MS * 1000); > + info->gpio_debounce_timeout_ms * 1000); > if (!ret && info->vbus_gpiod) > ret = gpiod_set_debounce(info->vbus_gpiod, > - USB_GPIO_DEBOUNCE_MS * 1000); > + info->gpio_debounce_timeout_ms * 1000); > > if (ret < 0) > - info->debounce_jiffies = msecs_to_jiffies(USB_GPIO_DEBOUNCE_MS); > + info->debounce_jiffies = msecs_to_jiffies( > + info->gpio_debounce_timeout_ms); > > INIT_DELAYED_WORK(&info->wq_detcable, usb_extcon_detect_cable); > > -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] Documentation: dt: extcon: add optional debounce-timeout-ms attribute 2017-10-16 7:34 ` [PATCH 1/2] Documentation: dt: extcon: add optional debounce-timeout-ms attribute Raveendra Padasalagi 2017-10-16 7:34 ` [PATCH 2/2] " Raveendra Padasalagi @ 2017-10-16 23:07 ` Chanwoo Choi 1 sibling, 0 replies; 4+ messages in thread From: Chanwoo Choi @ 2017-10-16 23:07 UTC (permalink / raw) To: Raveendra Padasalagi, MyungJoo Ham, Rob Herring, Mark Rutland, linux-kernel, devicetree Cc: bcm-kernel-feedback-list Hi, On 2017년 10월 16일 16:34, Raveendra Padasalagi wrote: > Add documentation on optional dt attribute "debounce-timeout-ms" > in extcon node to capture user specified timeout value for id > and vbus gpio detection. > > Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com> > Reviewed-by: Ray Jui <ray.jui@broadcom.com> > Reviewed-by: Srinath Mannam <srinath.mannam@broadcom.com> > --- > Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt > index dfc14f7..6df6d69 100644 > --- a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt > +++ b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt > @@ -10,6 +10,10 @@ Either one of id-gpio or vbus-gpio must be present. Both can be present as well. > - id-gpio: gpio for USB ID pin. See gpio binding. > - vbus-gpio: gpio for USB VBUS pin. > > +Optional properties: > +- debounce-timeout-ms: debounce timeout value for id and vbus gpio in > + milliseconds. I recommend that you use the 'input-debounce' propery name instead of 'debounce-timeout-ms'. When I check the pinctrl-bindings.txt[1] in order to check the property name for debounce. The documentation[1] specify the generic pinconfig property name. [1] Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > + > Example: Examples of extcon-usb-gpio node in dra7-evm.dts as listed below: > extcon_usb1 { > compatible = "linux,extcon-usb-gpio"; > -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-16 23:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20171016073506epcas2p41d359236602b4d601283504d152f4bbd@epcas2p4.samsung.com>
2017-10-16 7:34 ` [PATCH 1/2] Documentation: dt: extcon: add optional debounce-timeout-ms attribute Raveendra Padasalagi
2017-10-16 7:34 ` [PATCH 2/2] " Raveendra Padasalagi
2017-10-16 23:20 ` Chanwoo Choi
2017-10-16 23:07 ` [PATCH 1/2] Documentation: dt: " Chanwoo Choi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox