From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756448AbdJQXvj (ORCPT ); Tue, 17 Oct 2017 19:51:39 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:50184 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752274AbdJQXvh (ORCPT ); Tue, 17 Oct 2017 19:51:37 -0400 X-Google-Smtp-Source: AOwi7QBW0wU43JOACPXDLWX7yucuVKCcwAlYL2Mud0O3uirhPDOoDfmiWiUfQBhPyN4B2Ng9HXdsdg== Subject: Re: [PATCH v2 5/5] of/fdt: only store the device node basename in full_name To: Rob Herring , Alan Tull References: <20170821151651.25096-1-robh@kernel.org> <20170821151651.25096-6-robh@kernel.org> Cc: "devicetree@vger.kernel.org" , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-kernel , Benjamin Herrenschmidt , Paul Mackerras , David Laight From: Frank Rowand Message-ID: <59E69786.2030406@gmail.com> Date: Tue, 17 Oct 2017 16:51:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/17/17 14:46, Rob Herring wrote: > On Tue, Oct 17, 2017 at 4:32 PM, Alan Tull wrote: >> On Mon, Aug 21, 2017 at 10:16 AM, Rob Herring wrote: >> >> Hi Rob, >> >>> With dependencies on a statically allocated full path name converted to >>> use %pOF format specifier, we can store just the basename of node, and >>> the unflattening of the FDT can be simplified. >>> >>> This commit will affect the remaining users of full_name. After >>> analyzing these users, the remaining cases should only change some print >>> messages. The main users of full_name are providing a name for struct >>> resource. The resource names shouldn't be important other than providing >>> /proc/iomem names. >>> >>> We no longer distinguish between pre and post 0x10 dtb formats as either >>> a full path or basename will work. However, less than 0x10 formats have >>> been broken since the conversion to use libfdt (and no one has cared). >>> The conversion of the unflattening code to be non-recursive also broke >>> pre 0x10 formats as the populate_node function would return 0 in that >>> case. >>> >>> Signed-off-by: Rob Herring >>> --- >>> v2: >>> - rebase to linux-next >>> >>> drivers/of/fdt.c | 69 +++++++++----------------------------------------------- >>> 1 file changed, 11 insertions(+), 58 deletions(-) >> >> I've just updated to the latest next branch and am finding problems >> applying overlays. Reverting this commit alleviates things. The >> errors I get are: >> >> [ 88.498704] OF: overlay: Failed to apply prop @/__symbols__/clk_0 >> [ 88.513447] OF: overlay: apply failed '/__symbols__' >> [ 88.518423] create_overlay: Failed to create overlay (err=-12) > > Frank's series with overlay updates should fix this. Yes, it does: [PATCH v3 11/12] of: overlay: remove a dependency on device node full_name -Frank