From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934892AbdJRCId (ORCPT ); Tue, 17 Oct 2017 22:08:33 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:14109 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759191AbdJRCI3 (ORCPT ); Tue, 17 Oct 2017 22:08:29 -0400 X-AuditID: b6c32a46-acbff70000001153-0f-59e6b79b2e81 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="utf-8" Message-id: <59E6B79C.2040000@samsung.com> Date: Wed, 18 Oct 2017 11:08:28 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: myungjoo.ham@gmail.com Cc: Kyungmin Park , "Rafael J . Wysocki" , chanwoo@kernel.org, =?UTF-8?B?64yA7J246riw?= , LKML , Linux PM list , Kukjin Kim , Krzysztof Kozlowski , Linux Samsung SoC , linux-arm-kernel Subject: Re: [PATCH v4 8/8] PM / devfreq: exynos-bus: Register cooling device In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0hTYRjG+c45OzsrZ1+zy4eF6YkKBdc2b8dQydQadHEmhRYxD3pw4m7s bJFBeSHKLazMCluC3Yi2qHQNayUKbmAZJZSJECm2MLtYdKFWUbTjKeq/3/vwvO/3vQ8vhStO kPFUjdnO2cyskSbnED3B5KzUMzenylV3mlYyrWMjBHN84hjBHA2/wZnh4S4p86DprZTxhUcl zOPbHSTzqSUEmPbhPox56XNKmPDlGenaudqA+5lUe6H3Fab1eZ2k9sbFeu0RvxdoP/kSdOQO LsfAsVWcLZEzV1qqaszVufTGUn2BPiNTpU5VZzNZdKKZNXG5dOEmXer6GmP0e3TibtboiEo6 lufp1Xk5NovDziUaLLw9l96pVmuUalWWUqPRKNPTdq3RZEQtFZyh79F50toI91xyj4EGcCLG BWQUguko8OCqxAXmUAp4C6Bz9z4CsfgKkPNym+Sv69ygb5YVsAug7rESgeVwPoq0jRMuQFE4 XIZCj2oFGYfJaPrzcUKcMw7QqZNNmOhPQc6HflxgAq5AId/9WZ2M6v3TY6TA82ASehIJA4EX wjIU6PwiFXgBjEevPgxhwlAc9uCotW9o9uE4WIyCk1bBI4Ol6EX3CC54EHxPos9tb4G4QCEK fnORIseh14N+qchL0JS3G4gNhwC60TFOiEUzQBOexj/rp6EhVyMm7haLmoM/pcLLCMpR80GF aNGiawOvcZHzUeBwAyau34Gh06NecAwkuP9LzP0vMfd/iZ0FuBcs4qy8qZrjNVaNkmdNvMNc ray0mHxg9iJT1t8CFx9uGgCQAnSMPJI0Va6QsLv5OtMAQBROL5APXo1K8iq2bi9ns+htDiPH D4CMaOCtePzCSkv0vs12vTo9W5WemanJymSiF7ZYvr9ntEwBq1k7V8txVs72tw+jZPEN4GZn 0d3iUHcgTMXuq9L9MsiaYwKbS8oiW3+MBjwH1r0rIbDs5wUtxZEPti39K5Z7YlqZ4fb2bd8Z j2OdzJE3qXIX5Rk3xF6he2fmPvasaj+Y5B9pScaeOsuXrY4NzWssKizYWhyuWKq7ZzduT+oZ Shj3W/J35M3US7ccfXo9P4EmeAOrTsFtPPsbd2vWzKcDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKLMWRmVeSWpSXmKPExsVy+t9jQd3Z259FGuy/Lmgx8cYVFotJ9yew WPQ/fs1scf78BnaLs01v2C02Pb7GanF51xw2i8+9RxgtZpzfx2TxfFMnq8XjFW/ZHbg9ds66 y+6xeM9LJo9NqzrZPDYvqffo27KK0ePzJrkAtigum5TUnMyy1CJ9uwSujH2XFrEVNApULJt1 g7GBcQpPFyMnh4SAicTC45tYuxi5OIQE1jFKXH6+jgkkwSsgKPFj8j2WLkYODmYBeYkjl7Ih THWJKVNyIcofMEpcbbnAAlGuJdF5bgsziM0ioCpxZNNpsDFsQPH9L26wgdj8AooSV388ZgSZ IyoQIdF9ohIkLCIgJfHy4ykmkJnMAtuYJaav/gPWKyzgKzFn33tGiGXzmCQefTgENohTIFji yK9VbBMYBWYhOXUWwqmzEE5dwMi8ilEytaA4Nz232KjAKC+1XK84Mbe4NC9dLzk/dxMjMDK2 Hdbq38H4eEn8IUYBDkYlHt4fis8ihVgTy4orcw8xSnAwK4nwHl8LFOJNSaysSi3Kjy8qzUkt PsQozcGiJM7Ln38sUkggPbEkNTs1tSC1CCbLxMEp1cBYyJu9RffUroAU5w1uWqUn8xZH39KI n26l5RzoIfSV10sqnMVIRbg6X3/JQiv25zG/3z1vPXyK9cxXhoJjHKe/dXf/tRFqcczhdr7O odCe+3KKBMt89pY9TDsKcmtN7QVrZ9QvK8/PXVyt+aHQ0m2DJVO50JkFwtkCvlOV+wU+RORN /KfMqcRSnJFoqMVcVJwIAHief8yIAgAA X-CMS-MailID: 20171018020827epcas2p2925cef1c93b70ecf4d116d658d2a91e9 X-Msg-Generator: CA X-Sender-IP: 182.195.42.143 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171013074837epcas1p49957bd030fc1a27cc845d63c50ad0aba X-RootMTR: 20171013074837epcas1p49957bd030fc1a27cc845d63c50ad0aba References: <1507880904-31956-1-git-send-email-cw00.choi@samsung.com> <1507880904-31956-9-git-send-email-cw00.choi@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2017년 10월 18일 00:11, MyungJoo Ham wrote: > On Fri, Oct 13, 2017 at 4:48 PM, Chanwoo Choi wrote: >> This patch registers the Exynos Bus-Frequency scaling device >> as a cooling device of thermal management. >> >> Signed-off-by: Chanwoo Choi >> Cc: Kukjin Kim >> Cc: Krzysztof Kozlowski >> Cc: linux-samsung-soc@vger.kernel.org >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org > > I've got a question below. > >> --- >> drivers/devfreq/exynos-bus.c | 27 +++++++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> >> diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c >> index c25658b26598..1c7521b65c2f 100644 > []> @@ -468,6 +471,19 @@ static int exynos_bus_probe(struct > platform_device *pdev) >> goto err; >> } >> >> + /* >> + * Register devfreq cooling device if thermal DT code >> + * takes care of matching them. >> + */ >> + if (of_find_property(np, "#cooling-cells", NULL)) { >> + bus->cdev = of_devfreq_cooling_register(np, bus->devfreq); >> + if (IS_ERR(bus->cdev)) { >> + dev_err(dev, "running exynos-bus without cooling device\n"); >> + bus->cdev = NULL; >> + } >> + } >> + of_node_put(np); > > Is this of_node_put() is a pair of of_find_property? or for something else? > (do you need to call put for of_find_property? or for something else? > I'm not seeing a function with "get") You're right. The of_node_put(np) call is unneeded. Actually, the extcon-bus.c have to use the of_node_get instead of accessing the 'dev->of_node' directly. And, when I test this patch, I got a bug related to passive governor. I need more time for debugging and redevelopment. So, I'll drop this patch on next patchset (v5). -- Best Regards, Chanwoo Choi Samsung Electronics