From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761526AbdJRHHL (ORCPT ); Wed, 18 Oct 2017 03:07:11 -0400 Received: from regular1.263xmail.com ([211.150.99.132]:42954 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761485AbdJRHHJ (ORCPT ); Wed, 18 Oct 2017 03:07:09 -0400 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: gregkh@linuxfoundation.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <7de3a3fc9c8936213236b4fa0e831a96> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <59E6FD8E.5040805@rock-chips.com> Date: Wed, 18 Oct 2017 15:06:54 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Greg Kroah-Hartman CC: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com, heiko@sntech.de, briannorris@chromium.org, rjw@rjwysocki.net, dianders@chromium.org, tfiga@chromium.org, broonie@kernel.org, seanpaul@chromium.org, thierry.reding@gmail.com Subject: Re: [PATCH] driver core: Make sure device detached from driver before deleting it References: <20171018054926.4756-1-jeffy.chen@rock-chips.com> <20171018061952.GA18857@kroah.com> In-Reply-To: <20171018061952.GA18857@kroah.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, Thanks for your reply. On 10/18/2017 02:19 PM, Greg Kroah-Hartman wrote: > On Wed, Oct 18, 2017 at 01:49:26PM +0800, Jeffy Chen wrote: >> >There are cases we call device_del() without detaching it from the >> >driver(e.g. spi core del children devices). > Why would you do that? Shouldn't that be fixed instead of this odd > work-around for a broken bus? > i was thinking since the device_unregister() is called everywhere, maybe there are some other drivers missing that too? and the driver calls device_add(), then the core attaches the device to the driver automatically, maybe it would make sense to let the core automatic detach it somehow... but i know nothing about driver core, maybe i should fix it in spi core, i'll send new patch for that :) > thanks, > > greg k-h > > >