From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759399AbdJRJoU (ORCPT ); Wed, 18 Oct 2017 05:44:20 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:13900 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753432AbdJRJoR (ORCPT ); Wed, 18 Oct 2017 05:44:17 -0400 X-AuditID: b6c32a46-acbff70000001153-62-59e7226f578a MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <59E72270.4030300@samsung.com> Date: Wed, 18 Oct 2017 18:44:16 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Marek Szyprowski , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: MyungJoo Ham , Lee Jones , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 1/2] extcon: max88743: Add OTG power control to the MUIC driver In-reply-to: <20171018092802.25390-2-m.szyprowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA01Sa0gUURTm7uzOjltbt83qYJHbUJSCmzOu61hZRhEL9sMwQZOwQW+r6e7a zGoPonajdDES2wjEJCOMUjTTTCofgY/e78jCyqggRQh6qkVSsztJ/fvO93333HM+DkOZPuoi mHyXh0gusZClDdr23ihbjJsdzowtG1ggtFQ164Q33/uR8PRaDS1UPezWCE19r/XCS995Opm2 vxropO0VbQ3I/rV1YSq1hazKI2IukczElePOzXc5ktiUtOx12fG2WC6GSxQSWLNLdJIkdv3G 1JgN+YXKv6y5RCwsVqhUUZbZ5atXSe5iDzHnuWVPEpvFcbyFi02w8DxvscZtXcHHK5ZtJK/p y7Cm6DbsLuu6rveiuvByFMYAtsKDy5V0OTIwJnwFwfvR7r/FOILmYwF6ynX3hl+rCh0IRoa6 NEHBiGfBxPEhRWAYCkdC35OCIE3hKLjc0awPYhMeQjA+slO1R8PwwY8oiLV4CQTOPQ71pxX+ +siLEJ6JF8GzifchzxycAVdrx0J9wrEEP73l+uAMFD6M4P4db0iYjdPB+2hQF8RheDX8HpzU BE2AO2m49/OIJjgc4PVwqNeiLjMbRm+26VU8Hz40tCDVX4bgUs2QVi38CN7U+3SqKw7ulPs0 6mozwN87qVebGsFfalItdpisufC36Vro+1WmV9PqRzD2+SxdiRZW/xdY9b/Aqv8L7DSiGtBc UiQ7HUTmi3iLLDrlYpfDkuN2tqLQqUVvuILqHmzsQZhB7HTjxKIPmSadWCLvcfYgYCg23Eh9 VihjrrhnL5Hc2VJxIZF7ULwS+DEqYk6OWzlclyebsybGWm02PsEmKBc2z7i/fSDDhB2ihxQQ UkSkqXcaJizCizbPS6vH99Mz0sa9ByXB/3xpSWB57YEXjv6xfbmfol2Rpype+S8O3hoLbFrm e3fCafB1Z1UZslLMz16OGshA5prMJ4knufDIQ99+lApkWed266nJ6W+5H9O2dxlLG+vsoytX orbzBYt35ifva996NO7RmR18IFAhnzhQadzVE1fXyGrlPJGLpiRZ/AM3FCvNgAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrALMWRmVeSWpSXmKPExsVy+t9jAd08peeRBjv/WVtsnLGe1eL+16OM Fpd3zWGzmHF+H5PF2iN32S1uN65gc2DzuHNtD5tH35ZVjB6fN8kFMEdx2aSk5mSWpRbp2yVw Zaz99Jyp4KRERfve/ewNjEtEuhg5OSQETCROH+tg6WLk4hAS2MkoMf3VelaQBK+AoMSPyfeA EhwczALyEkcuZYOEmQXUJSbNW8QMUf+AUeLDrZUsEPVaEs+b3jKC2CwCqhKTll9kA7HZgOL7 X9wAs/kFFCWu/njMCDJTVCBCovtEJUhYRKBI4sip9+wgM5kFWhkljt+8zwySEBYIlWi4cIsV YtlRRomtJycwgSQ4Bewk/t/6yzSBUWAWkltnIdw6C8mtCxiZVzFKphYU56bnFhsVGOWllusV J+YWl+al6yXn525iBIbztsNa/TsYHy+JP8QowMGoxMP7Q/FZpBBrYllxZe4hRgkOZiURXuaP QCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8/PnHIoUE0hNLUrNTUwtSi2CyTBycUg2MJfe3lu7Z sLKR3WyuUrPkZhWfNYvKzjUoZc9qF53L4Vnxw+tULM/+wOt8x+7NO+3c6nbB7/73r4FynNdr tZ4G1P1e9LZc/h5jcbbS+2P9j3YfOvLz9tOvaR62voz31Kc7MBkK/rAREZlpqG+7wqRy1589 JceOBh+98LlPeYOGhUrPzJtvfWoeKrEUZyQaajEXFScCAM9LKwdjAgAA X-CMS-MailID: 20171018094415epcas2p28859ada26f403f6f40db8384e6eedaca X-Msg-Generator: CA X-Sender-IP: 182.195.42.143 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171018092808eucas1p28a1a35b47d26687997798f68315d2a1f X-RootMTR: 20171018092808eucas1p28a1a35b47d26687997798f68315d2a1f References: <20171018092802.25390-1-m.szyprowski@samsung.com> <20171018092802.25390-2-m.szyprowski@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marek, Looks good to me. But, the patch subject is wrong as following: - max88743 -> max77843 If you fix the subject, feel free to add my acked-tag. Acked-by: Chanwoo Choi Regards, Chanwoo Choi On 2017년 10월 18일 18:28, Marek Szyprowski wrote: > Enabling power on VBUS micro-usb pin is required only when passive OTG > cable is connected. Initially OTG VBUS power control was planned to be > done in charger driver. However such information is not really available > from the extcon notifications, so VBUS power control has to be done > directly in MUIC driver, which has all information about the attached > accessory. > > For example SmartDock is externally powered accessory, provides OTG > (USB HOST) functionality and use VBUS pin for charging a device battery, > so the VBUS charging pump should be disabled in such case. > > Signed-off-by: Marek Szyprowski > --- > drivers/extcon/extcon-max77843.c | 16 ++++++++++++++++ > include/linux/mfd/max77843-private.h | 3 +++ > 2 files changed, 19 insertions(+) > > diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c > index 6e722d552cf1..217c743405f8 100644 > --- a/drivers/extcon/extcon-max77843.c > +++ b/drivers/extcon/extcon-max77843.c > @@ -240,6 +240,21 @@ static int max77843_muic_set_path(struct max77843_muic_info *info, > return 0; > } > > +static void max77843_charger_set_otg_vbus(struct max77843_muic_info *info, > + bool on) > +{ > + struct max77693_dev *max77843 = info->max77843; > + unsigned int cnfg00; > + > + if (on) > + cnfg00 = MAX77843_CHG_OTG_MASK | MAX77843_CHG_BOOST_MASK; > + else > + cnfg00 = MAX77843_CHG_ENABLE | MAX77843_CHG_BUCK_MASK; > + > + regmap_update_bits(max77843->regmap_chg, MAX77843_CHG_REG_CHG_CNFG_00, > + MAX77843_CHG_MODE_MASK, cnfg00); > +} > + > static int max77843_muic_get_cable_type(struct max77843_muic_info *info, > enum max77843_muic_cable_group group, bool *attached) > { > @@ -355,6 +370,7 @@ static int max77843_muic_adc_gnd_handler(struct max77843_muic_info *info) > return ret; > > extcon_set_state_sync(info->edev, EXTCON_USB_HOST, attached); > + max77843_charger_set_otg_vbus(info, attached); > break; > case MAX77843_MUIC_GND_MHL_VB: > case MAX77843_MUIC_GND_MHL: > diff --git a/include/linux/mfd/max77843-private.h b/include/linux/mfd/max77843-private.h > index c19303b0ccfd..0223cd5941c8 100644 > --- a/include/linux/mfd/max77843-private.h > +++ b/include/linux/mfd/max77843-private.h > @@ -245,10 +245,13 @@ enum max77843_irq_muic { > #define MAX77843_CHG_OVER_CURRENT_BAT (0x06 << 4) > > /* MAX77843 CHG_CNFG_00 register */ > +#define MAX77843_CHG_MODE_MASK 0x0f > #define MAX77843_CHG_DISABLE 0x00 > #define MAX77843_CHG_ENABLE 0x05 > #define MAX77843_CHG_MASK 0x01 > +#define MAX77843_CHG_OTG_MASK 0x02 > #define MAX77843_CHG_BUCK_MASK 0x04 > +#define MAX77843_CHG_BOOST_MASK 0x08 > > /* MAX77843 CHG_CNFG_01 register */ > #define MAX77843_CHG_RESTART_THRESHOLD_100 0x00 >