From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752130AbdJRLLQ (ORCPT <rfc822;w@1wt.eu>);
        Wed, 18 Oct 2017 07:11:16 -0400
Received: from regular1.263xmail.com ([211.150.99.131]:36527 "EHLO
        regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751969AbdJRLLP (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 18 Oct 2017 07:11:15 -0400
X-263anti-spam: KSV:0;BIG:0;
X-MAIL-GRAY: 0
X-MAIL-DELIVERY: 1
X-KSVirus-check: 0
X-ADDR-CHECKED4: 1
X-ABS-CHECKED: 1
X-SKE-CHECKED: 1
X-ANTISPAM-LEVEL: 2
X-RL-SENDER: jeffy.chen@rock-chips.com
X-FST-TO: rjw@rjwysocki.net
X-SENDER-IP: 103.29.142.67
X-LOGIN-NAME: jeffy.chen@rock-chips.com
X-UNIQUE-TAG: <5a42f3f0120c63f1b30e0f9b968445f0>
X-ATTACHMENT-NUM: 0
X-DNS-TYPE: 0
Message-ID: <59E736C8.3080002@rock-chips.com>
Date: Wed, 18 Oct 2017 19:11:04 +0800
From: jeffy <jeffy.chen@rock-chips.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0
MIME-Version: 1.0
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
CC: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com,
        heiko@sntech.de, briannorris@chromium.org, dianders@chromium.org,
        tfiga@chromium.org, broonie@kernel.org, seanpaul@chromium.org,
        thierry.reding@gmail.com,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] driver core: Make sure device detached from driver before
 deleting it
References: <20171018054926.4756-1-jeffy.chen@rock-chips.com> <1742035.QldI8RN9SY@aspire.rjw.lan>
In-Reply-To: <1742035.QldI8RN9SY@aspire.rjw.lan>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rafael,

Thanks for your reply.

On 10/18/2017 06:04 PM, Rafael J. Wysocki wrote:
> But device_del() calls bus_remove_device() which in turn calls
> device_release_driver(), so this looks like an ordering issue to me.
>
uh, right, didn't notice that, it indeed to be a ordering issue...

it turns out in device_del() we are calling device_links_purge() before 
bus_remove_device()...

> What*exactly*  is not working?  Or rather, what symptoms do you see?
>
my board has these devices:
spi master device->spi child device->spi based pwm->pwm_bl

and i add a device link to the pwm and pwm_bl, and got a warning about 
the pwm not unbound:

static void device_links_purge(struct device *dev)
{
...
         list_for_each_entry_safe_reverse(link, ln, 
&dev->links.consumers, s_node) {
                 WARN_ON(link->status != DL_STATE_DORMANT &&
                         link->status != DL_STATE_NONE); <-- warning here!
                 __device_link_del(link);
         }


and i was confused by:
static void mac80211_hwsim_del_radio(struct mac80211_hwsim_data *data,
                                      const char *hwname,
                                      struct genl_info *info)
{
...
         device_release_driver(data->dev);
         device_unregister(data->dev);

and adding that device_release_driver hide that issue(oops...)


so we should move device_links_purge() after bus_remove_device() in 
device_del() right? maybe after device_remove_properties(), and that did 
solve the issue :)


> Thanks,
> Rafael