From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754061AbdJRLcY (ORCPT ); Wed, 18 Oct 2017 07:32:24 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:52289 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753817AbdJRLcX (ORCPT ); Wed, 18 Oct 2017 07:32:23 -0400 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: rjw@rjwysocki.net X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <483d1b3aca24a7e79298376580600515> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <59E73BBF.5090609@rock-chips.com> Date: Wed, 18 Oct 2017 19:32:15 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: "Rafael J. Wysocki" CC: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com, heiko@sntech.de, briannorris@chromium.org, dianders@chromium.org, tfiga@chromium.org, broonie@kernel.org, seanpaul@chromium.org, thierry.reding@gmail.com, Greg Kroah-Hartman Subject: Re: [PATCH] driver core: Make sure device detached from driver before deleting it References: <20171018054926.4756-1-jeffy.chen@rock-chips.com> <1742035.QldI8RN9SY@aspire.rjw.lan> <59E736C8.3080002@rock-chips.com> In-Reply-To: <59E736C8.3080002@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rafael, On 10/18/2017 07:11 PM, jeffy wrote: >> > my board has these devices: > spi master device->spi child device->spi based pwm->pwm_bl > > and i add a device link to the pwm and pwm_bl, and got a warning about > the pwm not unbound: sorry, it happens when i try to unbind the spi child device, and it's warning about the consumer(pwm_bl) not unbound. > > static void device_links_purge(struct device *dev) > { > ... > list_for_each_entry_safe_reverse(link, ln, > &dev->links.consumers, s_node) { > WARN_ON(link->status != DL_STATE_DORMANT && > link->status != DL_STATE_NONE); <-- warning here! > __device_link_del(link); > } and i've send a new patch to reorder the device_links_purge() and bus_remove_device, thanks again :)