From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751485AbdJSByz (ORCPT ); Wed, 18 Oct 2017 21:54:55 -0400 Received: from regular1.263xmail.com ([211.150.99.133]:39767 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbdJSByy (ORCPT ); Wed, 18 Oct 2017 21:54:54 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: seanpaul@chromium.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <1ca4dbbf2d5c9d2dd7043ce8e392a1a6> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <59E805E0.50006@rock-chips.com> Date: Thu, 19 Oct 2017 09:54:40 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Sean Paul CC: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com, heiko@sntech.de, briannorris@chromium.org, rjw@rjwysocki.net, dianders@chromium.org, tfiga@chromium.org, broonie@kernel.org, Mark Yao , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, David Airlie , linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH v4 4/8] drm/rockchip: dw_hdmi: Fix error handling path References: <20171017101624.12506-1-jeffy.chen@rock-chips.com> <20171017101624.12506-5-jeffy.chen@rock-chips.com> <20171017181034.tsplfsmq7vi4uhmo@art_vandelay> In-Reply-To: <20171017181034.tsplfsmq7vi4uhmo@art_vandelay> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sean, Thanks for your review. On 10/18/2017 02:10 AM, Sean Paul wrote: > On Tue, Oct 17, 2017 at 06:16:20PM +0800, Jeffy Chen wrote: >> >Add missing clk_disable_unprepare() in bind()'s error handling path. > This also isn't disabled in unbind(), is that intentional? > i wasn't able to do that because of dw_hdmi drvdata. i've modified it as tomasz did for dp bridge, and fixed the unbind() in the next version :)