From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751052AbdJSEzF (ORCPT ); Thu, 19 Oct 2017 00:55:05 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:17889 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750905AbdJSEzC (ORCPT ); Thu, 19 Oct 2017 00:55:02 -0400 X-AuditID: b6c32a36-c09ff70000018158-51-59e830229592 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="utf-8" Message-id: <59E83023.4010300@samsung.com> Date: Thu, 19 Oct 2017 13:54:59 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Raveendra Padasalagi , MyungJoo Ham , Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH v2 1/2] Documentation: dt: extcon: add optional debounce-timeout-ms attribute In-reply-to: <59E82E7C.8040404@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLKsWRmVeSWpSXmKPExsWy7bCmga6SwYtIgz3LNSzW9h5lsZh/5Byr xeVdc9gsll6/yGRxu3EFm8W39kesFq17j7A7sHusmbeG0WPW/bNsHptWdbJ59G1ZxejxeZNc AGtUqk1GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO0BlK CmWJOaVAoYDE4mIlfTubovzSklSFjPziElulaENDIz1DA3M9IyMjPRPjWCsjU6CShNSMvVeu sxRM5a+Yv3caUwPjLZ4uRk4OCQETifXzXjB1MXJxCAnsYJTY2feaFcL5zihx4P5edpiqjvY1 7BCJ3YwS07/uZgFJ8AoISvyYfA/I5uBgFpCXOHIpGyTMLKAp8eLLJBaI+nuMErd33mKHqNeS 6HtykRXEZhFQldj6/BojiM0GFN//4gYbiM0voChx9cdjsLioQITEzvnfwBaLCLxhlHj5op0V ZsPvea1gQ4UFkiWe37nDBGJzCmhLrLt1mBmkQULgDJvEyjmdLBAvuEic6b0L9Y6wxKvjW9hB rpYQkJa4dNQWor6dUWLznHssEE4Ho8T9lY2sEA3GEqe6GpkgNvNJvPvawwrRzCvR0SYEUeIh 8btrEiOE7Sixq3sFNByPMUpce7+XaQKj3CykEJuFCLFZSCG2gJF5FaNYakFxbnpqsWGBkV5x Ym5xaV66XnJ+7iZGcNLTMtvBuOiczyFGAQ5GJR7eBdOeRwqxJpYVV+YeYpTgYFYS4b2t9SJS iDclsbIqtSg/vqg0J7X4EKMpMMAnMkuJJucDE3JeSbyhiaWBiZkRMIFZGhoqifOKrr8WISSQ nliSmp2aWpBaBNPHxMEp1cBoevLjD4FdV+7UnKqX33z31/XJij3bbQX/u69bvzdxymH3/Cuc 3x2X2ltbHtQ/lTBP2CouJXLi5hO6l70Y5CbqXn1yV347V2hGcKLFrymxrr9zwjwueH/+083w s5MtQvNHODOnJFdmuMU80Tt1txNXhAv931l3wH/CjiI36w8u3m8v9VQsUmJSYinOSDTUYi4q TgQA5OFGhpADAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLLMWRmVeSWpSXmKPExsVy+t9jAV0lgxeRBvd2c1is7T3KYjH/yDlW i8u75rBZLL1+kcniduMKNotv7Y9YLVr3HmF3YPdYM28No8es+2fZPDat6mTz6NuyitHj8ya5 ANYoLpuU1JzMstQifbsEroy9V66zFEzlr5i/dxpTA+Mtni5GTg4JAROJjvY17F2MXBxCAjsZ Je7ve8UMkuAVEJT4MfkeSxcjBwezgLzEkUvZEKa6xJQpuRDlDxgllp36wgpRriXR9+QimM0i oCqx9fk1RhCbDSi+/8UNNhCbX0BR4uqPx4wgc0QFIiS6T1SCzBEReMMocWjdCrAaZgFNid/z WtlBbGGBZInnd+4wQSw7wSix/tdPsASngLbEuluHmScwCsxCcuoshFNnIZy6gJF5FaNkakFx bnpusVGBYV5quV5xYm5xaV66XnJ+7iZGYKBvO6zVt4Px/pL4Q4wCHIxKPLweU55HCrEmlhVX 5h5ilOBgVhLhva31IlKINyWxsiq1KD++qDQntfgQozQHi5I47+28Y5FCAumJJanZqakFqUUw WSYOTqkGRpc9azVL6m7Z7rto/vfIxvNBm9yN//RUu+/U1bg4tyfqnNRuQ+sFOw477HOJVPz5 RfKi1bqC/PbQ7wcut31Ydk598ollaWWdz9luix1ftWxb/MLLyZdsnbucxFt1+3hri95M5289 bafx2qdZz/g4V/l6uQSNo849lz5PjjtlvCGq3nxmp2ublxJLcUaioRZzUXEiAPo5L9NwAgAA X-CMS-MailID: 20171019045458epcas1p31661893f51c984779cea85cc48f7f2aa X-Msg-Generator: CA X-Sender-IP: 182.195.42.142 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171019032612epcas5p40f27200408a554d4942802b986503636 X-RootMTR: 20171019032612epcas5p40f27200408a554d4942802b986503636 References: <1508383560-15567-1-git-send-email-raveendra.padasalagi@broadcom.com> <59E82E7C.8040404@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2017년 10월 19일 13:47, Chanwoo Choi wrote: > On 2017년 10월 19일 12:25, Raveendra Padasalagi wrote: >> Add documentation on optional dt attribute "debounce-timeout-ms" >> in extcon node to capture user specified timeout value for id >> and vbus gpio detection. >> >> Signed-off-by: Raveendra Padasalagi >> Reviewed-by: Ray Jui >> Reviewed-by: Srinath Mannam >> --- >> >> Changes in v2: >> Rename debounce-timeout-ms to input-debounce >> >> Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt >> index dfc14f7..d115900 100644 >> --- a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt >> +++ b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt >> @@ -10,6 +10,9 @@ Either one of id-gpio or vbus-gpio must be present. Both can be present as well. >> - id-gpio: gpio for USB ID pin. See gpio binding. >> - vbus-gpio: gpio for USB VBUS pin. >> >> +Optional properties: >> +- input-debounce: debounce timeout value for id and vbus gpio in microseconds. > > The pinctrl-bindings.txt[1] specify the unit of 'input-debounce'. > The unit is usec instead of 'microsecond'. You need to modify the description of unit. > [1] Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt Sorry. My mistake. I confused the 'nsec' with 'usec'. This patch is right. Please ignore my comment. > >> + >> Example: Examples of extcon-usb-gpio node in dra7-evm.dts as listed below: >> extcon_usb1 { >> compatible = "linux,extcon-usb-gpio"; >> > > Looks good to me. Reviewed-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics