From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751217AbdJSE7O (ORCPT ); Thu, 19 Oct 2017 00:59:14 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:61893 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750977AbdJSE7M (ORCPT ); Thu, 19 Oct 2017 00:59:12 -0400 X-AuditID: b6c32a48-c0fff70000001005-32-59e8311ea10f MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <59E8311F.5010103@samsung.com> Date: Thu, 19 Oct 2017 13:59:11 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Raveendra Padasalagi , MyungJoo Ham , Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH v2 2/2] extcon: add optional debounce-timeout-ms attribute In-reply-to: <1508383560-15567-2-git-send-email-raveendra.padasalagi@broadcom.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLKsWRmVeSWpSXmKPExsWy7bCmma6c4YtIgyt32CzW9h5lsZh/5Byr xeVdc9gsll6/yGRxu3EFm8W39kesFq17j7A7sHusmbeG0WPW/bNsHptWdbJ59G1ZxejxeZNc AGtUqk1GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO0BlK CmWJOaVAoYDE4mIlfTubovzSklSFjPziElulaENDIz1DA3M9IyMjPRPjWCsjU6CShNSMb69P MhZ8Fal4tP0OSwPjf4EuRk4OCQETiUWvj7B1MXJxCAnsYJTom7iVBSQhJPCdUeLATQuYook/ F7JDFG1glLjT8ZsNJMErICjxY/I9oAYODmYBeYkjl7JBwswCmhJbd6+Hqr/HKNHwahsjRL2W xLt/rWALWARUJVa+/8gEYrMBxfe/uAE2k19AUeLqj8dg9aICERI7538DGyQi8IZR4uWLdlaY Db/ntbKD2MICARLv7j0EszkFQiRWXzjPCtIgIXCZTeLhnc+sEC+4SJzYMpsFwhaWeHV8CzuE LS3xbNVGRoiGdkaJzXNA3gFxOhgl7q9shOo2ljjV1cgEsZpPouPwX3aQnyUEeCU62oQgSjwk dk/phSp3lHj+rIMV4v+3jBL/fkxjm8AoNwspyGYhgmwWUpAtYGRexSiWWlCcm55abFRgolec mFtcmpeul5yfu4kRnPS0PHYwHjjnc4hRgINRiYd3wbTnkUKsiWXFlbmHGCU4mJVEeG9rvYgU 4k1JrKxKLcqPLyrNSS0+xGgKDPGJzFKiyfnAhJxXEm9oYmlgYmZmZG5mAUxi4rx1265FCAmk J5akZqemFqQWwfQxcXBKNTB2Ma878/2SUI3HnjkMnqKnzt/eEH73U7O8GnO9glvUHtdbMXdu T3zfMHVTlcyjkJtf1q2/sS67Wtri9+Nmtr3zu3f92MW8r0P7RkdmdP/bo9fvTci9yN69bebO ygWbrpk8OZkqsVa095S+6PaK5q9R1+bWMLEeDn24c+v5UPUgxdZq6ak/p4enK7EUZyQaajEX FScCAC+jF6mQAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHLMWRmVeSWpSXmKPExsVy+t9jQV1ZwxeRBr//GVms7T3KYjH/yDlW i8u75rBZLL1+kcniduMKNotv7Y9YLVr3HmF3YPdYM28No8es+2fZPDat6mTz6NuyitHj8ya5 ANYoLpuU1JzMstQifbsEroxvr08yFnwVqXi0/Q5LA+N/gS5GTg4JAROJiT8XsncxcnEICaxj lNjw+ikTSIJXQFDix+R7LF2MHBzMAvISRy5lg4SZBdQlJs1bxAxiCwk8YJR4sIUdolxL4t2/ VhYQm0VAVWLl+49gY9iA4vtf3GADsfkFFCWu/njMCDJSVCBCovtEJchaEYE3jBKH1q1gg5iv KfF7XivYTGEBP4lr11oZIW57zyjRP70DrIhTIETiyKtFzBMYBWYhOXUWwqmzkJy6gJF5FaNk akFxbnpusVGBUV5quV5xYm5xaV66XnJ+7iZGYKhvO6zVv4Px8ZL4Q4wCHIxKPLweU55HCrEm lhVX5h5ilOBgVhLhva31IlKINyWxsiq1KD++qDQntfgQozQHi5I4L3/+sUghgfTEktTs1NSC 1CKYLBMHp1QDo8wPkVaXLeo7zJW546vWurIv8OD/f21paLrUJsECefeYiHRp6ZmZXU9j/tio isnP8pvnmmZ/7X5z4I3oBq78M62zZjgHXNz8VSj9m8vUA/tSt793vm/SO3dq3PWEz08mr205 Z8GirPF3roote9bDwo2NAe9/nMi2umUjvz76hkJnbMeXlsqDSizFGYmGWsxFxYkAsYxekXEC AAA= X-CMS-MailID: 20171019045909epcas2p3871341cfce0d443d73e8b62cd78019d4 X-Msg-Generator: CA X-Sender-IP: 182.195.42.143 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171019032619epcas2p2408b6d42002c826d2af71f619250c0cf X-RootMTR: 20171019032619epcas2p2408b6d42002c826d2af71f619250c0cf References: <1508383560-15567-1-git-send-email-raveendra.padasalagi@broadcom.com> <1508383560-15567-2-git-send-email-raveendra.padasalagi@broadcom.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2017년 10월 19일 12:26, Raveendra Padasalagi wrote: > Add changes to capture optional dt attribute "debounce-timeout-ms" > provided in extcon node and used the same value if provided otherwise > default value of 20ms is used for id and vbus gpios debounce time. > > Signed-off-by: Raveendra Padasalagi > Reviewed-by: Ray Jui > Reviewed-by: Srinath Mannam > --- > > Changes in v2: > Rename gpio_debounce_timeout_ms to debounce_usecs > > drivers/extcon/extcon-usb-gpio.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c > index 9c925b0..76ef1da 100644 > --- a/drivers/extcon/extcon-usb-gpio.c > +++ b/drivers/extcon/extcon-usb-gpio.c > @@ -41,6 +41,7 @@ struct usb_extcon_info { > > unsigned long debounce_jiffies; > struct delayed_work wq_detcable; > + unsigned int debounce_usecs; > }; > > static const unsigned int usb_extcon_cable[] = { > @@ -133,6 +134,11 @@ static int usb_extcon_probe(struct platform_device *pdev) > if (IS_ERR(info->vbus_gpiod)) > return PTR_ERR(info->vbus_gpiod); > > + ret = of_property_read_u32(np, "input-debounce", > + &info->debounce_usecs); > + if (ret) > + info->debounce_usecs = USB_GPIO_DEBOUNCE_MS; The USB_GPIO_DEBOUNCE_MS indicates 20 millisecond. You need to redefine it as following: -#define USB_GPIO_DEBOUNCE_MS 20 /* ms */ +#define USB_GPIO_DEBOUNCE_USEC 20000 info->debounce_usecs = USB_GPIO_DEBOUNCE_USEC; or info->debounce_usecs = USB_GPIO_DEBOUNCE_MS * 1000; > + > info->edev = devm_extcon_dev_allocate(dev, usb_extcon_cable); > if (IS_ERR(info->edev)) { > dev_err(dev, "failed to allocate extcon device\n"); > @@ -147,13 +153,13 @@ static int usb_extcon_probe(struct platform_device *pdev) > > if (info->id_gpiod) > ret = gpiod_set_debounce(info->id_gpiod, > - USB_GPIO_DEBOUNCE_MS * 1000); > + info->debounce_usecs * 1000); The debounce_usecs is already microsecond, You don't need to mutiply with 1000. > if (!ret && info->vbus_gpiod) > ret = gpiod_set_debounce(info->vbus_gpiod, > - USB_GPIO_DEBOUNCE_MS * 1000); > + info->debounce_usecs * 1000); > > if (ret < 0) > - info->debounce_jiffies = msecs_to_jiffies(USB_GPIO_DEBOUNCE_MS); > + info->debounce_jiffies = msecs_to_jiffies(info->debounce_usecs); ditto. > > INIT_DELAYED_WORK(&info->wq_detcable, usb_extcon_detect_cable); > > -- Best Regards, Chanwoo Choi Samsung Electronics