From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751468AbdJSFWm (ORCPT ); Thu, 19 Oct 2017 01:22:42 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:20387 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750899AbdJSFWk (ORCPT ); Thu, 19 Oct 2017 01:22:40 -0400 X-AuditID: b6c32a36-c21ff70000018158-cb-59e83688ba46 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="utf-8" Message-id: <59E8368A.8000600@samsung.com> Date: Thu, 19 Oct 2017 14:22:18 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Raveendra Padasalagi , MyungJoo Ham , Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH v2 2/2] extcon: add optional debounce-timeout-ms attribute In-reply-to: <59E8311F.5010103@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLKsWRmVeSWpSXmKPExsWy7bCmrm6H2YtIgxuvrS3W9h5lsZh/5Byr xeVdc9gsll6/yGRxu3EFm8W39kesFq17j7A7sHusmbeG0WPW/bNsHptWdbJ59G1ZxejxeZNc AGtUqk1GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO0BlK CmWJOaVAoYDE4mIlfTubovzSklSFjPziElulaENDIz1DA3M9IyMjPRPjWCsjU6CShNSM1T1v 2AsWiVVM33GeuYFxilAXIyeHhICJxLmTq9m7GLk4hAR2MEr87bvLCOF8Z5T4cGsHG0zVpLlP mCASuxklNp4+wwiS4BUQlPgx+R5LFyMHB7OAvMSRS9kgYWYBTYkXXyaxQNTfY5RY1n+KDaJe S+LapnfMIDaLgKrE8wMPweJsQPH9L26A2fwCihJXfzwGmy8qECGxc/43sPNEBN4wSrx80c4K s+H3vFZ2EFtYIEDi3b2HYDangLbE4Z4ZYJslBM6wSby784cd4gUXif+HmqBsYYlXx7ewg1wt ISAtcemoLUR9O6PE5jn3oJo7GCXur2xkhWgwljjV1cgEsZlP4t3XHlaIZl6JjjZoQHpI7J7S C1XuKPH8WQcrxPt9TBKT901inMAoNwspxGYhQmwWUogtYGRexSiWWlCcm55abFhgpFecmFtc mpeul5yfu4kRnPS0zHYwLjrnc4hRgINRiYd3wbTnkUKsiWXFlbmHGCU4mJVEeG9rvYgU4k1J rKxKLcqPLyrNSS0+xGgKDPCJzFKiyfnAhJxXEm9oYmlgYmYETGCWhoZK4ryi669FCAmkJ5ak ZqemFqQWwfQxcXBKNTD6c5TIPd3MspfL0vK/2pxJM4XLr60R9t98bW3nyRPFMsw7f9lX6B6Y LvHYW8TrukDgvRXsMgtu3/Dt+tpzvm3FzCscTS88jj6LV/3ml5BhdV5N74dP+g/ba+XJYVtD n3Gp/LnvHLEncGJ1PNPsA3LSViVyenXqCd/kV2gIKcw0Ztmgcm9N1H0lluKMREMt5qLiRABL Y0gdkAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLLMWRmVeSWpSXmKPExsVy+t9jAd0OsxeRBpPa5C3W9h5lsZh/5Byr xeVdc9gsll6/yGRxu3EFm8W39kesFq17j7A7sHusmbeG0WPW/bNsHptWdbJ59G1ZxejxeZNc AGsUl01Kak5mWWqRvl0CV8bqnjfsBYvEKqbvOM/cwDhFqIuRk0NCwERi0twnTF2MXBxCAjsZ JfrmbWUBSfAKCEr8mHwPyObgYBaQlzhyKRvCVJeYMiUXovwBo8SHHTfZIMq1JK5tescMYrMI qEo8P/AQLM4GFN//4gaYzS+gKHH1x2NGkDmiAhES3ScqQeaICLxhlDi0bgVYDbOApsTvea3s ILawgJ/EtWutjBDLJjBJTD2+mgkkwSmgLXG4ZwbLBEaBWUhOnYVw6iyEUxcwMq9ilEwtKM5N zy02KjDMSy3XK07MLS7NS9dLzs/dxAgM9G2Htfp2MN5fEn+IUYCDUYmH12PK80gh1sSy4src Q4wSHMxKIry3tV5ECvGmJFZWpRblxxeV5qQWH2KU5mBREue9nXcsUkggPbEkNTs1tSC1CCbL xMEp1cDIG701a37jTdsfsxpXC5d8L7bg9FhndOpLfO38n9NX2yy4aO+qOfcWt79FZ/rF+H6r i9efOWVXLFi5eO+B431N6h2GKfaPV7Q25QmITxfZJ299auY5v6wtZz7sbhI1ZJmoqLrlZ/wv uVOzXZ7flOI83L6/d8avp6+07a5ptGZq+a0V/SAZEvlfiaU4I9FQi7moOBEA3A+8mXACAAA= X-CMS-MailID: 20171019052216epcas1p4a705684378291e5d796d6fd9780e3137 X-Msg-Generator: CA X-Sender-IP: 182.195.42.142 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171019032619epcas2p2408b6d42002c826d2af71f619250c0cf X-RootMTR: 20171019032619epcas2p2408b6d42002c826d2af71f619250c0cf References: <1508383560-15567-1-git-send-email-raveendra.padasalagi@broadcom.com> <1508383560-15567-2-git-send-email-raveendra.padasalagi@broadcom.com> <59E8311F.5010103@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017년 10월 19일 13:59, Chanwoo Choi wrote: > Hi, > > On 2017년 10월 19일 12:26, Raveendra Padasalagi wrote: >> Add changes to capture optional dt attribute "debounce-timeout-ms" >> provided in extcon node and used the same value if provided otherwise >> default value of 20ms is used for id and vbus gpios debounce time. >> >> Signed-off-by: Raveendra Padasalagi >> Reviewed-by: Ray Jui >> Reviewed-by: Srinath Mannam >> --- >> >> Changes in v2: >> Rename gpio_debounce_timeout_ms to debounce_usecs >> >> drivers/extcon/extcon-usb-gpio.c | 12 +++++++++--- >> 1 file changed, 9 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c >> index 9c925b0..76ef1da 100644 >> --- a/drivers/extcon/extcon-usb-gpio.c >> +++ b/drivers/extcon/extcon-usb-gpio.c >> @@ -41,6 +41,7 @@ struct usb_extcon_info { >> >> unsigned long debounce_jiffies; >> struct delayed_work wq_detcable; >> + unsigned int debounce_usecs; >> }; >> >> static const unsigned int usb_extcon_cable[] = { >> @@ -133,6 +134,11 @@ static int usb_extcon_probe(struct platform_device *pdev) >> if (IS_ERR(info->vbus_gpiod)) >> return PTR_ERR(info->vbus_gpiod); >> >> + ret = of_property_read_u32(np, "input-debounce", >> + &info->debounce_usecs); >> + if (ret) >> + info->debounce_usecs = USB_GPIO_DEBOUNCE_MS; > > The USB_GPIO_DEBOUNCE_MS indicates 20 millisecond. > You need to redefine it as following: > -#define USB_GPIO_DEBOUNCE_MS 20 /* ms */ > +#define USB_GPIO_DEBOUNCE_USEC 20000 > > info->debounce_usecs = USB_GPIO_DEBOUNCE_USEC; > > or > info->debounce_usecs = USB_GPIO_DEBOUNCE_MS * 1000; > > >> + >> info->edev = devm_extcon_dev_allocate(dev, usb_extcon_cable); >> if (IS_ERR(info->edev)) { >> dev_err(dev, "failed to allocate extcon device\n"); >> @@ -147,13 +153,13 @@ static int usb_extcon_probe(struct platform_device *pdev) >> >> if (info->id_gpiod) >> ret = gpiod_set_debounce(info->id_gpiod, >> - USB_GPIO_DEBOUNCE_MS * 1000); >> + info->debounce_usecs * 1000); > > The debounce_usecs is already microsecond, You don't need to mutiply with 1000. > > >> if (!ret && info->vbus_gpiod) >> ret = gpiod_set_debounce(info->vbus_gpiod, >> - USB_GPIO_DEBOUNCE_MS * 1000); >> + info->debounce_usecs * 1000); You don't need to mutiply with 1000. >> >> if (ret < 0) >> - info->debounce_jiffies = msecs_to_jiffies(USB_GPIO_DEBOUNCE_MS); >> + info->debounce_jiffies = msecs_to_jiffies(info->debounce_usecs); You should you the 'usecs_to_jiffies' because info->debounce_usecs indicates the usec. -- Best Regards, Chanwoo Choi Samsung Electronics