From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751282AbdJWFb7 (ORCPT ); Mon, 23 Oct 2017 01:31:59 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:22614 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750746AbdJWFbz (ORCPT ); Mon, 23 Oct 2017 01:31:55 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20171023053153epoutp021dea4570cc8d117529ee73ec5860e2f9~wHAwGbNLw1349913499epoutp02F X-AuditID: b6c32a48-8edff7000000103e-92-59ed7ec896d7 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="utf-8" Message-id: <59ED7EC7.3030204@samsung.com> Date: Mon, 23 Oct 2017 14:31:51 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Kishon Vijay Abraham I , balbi@kernel.org, sre@kernel.org, lee.jones@linaro.org, heiko@sntech.de, yoshihiro.shimoda.uh@renesas.com, maxime.ripard@free-electrons.com, wens@csie.org Cc: gregkh@linuxfoundation.org, krzk@kernel.org, b.zolnierkie@samsung.com, chanwoo@kernel.org, myungjoo.ham@samsung.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2] extcon: Split out extcon header file for consumer and provider device In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA02Tf0wTZxjHfe/au0Pt9lpU3mAi3UWzFEftlVJeUcwWnTsVkybbH+q21Auc QKTXpteSYQyzWaaFzCnbkgHiNLooMhex8sshw5RfmyKIzKZBAw5/RAeYzIri1Ogdh5n/ffN9 P8/7vM83z8uQxkEqmSmU/KJPEopYarauqcOM0/4ondhiHe96F5+pPK3H3Xtu07gi9pcOf3Xs NIVfjo7p8ZU731C4v7+exiOTXQCHb0X1ePC3GgrH93UC3Hj/AYEf3nxJ4qPHvyZxY7iNxNeD tRS+1OrHTyP9BJ5si1PvJ/L1o7/o+dvhAcCH68oo/kb0PMW3HzpF82d//pJ/3Fuh479tqAN8 c/Qnku+JNRN8PLzYOWeruKpAFPJEn0mUcj15hVJ+NrvxY9caV4bDyqVxK3Ama5IEt5jNrs1x pq0rLFLGY03FQlFAsZyCLLPLV6/yeQJ+0VTgkf3Z7KccZ7Nw1kyLzWaz2NM/z7JlKMg2sWCo 6hDtbVj5xf7/QmA3GHqvHCQwCNrRWN81qhzMZoywBaDJ2H5CPTDCJwANNm16Dd24eAJoUCtA XfExnXpggPPQ1PfDimYYEqagzqs7VJuEZnTv0Xc6jR8G6MTdMND4VFTZ1kqovA4uRXtrP1Ft SrHb78UoVb8N30HXpm5N4wvgZnTu8GNavWc+7AWoo2KC0hq0E6j2FFJ1InShO/tqp9+TALPQ wWhsujGCV2l0/lmE1iZYi5qe/0hoOhH909Mw4y9Cd+vOAK1gL0Bna4ZnqkMAjZwM6jUqHV0s DxJa67dQqOMFrY6AoAGF9hg1yaMHU4xGf4C6ztXMRFpGoOjAQf0BsLj6jcCq/w+s+o3AjgCy DiwUvbI7X5RtXrtFFtxyQMq35HrcYTC90Kl8C7jQlxMBkAHsXMMsbmKLUS8UyyXuCEAMyc43 1GDFMuQJJTtFn8flCxSJcgRkKHlXkMkLcj3K95D8Ls6+wmp3OGyZDqwsWJKhtCm62QjzBb+4 QxS9ou91HcEkJO8GpR+Glzzp2VXfZ9uaXTlMOi4Ec1b/sH0gMF55Re9s/Myz8tf1c4v/NHOG EfMGPqWze9zVm3t/XUlS1bFt5o86pHk0jo4uWzhY9nvV4TUjQwK7pN9p3LUcWpelezc661ua 8d8JKXQWvQilzjJdSgpePhDaLsGdbd6+qnj55X+7faxOLhC4VNInC68As7J/leYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMIsWRmVeSWpSXmKPExsVy+t9jAd0TdW8jDSad4LHYOGM9q8Wxtifs FhNvXGGxaF68ns3i/6PXrBYXnvawWZw/v4Hd4v7Xo4wWmx5fY7W4vGsOm8Xn3iOMFltfvmOy +PTgP7PFomWtzBZbN+1ltrjduILN4vTuEoufh84zWXzd+5nNQdhjw6PVrB5PNl1k9Ni0qpPN 4861PWwe++euYffYvKTe49uZiSwefVtWMXpsvzaP2eP4je1MHp83yQVwR3HZpKTmZJalFunb JXBl3Jo5l71gi3VF/68OxgbGWzpdjJwcEgImEndOLWcEsYUEdjJKrNmeDWLzCghK/Jh8j6WL kYODWUBe4silbAhTXWLKlNwuRi6g6geMEkcnL2OFKNeSmLF3NxNIDYuAqkT7ihCQMBtQeP+L G2wgNr+AosTVH48ZQUpEBSIkuk9UgoRFBE4xSvzYHgMykllgP5PEl/OLmEESwgLxEqsbl7JD 7Opmkjh8ZTsLSIJTwEpi9rUbLBMYBWYhuXQWwqWzEC5dwMi8ilEytaA4Nz232KjAKC+1XK84 Mbe4NC9dLzk/dxMjMCq3Hdbq38H4eEn8IUYBDkYlHl4Gw7eRQqyJZcWVuYcYJTiYlUR451gA hXhTEiurUovy44tKc1KLDzFKc7AoifPy5x+LFBJITyxJzU5NLUgtgskycXBKNTCanP/kwce1 IHWzyu5Hq7/YbZnzac7kM12JC1Uyq4texz3YVtq91e7q/JUMLyynZTZP8WRWWxDFEr8kvOND z1eJkqSPtzhEzL1OVZh/jjthEKm16iXn6VX+/19HHzpm7d+wufu4bTlT29/5zjKyW/N6q1s/ 3MzYLfRCbqXff+MdXGnns4Qru1WUWIozEg21mIuKEwGV97rVxgIAAA== X-CMS-MailID: 20171023053152epcas2p103d99d89995149d6bbad6429c9f8c29c X-Msg-Generator: CA CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171010101758epcas2p3b3f379076f5be5e81edee2bd00354c28 X-RootMTR: 20171010101758epcas2p3b3f379076f5be5e81edee2bd00354c28 References: <1507630671-23536-1-git-send-email-cw00.choi@samsung.com> <59DEE429.2000608@samsung.com> <59E6B90F.8000808@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear all, I got the reviews from all maintainers related to this patch. So, I make the immutable branch on extcon.git and then send the pull request in order to prevent the possible merge conflict. Best Regards, Chanwoo Choi Samsung Electronics The following changes since commit 2bd6bf03f4c1c59381d62c61d03f6cc3fe71f66e: Linux 4.14-rc1 (2017-09-16 15:47:51 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git ib-extcon-v4.15 for you to fetch changes up to 176aa36012135d172394a928a03fb03dfecd83f9: extcon: Split out extcon header file for consumer and provider device (2017-10-23 14:07:58 +0900) ---------------------------------------------------------------- Chanwoo Choi (1): extcon: Split out extcon header file for consumer and provider device drivers/extcon/extcon-adc-jack.c | 2 +- drivers/extcon/extcon-arizona.c | 2 +- drivers/extcon/extcon-axp288.c | 2 +- drivers/extcon/extcon-gpio.c | 2 +- drivers/extcon/extcon-intel-cht-wc.c | 2 +- drivers/extcon/extcon-intel-int3496.c | 2 +- drivers/extcon/extcon-max14577.c | 2 +- drivers/extcon/extcon-max3355.c | 2 +- drivers/extcon/extcon-max77693.c | 2 +- drivers/extcon/extcon-max77843.c | 2 +- drivers/extcon/extcon-max8997.c | 2 +- drivers/extcon/extcon-qcom-spmi-misc.c | 2 +- drivers/extcon/extcon-rt8973a.c | 2 +- drivers/extcon/extcon-sm5502.c | 2 +- drivers/extcon/extcon-usb-gpio.c | 2 +- drivers/extcon/extcon-usbc-cros-ec.c | 2 +- drivers/extcon/extcon.h | 2 +- drivers/phy/allwinner/phy-sun4i-usb.c | 2 +- drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c | 2 +- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 2 +- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 2 +- drivers/power/supply/qcom_smbb.c | 2 +- drivers/usb/gadget/udc/renesas_usb3.c | 2 +- drivers/usb/phy/phy-tahvo.c | 2 +- include/linux/extcon-provider.h | 142 ++++++++++++++++++++++++++ include/linux/extcon.h | 109 +------------------- include/linux/mfd/palmas.h | 2 +- 27 files changed, 172 insertions(+), 129 deletions(-) create mode 100644 include/linux/extcon-provider.h On 2017년 10월 23일 14:05, Kishon Vijay Abraham I wrote: > > > On Wednesday 18 October 2017 07:44 AM, Chanwoo Choi wrote: >> Gently Ping. >> >> Dear Kishon, >> >> Could you please review this patch for 'drivers/phy/*'? > > sorry for the delay.. here it is > > Acked-by: Kishon Vijay Abraham I >> >> Regards, >> Chanwoo Choi >> >> On 2017년 10월 12일 12:40, Chanwoo Choi wrote: >>> Dear Kishon, >>> >>> Could you please review this patch? >>> After that, I'll make the immutable brand and then send the pull request >>> for power_supply, mfd, phy, usb and extcon framework. >>> >>> On 2017년 10월 10일 19:17, Chanwoo Choi wrote: >>>> The extcon has two type of extcon devices as following. >>>> - 'extcon provider deivce' adds new extcon device and detect the >>>> state/properties of external connector. Also, it notifies the >>>> state/properties to the extcon consumer device. >>>> - 'extcon consumer device' gets the change state/properties >>>> from extcon provider device. >>>> Prior to that, include/linux/extcon.h contains all exported API for >>>> both provider and consumer device driver. To clarify the meaning of >>>> header file and to remove the wrong use-case on consumer device, >>>> this patch separates into extcon.h and extcon-provider.h. >>>> >>>> [Description for include/linux/{extcon.h|extcon-provider.h}] >>>> - extcon.h includes the extcon API and data structure for extcon consumer >>>> device driver. This header file contains the following APIs: >>>> : Register/unregister the notifier to catch the change of extcon device >>>> : Get the extcon device instance >>>> : Get the extcon device name >>>> : Get the state of each external connector >>>> : Get the property value of each external connector >>>> : Get the property capability of each external connector >>>> >>>> - extcon-provider.h includes the extcon API and data structure for extcon >>>> provider device driver. This header file contains the following APIs: >>>> : Include 'include/linux/extcon.h' >>>> : Allocate the memory for extcon device instance >>>> : Register/unregister extcon device >>>> : Set the state of each external connector >>>> : Set the property value of each external connector >>>> : Set the property capability of each external connector >>>> >>>> Cc: Felipe Balbi >>>> Cc: Kishon Vijay Abraham I >>>> Cc: Greg Kroah-Hartman >>>> Acked-by: Sebastian Reichel >>>> Acked-by: Chen-Yu Tsai >>>> Acked-by: Charles Keepax >>>> Acked-by: Lee Jones >>>> Signed-off-by: Chanwoo Choi >>>> --- >>>> Changes from v1: >>>> - Don't touch drivers/usb/renesas_usbhs/common.h. >>>> - Add acked-by from Sebastian Reichel (for drivers/power/supply/) >>>> - Add acked-by from Chen-Yu Tsai (for phy-sun4i-usb.c & extcon-axp288.c) >>>> - Add acked-by from Charles Keepax (for drivers/extcon/extcon-arizona.c) >>>> - Add acked-by from Lee Jones (fo include/linux/mfd/palmas.h) >>>> >>>> drivers/extcon/extcon-adc-jack.c | 2 +- >>>> drivers/extcon/extcon-arizona.c | 2 +- >>>> drivers/extcon/extcon-axp288.c | 2 +- >>>> drivers/extcon/extcon-gpio.c | 2 +- >>>> drivers/extcon/extcon-intel-cht-wc.c | 2 +- >>>> drivers/extcon/extcon-intel-int3496.c | 2 +- >>>> drivers/extcon/extcon-max14577.c | 2 +- >>>> drivers/extcon/extcon-max3355.c | 2 +- >>>> drivers/extcon/extcon-max77693.c | 2 +- >>>> drivers/extcon/extcon-max77843.c | 2 +- >>>> drivers/extcon/extcon-max8997.c | 2 +- >>>> drivers/extcon/extcon-qcom-spmi-misc.c | 2 +- >>>> drivers/extcon/extcon-rt8973a.c | 2 +- >>>> drivers/extcon/extcon-sm5502.c | 2 +- >>>> drivers/extcon/extcon-usb-gpio.c | 2 +- >>>> drivers/extcon/extcon-usbc-cros-ec.c | 2 +- >>>> drivers/extcon/extcon.h | 2 +- >>>> drivers/phy/allwinner/phy-sun4i-usb.c | 2 +- >>>> drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c | 2 +- >>>> drivers/phy/renesas/phy-rcar-gen3-usb2.c | 2 +- >>>> drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 2 +- >>>> drivers/power/supply/qcom_smbb.c | 2 +- >>>> drivers/usb/gadget/udc/renesas_usb3.c | 2 +- >>>> drivers/usb/phy/phy-tahvo.c | 2 +- >>>> include/linux/extcon-provider.h | 142 ++++++++++++++++++++++++++ >>>> include/linux/extcon.h | 109 +------------------- >>>> include/linux/mfd/palmas.h | 2 +- >>>> 27 files changed, 172 insertions(+), 129 deletions(-) >>>> create mode 100644 include/linux/extcon-provider.h [snip]